April 2016 - Koha-bugs - lists.koha-community.org

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |gmcharlt(a)gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15414] Noisy warns when creating new layout for patron card creator
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15414 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50689|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 50923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50923&action=ed… Bug 15414: Silencing warns triggered by creating a new layout in patron card creator This patch assigns $field and $image values in the for loops To test: 1) Go to Tools -> Patron Card Creator -> New layout 2) Notice warns 3) Apply patch and refresh page 4) Notice warns are gone and page still works as expected Sponsored-by: Catalyst IT NOTE: Trivial initialization in a loop issue. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15414] Noisy warns when creating new layout for patron card creator
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15414 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 --- Comment #19 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 50921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50921&action=ed… Bug 14144: Clean ups and refactors perltidy old new calls to new call format attrType -> attr_type (perlcritic friendlier) double quotes to single quotes '' combinations to q{} (perlcritic friendlier) refactored parameters to mock_net_ldap_search into a HASH This piece is not necessary, but I think it is nicer. Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Works as expected. No koha-qa erros Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50539|0 |1 is obsolete| | Attachment #50540|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 50920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50920&action=ed… Bug 14144: Silence warnings t/db_dependent/Auth_with_ldap.t Revisiting this bug, I noticed that C4::Context->config() was mocked poorly. I expanded the mock function a little and have quieted the test which seemed to be working in a broken manner before. TEST PLAN --------- 1) prove t/db_dependend/Auth_with_ldap.t -- shibboleth noise 2) apply this patch 3) prove t/db_dependend/Auth_with_ldap.t -- no noise 4) run koha qa test tools Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 --- Comment #46 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Will probably not finish this one today. Doubts about: + charge_ok => ( !$debarred && !$expired && !$fine_blocked && ( $fines_amount < C4::Context->preference('noissuescharge') ) ), + renew_ok => ( !$debarred && !$expired && !$fine_blocked && ( $fines_amount < C4::Context->preference('OPACFineNoRenewals') ) ), What if those prefs are just empty? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #46 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Still needs input from Package Manager about dependencies. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49847|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15126] REST API: Use newer version of Swagger2
by bugzilla-daemon＠bugs.koha-community.org 28 Apr '16

28 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50142|0 |1 is obsolete| | --- Comment #45 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 50919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50919&action=ed… Bug 15126: Update patron definition -- You are receiving this mail because: You are watching all bug changes.

1 0