April 2016 - Koha-bugs - lists.koha-community.org

[Bug 13903] Add API routes to list, create, update, delete holds
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '16

27 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add API routes to list, |Add API routes to list, |create, update, delete |create, update, delete |reserves |holds -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15531] Add support for standing orders
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '16

27 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15531 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer(a)bsz-bw.de --- Comment #14 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- 1) Database update: can you please include an AFTER there to ensure that the column always ends up in the same spot? 2)Add order: "Orders are standing:" basket summary: "Is standing order basket" Non-native speaker :), but wondering if 'Standing order:' would work too? Might cause less confusion in translation. 3) When ordering from a staged file using the checkboxes, it seems that an item is generated, while this doesn't happen when using one of the other order options. This might be something to look into - what's the intended behaviour when AcqCreateItem is set to 'placing an order'? I think to not overcomplicate things for now I think it would be ok to say items for standing orders have to be created separately. Later on, optionally creating items on order/receive would be nice. 4) If you edit the order after creating it - the checkbox is unchecked even if your basket 'is_standing'. 5) The order status of the order lines will remain 'new' (usually means: not send to the vendor, unfinished) as the basket is never closed, which would set it to 'ordered'. Should we use a new order status here? I think it would be good for searching and to help avoid confusion. Maybe 'standing'? Otherwise this seems to work pretty well - with serial subscription orders too! Please take a look asap! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13903] Add API routes to list, create, update, delete reserves
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '16

27 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 --- Comment #19 from Jesse Weaver <jweaver(a)bywatersolutions.com> --- Created attachment 50853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50853&action=ed… Bug 13903: (QA followup) change routes to /holds GET /holds?borrowernumber=X (list) POST /holds (create) PUT /holds/{reserve_id} (update) DELETE /holds/{reserve_id} (delete) Unit tests in t/db_dependent/api/v1/holds.t Signed-off-by: Jesse Weaver <jweaver(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13903] Add API routes to list, create, update, delete reserves
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '16

27 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Jesse Weaver <jweaver(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49843|0 |1 is obsolete| | --- Comment #18 from Jesse Weaver <jweaver(a)bywatersolutions.com> --- Created attachment 50852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50852&action=ed… Bug 13903: Add API routes to list, create, update, delete reserves GET /reserves?borrowernumber=X (list) POST /reserves (create) PUT /reserves/{reserve_id} (update) DELETE /reserves/{reserve_id} (delete) Unit tests in t/db_dependent/api/v1/reserves.t Test plan: 1. Apply patch 2. Run unit tests 3. Play with the API with your favorite REST client, using documentation in the swagger.json file 4. Try to make reserves until the maximum number of reserves for a user is reached (you should have a 403 error) Depends on bug 15126 Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> Signed-off-by: Jesse Weaver <jweaver(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13903] Add API routes to list, create, update, delete reserves
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '16

27 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Jesse Weaver <jweaver(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16362] New: Software error when adding an item to a list in staff client
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '16

27 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16362 Bug ID: 16362 Summary: Software error when adding an item to a list in staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt(a)gmail.com Reporter: aleishaamohia(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl No biblionumber tag for framework "" at /home/vagrant/kohaclone/C4/Biblio.pm line 3034. -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 13877] seasonal predictions showing wrong in test
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '16

27 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13877 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50572|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 50845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50845&action=ed… [SIGNED-OFF] Bug 13877 - Fix QA issues Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13877] seasonal predictions showing wrong in test
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '16

27 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13877 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14377] Indicate that a record is suppressed in staff client
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '16

27 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50843|0 |1 is obsolete| | --- Comment #55 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 50844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50844&action=ed… Bug 14377 [QA Followup] - Fix conditional -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14377] Indicate that a record is suppressed in staff client
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '16

27 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50842|0 |1 is obsolete| | --- Comment #54 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 50843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50843&action=ed… Bug 14377 [QA Followup] - Fix conditional -- You are receiving this mail because: You are watching all bug changes.

1 0