April 2016 - Koha-bugs - lists.koha-community.org

[Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '16

27 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50807|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '16

27 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50806|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '16

27 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50813|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '16

27 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50808|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '16

27 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 --- Comment #42 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 50827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50827&action=ed… [PASSED QA] Bug 15534 [QA Followup] - Fix rule labels Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '16

27 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 --- Comment #41 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 50826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50826&action=ed… [PASSED QA] Bug 15534 [QA Followup] - Use IsItemOnHoldAndFound instead of GetReserveStatus Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '16

27 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 --- Comment #40 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 50825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50825&action=ed… [PASSED QA] Bug 15534 [QA Followup] - Remove superfluous lines from unit tests Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '16

27 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 --- Comment #39 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 50824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50824&action=ed… [PASSED QA] Bug 15534 - Add the ability to prevent a patron from placing a hold on a record with available items Some libraries would like to prevent patrons from placing holds on items where there are other items available for the patron to check out. Test Plan: 1) Apply this patch 2) Browse to the circulation rules 3) Note the new option for "On shelf holds allowed" 4) Set the rule to "If all unavailable", set "item level holds" to allow 5) Find a patron/branch/itemtype applicable to this rule 6) Ensure at least one item on the record is available for the patron to check out 7) Attempt to place a hold for the item 8) Note you cannot place the hold 9) Check the available item out to another patron 10) Note you can now place a hold for the first patron Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace(a)sub.su.se> Works as intended! Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '16

27 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #38 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- 1 = YES (unchanged, we don't care about availability) 2 = If all unavailable (new behaviour) 0 = If any unavailable (former 'no' = old behaviour) Note for 0: old behaviour is also, that item level holds can only be placed on checked out items. Testing with a all-all-all rule at first: 1 item: 1 checked out - Yes: Can place hold - If all unavailable: Can place hold - If any unavailable: Can place hold 1 item: 1 available - Yes: Can place hold - If all unavailable: No hold - If any unavailable: No hold 2 items: 1 checked out, 1 available - Yes: Can place hold, item holds can be placed on both items - If all unavailable: No hold - If any unavailable: Can place hold, item hold only on checked out item 2 items: 1 checked out, 1 available and damaged AllowHoldsOnDamagedItems = No holds - Yes: Can place hold, item hold only on checked out item - If all unavailable: damaged item is not available = can place hold, item level on checked out - If any unavailable: Can place hold, item hold only on cheked out item AllowHoldsOnDamagedItems = Holds allowed - If all unavailable: No hold, damaged item is counted available 2 items: both available, different itemtypes A and B A B 1:0 can place holds, item level only on A 1:1 can place holds, item level on both 1:2 can place holds, item level only on A 2:2 no hold 2:0 no hold 0:0 no hold 2 items: both available, different itemtypes A and B, B checked out A B 1:0 can place holds, item level on both 1:1 can place holds, item level on both 1:2 can place holds, item level only on A 2:2 no hold. 2:0 can place holds, item level only on B 0:0 can place holds, item level only on B and this time also: 0:1 can place holds, item level only on B 2:1 can place holds, item level only on B 0:2 no hold Note: for 2 all items on the record are taken into account, independent of the rule applying to them. More tests could be done, but looking a the code and the results I believe this to be working as intended. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14614] Multiple URLs (856) in cart/list email are broken
by bugzilla-daemon＠bugs.koha-community.org 27 Apr '16

27 Apr '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14614 Frédéric Demians <frederic(a)tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic(a)tamil.fr --- Comment #11 from Frédéric Demians <frederic(a)tamil.fr> --- Pushed to 3.20.x, will be in 3.20.11. -- You are receiving this mail because: You are watching all bug changes.

1 0