May 2016 - Koha-bugs - lists.koha-community.org

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 10 May '16

10 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #39 from Marc Véron <veron(a)veron.ch> --- Testing: - patch applied - dbupdate done - schema updated Test 1: - System preferences CheckPrevCheckout is: 'Unless overridden, DO...' - Category X has: 'NO and try to override system preferences' - Patron (of category X) has: Check previous checkouts: inherited Result: Warning 'This item has previously been checked out to this patron.' Expected: No warning. Test 2: - System preferences CheckPrevCheckout is: 'Unless overridden, DO NOT...' - Category X has: 'YES and try to override system preferences' - Patron (of category X) has: Check previous checkouts: inherited Result: No warning Expected: Warning If I read correctly, I would expect that the patron category settings override the system preferences. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 12478] Elasticsearch support for Koha
by bugzilla-daemon＠bugs.koha-community.org 10 May '16

10 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Jacek Ablewicz <abl(a)biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16489 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16489 [Bug 16489] ES code incorrectly refers to Moose -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6536] Z3950 Search Enhancements: SRU targets and additional XSLT processing
by bugzilla-daemon＠bugs.koha-community.org 10 May '16

10 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Theodoros Theodoropoulos <theod(a)lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16488 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 10 May '16

10 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50286|0 |1 is obsolete| | --- Comment #38 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 51378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51378&action=ed… Rebase on Master Same patch, rebased on master. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 10 May '16

10 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50930|0 |1 is obsolete| | --- Comment #23 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 51377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51377&action=ed… Rebase on master Same patch rebased on master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 10 May '16

10 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #103 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Is it ready to be signed? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7736] Edifact QUOTE and ORDER functionality
by bugzilla-daemon＠bugs.koha-community.org 10 May '16

10 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #173 from Colin Campbell <colin.campbell(a)ptfs-europe.com> --- (In reply to Jonathan Druart from comment #172) > (In reply to Colin Campbell from comment #171) > > (In reply to Jonathan Druart from comment #170) > > > This patchset introduces some uses of CGI->param in list context, please fix. > > > > Any clue as to where? > > grep '=>.*->param' admin/edi_* > > and see commit f3e4b5bbb6b02d7bb6e89d84c0379666eb1e704f > Bug 16154: CGI->multi_param - Force scalar context > should give you some tricks. > > Basically you need to force the scalar context if called in a list context > (when passed to the template). Exactly these are scalar context calls -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3669] Create a template for circ/add_message.pl
by bugzilla-daemon＠bugs.koha-community.org 10 May '16

10 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3669] Create a template for circ/add_message.pl
by bugzilla-daemon＠bugs.koha-community.org 10 May '16

10 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51353|0 |1 is obsolete| | --- Comment #26 from Marc Véron <veron(a)veron.ch> --- Created attachment 51374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51374&action=ed… Bug 3669: Moving 'Add a new message' into a pop up box and adding to patron toolbar This patch moves all the code into an include which can be accessed from the 'Add a new message' link or the patron toolbar. EDIT: Ensuring modal opens on all pages EDIT2: Once the form has been submitted the page will redirect to where you submitted the form from. EDIT3: Fixing indentation of member-add-message.inc Ensuring messages save on every page Fill branch Ensure predefined notes appear Form redirects to where it was submitted from, or just the circulation page. EDIT4: Removing the new include file and moving it all into the modal in the toolbar EDIT5: Removing swp file and unnecessary code duplication by utilising plugins EDIT6: Batch checkout fixes EDIT7: Ensure you do not get JS error from Comment 24 (Batch checkout syspref must be turned on) To test: 1) Go to a patron circ page (circ/circulation.pl?borrowernumber=X) 2) Click 'Add a new message' under Messages 3) Confirm this brings up the modal to add a message. Confirm clicking Save saves your message. If it is an OPAC message (for the user), confirm it shows as expected on the OPAC. 4) Click Cancel. Confirm this closes the modal. 5) Click 'Add message' button in toolbar. Complete steps 3 and 4. 6) Confirm the modal opens from all other pages with the members toolbar. Confirm predefined notes shows. circ/circulation.pl members/moremember.pl members/routing-lists.pl members/statistics.pl members/boraccount.pl members/pay.pl members/maninvoice.pl members/mancredit.pl members/readingrec.pl members/notices.pl members/member-flags.pl members/member-password.pl members/paycollect.pl members/files.pl turn on BatchCheckouts syspref and put in appropriate patron category circ/circulation.pl?borrowernumber=X&batch=1 7) Confirm that the page redirects to where you submitted the form from once you have submitted it. 8) Go to Check Out tab and confirm your message saved (or OPAC, wherever you saved it) Sponsored-by: Catalyst IT Followed test plan, works as expected. (Re-tested for comment #24) Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 10 May '16

10 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #80 from David Cook <dcook(a)prosentient.com.au> --- Fixed the manual error resolution process, so that should be good. Need to add tools/manage-oai-imports to navigation and give it paging, but that should be trivial. Need to improve error handling for Koha::Icarus::Task::Upload::Biblio, and need to add more data validation to Koha::Icarus::Task::Upload and Koha::Icarus::Task::Download... I'm out of time this week, but I'll resume work on these next week. -- You are receiving this mail because: You are watching all bug changes.

1 0