May 2016 - Koha-bugs - lists.koha-community.org

[Bug 3669] Create a template for circ/add_message.pl
by bugzilla-daemon＠bugs.koha-community.org 10 May '16

10 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51353|0 |1 is obsolete| | --- Comment #26 from Marc Véron <veron(a)veron.ch> --- Created attachment 51374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51374&action=ed… Bug 3669: Moving 'Add a new message' into a pop up box and adding to patron toolbar This patch moves all the code into an include which can be accessed from the 'Add a new message' link or the patron toolbar. EDIT: Ensuring modal opens on all pages EDIT2: Once the form has been submitted the page will redirect to where you submitted the form from. EDIT3: Fixing indentation of member-add-message.inc Ensuring messages save on every page Fill branch Ensure predefined notes appear Form redirects to where it was submitted from, or just the circulation page. EDIT4: Removing the new include file and moving it all into the modal in the toolbar EDIT5: Removing swp file and unnecessary code duplication by utilising plugins EDIT6: Batch checkout fixes EDIT7: Ensure you do not get JS error from Comment 24 (Batch checkout syspref must be turned on) To test: 1) Go to a patron circ page (circ/circulation.pl?borrowernumber=X) 2) Click 'Add a new message' under Messages 3) Confirm this brings up the modal to add a message. Confirm clicking Save saves your message. If it is an OPAC message (for the user), confirm it shows as expected on the OPAC. 4) Click Cancel. Confirm this closes the modal. 5) Click 'Add message' button in toolbar. Complete steps 3 and 4. 6) Confirm the modal opens from all other pages with the members toolbar. Confirm predefined notes shows. circ/circulation.pl members/moremember.pl members/routing-lists.pl members/statistics.pl members/boraccount.pl members/pay.pl members/maninvoice.pl members/mancredit.pl members/readingrec.pl members/notices.pl members/member-flags.pl members/member-password.pl members/paycollect.pl members/files.pl turn on BatchCheckouts syspref and put in appropriate patron category circ/circulation.pl?borrowernumber=X&batch=1 7) Confirm that the page redirects to where you submitted the form from once you have submitted it. 8) Go to Check Out tab and confirm your message saved (or OPAC, wherever you saved it) Sponsored-by: Catalyst IT Followed test plan, works as expected. (Re-tested for comment #24) Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 10 May '16

10 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #80 from David Cook <dcook(a)prosentient.com.au> --- Fixed the manual error resolution process, so that should be good. Need to add tools/manage-oai-imports to navigation and give it paging, but that should be trivial. Need to improve error handling for Koha::Icarus::Task::Upload::Biblio, and need to add more data validation to Koha::Icarus::Task::Upload and Koha::Icarus::Task::Download... I'm out of time this week, but I'll resume work on these next week. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10756] Carousel Display of New Titles on OPAC home page
by bugzilla-daemon＠bugs.koha-community.org 10 May '16

10 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 --- Comment #19 from Mason James <mtj(a)kohaaloha.com> --- > > Same for me, it's not conceivable to call this subroutine for each get of > > the opac main page. > > with a warmed cache table, the GetRecentBibs() sub takes around 10ms on my > old slow VM. 10ms seems acceptable? a small missed point.. the GetRecentBibs() sub is only executed if the Caro syspref is manually enabled -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10756] Carousel Display of New Titles on OPAC home page
by bugzilla-daemon＠bugs.koha-community.org 10 May '16

10 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 --- Comment #18 from Mason James <mtj(a)kohaaloha.com> --- (In reply to Jonathan Druart from comment #17) > (In reply to Marcel de Rooy from comment #13) > > On http://www.jacksasylum.eu/ContentFlow/ I only see changelogs until 2010? > > If there is no further development(?), this might be a risk. > > I can see that as blocker, Mason, would it be easy to update the plugin you > used? hi, yes - its very easy to swap the carousel plugin to anything else i'm happy to change the carousel plugin to whatever people desire > (In reply to Frédéric Demians from comment #14) > > I don't see the advantage of this implementation against Bywater plugin. afaik, the big advantage is that the Bywater plugin can't display an *automated* selection of verified cover-images for recently added items i think for the Bywater plugin, a manual list (report?) would need to be created daily, then each item manually verified for a matching amazon image? > > rather see disadvantages, including ContentFlow.js obsolescence (not updated > > since 2010, when jQuery Flipster used by ByWater plugin is actively > > maintained). Reading the code, I don't understand how GetRecentBibs generates > > the list of 'recent' bibs. Why a new table (carousel)? Is it necessary to > > read/re-read this table each time the OPAC main page is loaded? > > Same for me, it's not conceivable to call this subroutine for each get of > the opac main page. with a warmed cache table, the GetRecentBibs() sub takes around 10ms on my old slow VM. 10ms seems acceptable? > Could you please detail what is the purpose of this subroutine? the subroutine returns a list of recently added bibs with verified matching amazon cover images > Why do you need a new table, cache of the image url that's it? yes, thats all - a method of caching the urls is needed for the feature to work at an acceptable speed fyi: i did experiment with memcache - but the speed difference was small/negligible, so i decided upon the convenience of a mysql table instead > Additional comments: > - kohastructure.sql changes are missing thanks, i can do this - no problem > - Amazon lookup should be optional amazon lookups effectively cease (ie: become 0) as the cache table becomes populated so this is probably not needed? (unless i misunderstand your point) > - We have several subroutines in C4::Koha to deal with ISBNs, I am sure you > could reuse thanks for the suggestion, i could use NormalizedISBN() instead > - What are the 150 and 300 hardcoded limits? they are limits to reduce the item list, the values were chosen to give a happy balance of acceptable performance and a good selection of randomised items > - It would be better to use Koha::Object sure, i can do this - no problem > - It would be great to remove all the debug variables, it will ease the > readability i would really prefer to leave the debug/profiling code (should any future problems occur?), i'm happy to tidy/improve the readability of the profiling code -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 10 May '16

10 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #102 from Florent Mara <florent.mara(a)gmail.com> --- This patch has been rebased today. Bug 16426 was backported and fixed. Test plan: 1) Apply this patch. 2) Set dateformat to mm/dd/yyyy. (Koha home->Administration->search for dateformat -> select and save) 3) run 'prove t/db_dependent/Koha/Patrons/Import.t' which should result in 2 file handle warnings and 122 tests passing. 4) Run the online importer ( Koha home->tools->Import patrons) Load PatronDataCSV1.csv sample file with default import parameters. It should result in 165 imported records and 835 not imported because they are not in the expected format. 5) Set dateformat to dd/mm/yyyy. 6) Run the new command line importer 'perl misc/import_patrons.pl -f ~/Downloads/PatronDataCSV1.csv -c -m 'cardnumber' -v' It should load the remaining 835 entries from the sample file. Import complete: Imported: 835 Overwritten: 0 Skipped: 0 Invalid: 165 Total: 1000 7) Optional. Run 'perl misc/import_patrons.pl --help' because you can. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 10 May '16

10 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #101 from Florent Mara <florent.mara(a)gmail.com> --- Created attachment 51372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51372&action=ed… Patrons sample data -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 10 May '16

10 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #100 from Florent Mara <florent.mara(a)gmail.com> --- Created attachment 51371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51371&action=ed… Bug 12598 - Rebase + backport of 16426 plus fixing 16426 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 10 May '16

10 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Florent Mara <florent.mara(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51122|0 |1 is obsolete| | --- Comment #99 from Florent Mara <florent.mara(a)gmail.com> --- Created attachment 51370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51370&action=ed… Bug 12598 - Refactoring Koha::Patrons::Import includes bug fixed for critical date types and header column parsing -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 10 May '16

10 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Florent Mara <florent.mara(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50704|0 |1 is obsolete| | --- Comment #98 from Florent Mara <florent.mara(a)gmail.com> --- Created attachment 51369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51369&action=ed… Bug 12598 - Creating objects in misc/import_patrons.pl and tools/import_borrowers.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 10 May '16

10 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Florent Mara <florent.mara(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50700|0 |1 is obsolete| | --- Comment #97 from Florent Mara <florent.mara(a)gmail.com> --- Created attachment 51368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51368&action=ed… Bug 12598 - More refactoring and regression tests in Koha::Patrons::Import -- You are receiving this mail because: You are watching all bug changes.

1 0