May 2016 - Koha-bugs - lists.koha-community.org

[Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
by bugzilla-daemon＠bugs.koha-community.org 09 May '16

09 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51138|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 51329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51329&action=ed… Bug 13074: Use Koha::Cache to cache the defaults values of a MARC record With the global %default_values_for_mod_from_marc variable, the changes made to the marc_subfield_structure table and especially the links between MARC and DB fields are not safe and might be outdated (if a field is linked/unlinked) Test plan: Under Plack: - Link the barcode field, edit a record and set a barcode. - Remove the mapping for the barcode field and then update again the barcode of the record. The items.barcode DB field must not have been updated. Without this patch, the field should have been updated. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 09 May '16

09 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51318|0 |1 is obsolete| | --- Comment #122 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 51326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51326&action=ed… Bug 11592: MARCView and ISBD followup There are still some leaks, but it is not as a result of the filter, but rather a result of poorly written template files. Bug fixing template files is beyond the scope of this set of patches. TEST PLAN --------- 1) Backup your DB 2) run the following SQL on your DB. > UPDATE marc_subfield_structure set hidden=-8; -- this should set EVERYTHING to hidden across the board. 3) In staff client, set OPACXSLTDetailsDisplay to blank 4) In OPAC, view any detail. -- Normal view may mostly leak values still. -- MARC view may leak values. -- ISBD view may leak values. 5) In staff client, set OPACXSLTDetailsDisplay to default 6) In OPAC, view any detail. -- same issues as step 4 -- 'View Plain' may leak too. 7) 'Save record' -> 'Dublin Core' 8) Apply this patch 9) run koha qa test tools -- should be fine 10) prove -v t/db_dependent/Filter_MARC_ViewPolicy.t -- should pass -- this proves Koha/Filter/MARC/ViewPolicy.pm tweaks too 11) In OPAC, view any detail. -- Normal view: -- Material type comes from the LEADER field. -- Lists this is on will still display -- 'Tags from this library' will still display -- Item information in table will still display (THIS IS BEYOND SCOPE) -- MARC view: -- Record number is leaked (THIS IS BEYOND SCOPE) -- 'View plain' leaks LEADER field. -- ISBD view may leak field headings, but not values. (THIS IS BEYOND SCOPE) 12) In staff client, set OPACXSLTDetailsDisplay to blank 13) In OPAC, view any detail. -- same kind of output as step 10 14) 'Save record' -> BIBTEXT -- Should be next to nothing leaked. 15) 'Save record' -> Dublin Core -- Should be the same or less leaked between the two versions. -- (XML FILTERING IS BEYOND SCOPE) 16) In the staff client, go view the same record. -- it should be mostly hidden in ISBD View. 17) run the following SQL on your DB. > UPDATE marc_subfield_structure set hidden=1; -- this should set EVERYTHING to hidden in OPAC, but not the STAFF across the board. 18) Refresh the staff ISBD page -- values should reappear. 19) View the ISBD details in the OPAC -- values should still be hidden. 20) Check out the OPAC Cart and List -- while the intermediate pages may still leak the download links should leak very minimally. -- (CARTS AND LISTS ARE BEYOND SCOPE, THOUGH THE INTRANET ISBD AND SOME CART/LIST STUFF WERE FIXED BECAUSE OF THE GetISBDView REFACTOR) Expectations: Before Patch - all the OPAC Detail pages will display things After Patch - all the OPAC Detail pages will display much less, and hopefully nothing (though there are known limits). the ISBD detail page in the Staff client will be filtered as well based on STAFF settings. The saving/exporting should generate nearly empty files. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 09 May '16

09 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7736] Edifact QUOTE and ORDER functionality
by bugzilla-daemon＠bugs.koha-community.org 09 May '16

09 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #170 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- This patchset introduces some uses of CGI->param in list context, please fix. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record
by bugzilla-daemon＠bugs.koha-community.org 09 May '16

09 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Fiona Borthwick <fiona.borthwick(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9805] Lost items are un-lost if returned, but not if renewed
by bugzilla-daemon＠bugs.koha-community.org 09 May '16

09 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 --- Comment #50 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #48) > (In reply to Jonathan Druart from comment #46) > > (In reply to Kyle M Hall from comment #45) > > > Created attachment 49165 [details] [review] [review] [review] > > > Bug 9805 [QA Followup] - Stop calling GetMember repeatedly > > > > Kyle, This change looks safe, but it's very hard to say it won't introduce a > > regression. The $borrower var is passed from a sub to another without being > > "refreshed" like it was before this patch. This means we could use an > > outdated data. > > I do not believe this is a valid concern. There is no reason to suspect > there could be any problems caused by this. If we force each subroutine in > Koha to fetch all db data with each call, we will continue to make Koha > slower and slower. If you have a specific scenario in mind where this will > cause an issue, I'm certainly open to amending my position. Otherwise I we > should keep this patch to improve speed and efficiency. Of course it's a valid concern :) It's the same problematic we have for caching. I don't suggest to "fetch all db data with each call", but we need to take care of the obsolescence of the data we manipulate. You are fetching the patron info using GetMemberDetails, which returns accounting data, but AddRenewal modify these infos. At some point your $borrower is obsolete. For instance if SendCirculationAlert (which does not refetch patron infos) needs to access the accounting infos to sent the letter and decide to get if from $borrower, we will have a very hard to debug issue. It would make more sense to have this kind of patches on a separate bug report, not to block the integration of this bugfix into master. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15194] Drop-down menu 'Actions' has problem in 'Saved reports' page with language bottom bar
by bugzilla-daemon＠bugs.koha-community.org 09 May '16

09 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice(a)biblibre.com --- Comment #16 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.7 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers test fails
by bugzilla-daemon＠bugs.koha-community.org 09 May '16

09 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #27 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.7 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13877] seasonal predictions showing wrong in test
by bugzilla-daemon＠bugs.koha-community.org 09 May '16

09 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13877 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice(a)biblibre.com --- Comment #13 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.7 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13041] Can't add user as manager of basket if name includes a single quote
by bugzilla-daemon＠bugs.koha-community.org 09 May '16

09 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice(a)biblibre.com --- Comment #7 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.7 -- You are receiving this mail because: You are watching all bug changes.

1 0