May 2016 - Koha-bugs - lists.koha-community.org

[Bug 3669] Create a template for circ/add_message.pl
by bugzilla-daemon＠bugs.koha-community.org 09 May '16

09 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50976|0 |1 is obsolete| | --- Comment #25 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 51353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51353&action=ed… Bug 3669: Moving 'Add a new message' into a pop up box and adding to patron toolbar This patch moves all the code into an include which can be accessed from the 'Add a new message' link or the patron toolbar. EDIT: Ensuring modal opens on all pages EDIT2: Once the form has been submitted the page will redirect to where you submitted the form from. EDIT3: Fixing indentation of member-add-message.inc Ensuring messages save on every page Fill branch Ensure predefined notes appear Form redirects to where it was submitted from, or just the circulation page. EDIT4: Removing the new include file and moving it all into the modal in the toolbar EDIT5: Removing swp file and unnecessary code duplication by utilising plugins EDIT6: Batch checkout fixes EDIT7: Ensure you do not get JS error from Comment 24 (Batch checkout syspref must be turned on) To test: 1) Go to a patron circ page (circ/circulation.pl?borrowernumber=X) 2) Click 'Add a new message' under Messages 3) Confirm this brings up the modal to add a message. Confirm clicking Save saves your message. If it is an OPAC message (for the user), confirm it shows as expected on the OPAC. 4) Click Cancel. Confirm this closes the modal. 5) Click 'Add message' button in toolbar. Complete steps 3 and 4. 6) Confirm the modal opens from all other pages with the members toolbar. Confirm predefined notes shows. circ/circulation.pl members/moremember.pl members/routing-lists.pl members/statistics.pl members/boraccount.pl members/pay.pl members/maninvoice.pl members/mancredit.pl members/readingrec.pl members/notices.pl members/member-flags.pl members/member-password.pl members/paycollect.pl members/files.pl turn on BatchCheckouts syspref and put in appropriate patron category circ/circulation.pl?borrowernumber=X&batch=1 7) Confirm that the page redirects to where you submitted the form from once you have submitted it. 8) Go to Check Out tab and confirm your message saved (or OPAC, wherever you saved it) Sponsored-by: Catalyst IT Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3669] Create a template for circ/add_message.pl
by bugzilla-daemon＠bugs.koha-community.org 09 May '16

09 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices
by bugzilla-daemon＠bugs.koha-community.org 09 May '16

09 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44283|0 |1 is obsolete| | --- Comment #24 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 51348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51348&action=ed… Bug 11144: Fix sequence of cronjobs: automatic renewal - fines - overdue notices The patch changes the sequence of cronjobs in the crontab example file and in the cron.daily file of the packages. This is why: 1) Renew automatically ... only when we can't renew, we want to 2) Calculate fines ... once the fine are calculated and charged we can print the amount into the 3) Overdue notices Before the change it could happen that you'd charge for an item, that would then be renewed. Or that you'd try to print fine amounts into the overdue notices, when they would only be charged moments later. To test: - configure your system so you have items that should - be charged with fines - renew automatically - configure your crontabs according to the example file or switch the cron.daily in your package installation with the new one - configure your overdue notices so that one should be generated <<items.fine>> - Wait for the cronjobs or schedule them to run earlier - Verify all is well and as it should be Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices
by bugzilla-daemon＠bugs.koha-community.org 09 May '16

09 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9543] Show patrons messaging subscription on holds notification
by bugzilla-daemon＠bugs.koha-community.org 09 May '16

09 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 --- Comment #13 from Chris Kirby <christopherlawrencekirby(a)gmail.com> --- Created attachment 51346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51346&action=ed… Bug 16390: Accounts.t does not need MPL This test fails if you do not have a MPL branch, but a closer look shows that we only need to replace one occurrence. Test plan: Run Accounts.t Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13153] Waiting hold checked in at different library doesn't re-route item to correct library
by bugzilla-daemon＠bugs.koha-community.org 09 May '16

09 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 jdemuth(a)roseville.ca.us <jdemuth(a)roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth(a)roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9543] Show patrons messaging subscription on holds notification
by bugzilla-daemon＠bugs.koha-community.org 09 May '16

09 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Chris Kirby <christopherlawrencekirby(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49940|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9543] Show patrons messaging subscription on holds notification
by bugzilla-daemon＠bugs.koha-community.org 09 May '16

09 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Chris Kirby <christopherlawrencekirby(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49939|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9543] Show patrons messaging subscription on holds notification
by bugzilla-daemon＠bugs.koha-community.org 09 May '16

09 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Chris Kirby <christopherlawrencekirby(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Chris Kirby <christopherlawrencekirby(a)gmail.com> --- -Applied patches - Made sure that SMS driver and TalkingTech sysprefs are defined to enable SMS and Phone preferences for users (SMS driver can be a dummy value). - Placed a hold for a patron - Set patron's messaging preferences to different choices (including none) - Check in the item that is on hold (it has not to be checked out for the test - Verified that below the message "Hold found (item is already waiting") an information appears about the patron's messaging preferences. --Message (notification preference) only appears where a transfer is not required. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] can generate discharge for patron with fines
by bugzilla-daemon＠bugs.koha-community.org 09 May '16

09 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch -- You are receiving this mail because: You are watching all bug changes.

1 0