May 2016 - Koha-bugs - lists.koha-community.org

[Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel(a)gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Hi, found a fail in t/db_dependent/Items.t, subtest 4 of test 10 not ok 4 - items.barcode is not mapped anymore, so the DB column has not been updated # Failed test 'items.barcode is not mapped anymore, so the DB column has not been updated' # at t/db_dependent/Items.t line 661. # got: undef # expected: 'a barcode' # Looks like you failed 1 test of 4. not ok 10 - C4::Items::_build_default_values_for_mod_marc Something in my data? Does not fail in master. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7172] Omnibus for Plack variable scoping problems
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16441 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441 [Bug 16441] C4::Letters::getletter is not plack safe -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9452] C4::Letters does not function under Plack
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16441 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441 [Bug 16441] C4::Letters::getletter is not plack safe -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15262] Run Koha Run. Koha search should be fast again.
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 Marjorie Barry-Vila <marjorie.barry-vila(a)ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila(a)ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10756] Carousel Display of New Titles on OPAC home page
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #17 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #13) > On http://www.jacksasylum.eu/ContentFlow/ I only see changelogs until 2010? > If there is no further development(?), this might be a risk. I can see that as blocker, Mason, would it be easy to update the plugin you used? (In reply to Frédéric Demians from comment #14) > I don't see the advantage of this implementation against Bywater plugin. I > can > rather see disadvantages, including ContentFlow.js obsolescence (not updated > since 2010, when jQuery Flipster used by ByWater plugin is actively > maintained). Reading the code, I don't understand how GetRecentBibs generates > the list of 'recent' bibs. Why a new table (carousel)? Is it necessary to > read/re-read this table each time the OPAC main page is loaded? Same for me, it's not conceivable to call this subroutine for each get of the opac main page. Could you please detail what is the purpose of this subroutine? Why do you need a new table, cache of the image url that's it? Additional comments: - kohastructure.sql changes are missing - Amazon lookup should be optional - We have several subroutines in C4::Koha to deal with ISBNs, I am sure you could reuse - What are the 150 and 300 hardcoded limits? - It would be better to use Koha::Object - It would be great to remove all the debug variables, it will ease the readability -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7540] Add ids to the legend elements to make it easier to tweak with javascript
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7540 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16159 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13597] Amazon 'no image' element needs a 'no-image' class, in the staff client
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13597 --- Comment #8 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Mason James from comment #7) > > On master, I have set a local cover image for 1 record and not for another > > one. > > Launch a search, I get the local cover image for the first record and the > > "No cover image available" for the other one. > > > > Switching off LocalCoverImages, I get the amazon "No image available" image > > Jonathan, on staff, with patch and CSS added, LocalCoverImages off.. you get > the amazon "No image available" image shown? I do not know, I have not tried, why should I? I think I did not get the goal of this patch. Could you please give me the use case and provide a more detailed test plan? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15194] Drop-down menu 'Actions' has problem in 'Saved reports' page with language bottom bar
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15194] Drop-down menu 'Actions' has problem in 'Saved reports' page with language bottom bar
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194 --- Comment #14 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Héctor Eduardo Castro Avalos from comment #12) > Created attachment 51162 [details] > drop-down-menu-spanish > > Hi Marc > > I don't see the option "Delete" -> "Borrar" in spanish Héctor, this patch has nothing to do with this button. I have tested with fr-FR and see the button, check that your user has the correct rights to delete a report (reports_create_reports). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15194] Drop-down menu 'Actions' has problem in 'Saved reports' page with language bottom bar
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15194 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51161|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 51193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51193&action=ed… Bug 15194 - Drop-down menu 'Actions' has problem in 'Saved reports' page with language bottom bar This patch changes the direction of the "actions" menu on the saved reports page so that it popup up instead of down. To test, apply the patch and go to Reports -> Saved reports. - Click the "Actions" menu for any report and confirm that the menu displays above the button instead of below it. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0