May 2016 - Koha-bugs - lists.koha-community.org

[Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636 --- Comment #11 from Blou <philippe.blouin(a)inlibro.com> --- I rebased it. Now, I've asked bouzid to find a way to reproduce it, but that's low on his priority list. As he said previously, the fix is just reproducing the same conditions for the header as for the entries in the table. No need of big research to imagine a scenario where the unfixed code might break, even though it seems all of you have been lucky so far :-) So in that sense, I was under the hope this would go smoother... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15636] DataTables Warning: Requested unknown parameter from opac-detail.tt
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15636 Blou <philippe.blouin(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50146|0 |1 is obsolete| | --- Comment #10 from Blou <philippe.blouin(a)inlibro.com> --- Created attachment 51186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51186&action=ed… Bug 15636 - DataTables Warning: Requested unknown parameter from opac-detail.tt -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10756] Carousel Display of New Titles on OPAC home page
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 Frédéric Demians <frederic(a)tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic(a)tamil.fr --- Comment #14 from Frédéric Demians <frederic(a)tamil.fr> --- I don't see the advantage of this implementation against Bywater plugin. I can rather see disadvantages, including ContentFlow.js obsolescence (not updated since 2010, when jQuery Flipster used by ByWater plugin is actively maintained). Reading the code, I don't understand how GetRecentBibs generates the list of 'recent' bibs. Why a new table (carousel)? Is it necessary to read/re-read this table each time the OPAC main page is loaded? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13041] Can't add user as manager of basket if name includes a single quote
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16386 | Depends on| |16386 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16386 [Bug 16386] Replace the use of "onclick" from patron card creator templates -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10171] Add a header in Advanced Search (staff interface)
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10171 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51112|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 51184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51184&action=ed… Bug 10171: (QA followup) Make search tests use the right form This bug removed the search tab from the main search box, so the tests that use /cgi-bin/koha/catalogue/search.pl for searching, should use the advanced search box instead. To test: - Run $ prove t/db_dependent/www/search_utf8.t => FAIL: Several tests related to searching on the intranet interface fail. - Apply the patch - Run $ prove t/db_dependent/www/search_utf8.t => SUCCESS: Tests pass - Be happy Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10756] Carousel Display of New Titles on OPAC home page
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 --- Comment #13 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Mason: Just wondering why you picked ContentFlow? I once wrote something simple with jquery.jcarousel.min.js and just note that this carousel is considerably larger (18K vs 264K?). BTW I am not saying that we should use the other one :) On http://www.jacksasylum.eu/ContentFlow/ I only see changelogs until 2010? If there is no further development(?), this might be a risk. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10756] Carousel Display of New Titles on OPAC home page
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 --- Comment #12 from Magnus Enger <magnus(a)libriotech.no> --- I have signed off the two original patches from Mason. As noted in the sign off message I found a problem for 13 digit ISBNs that do not start with 978. The third patch attempts to fix this. I think my patch needs a signoff, so I am leaving this bug as "Needs Signoff". -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10756] Carousel Display of New Titles on OPAC home page
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 --- Comment #11 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 51177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51177&action=ed… Bug 10756 - Carousel Display - Followup On first testing this I got a 500 error saying "Can't call method "is_valid" on an undefined value at /home/magnus/scripts/kohaclone/Koha/Carousel.pm line 128." This was caused by a record with an ISBN of "979-10-91414-01-2". The relevant code looks like this: my $isbn_obj = Business::ISBN->new($ii); my $isbn10; $isbn10 = $isbn_obj->as_isbn10; if ( $isbn10->is_valid() ) {...} The documentation for Business::ISBN::as_isbn10 says: "Returns a new ISBN object. If the object is already ISBN-10, this method clones it. If it is an ISBN-13 with the prefix 978, it returns the ISBN-10 equivalent. For all other cases it returns undef." So for an ISBN that starts with 979 like mine did, $isbn10 will be undef and we need to do some extra checking before is_valid(). To test: - Apply the first two patches on this bug and follow their test plan - Make sure you have a new record with an ISBN that starts with 979 - Refresh the front page and observe the error - Apply this patch - Refresh the front page again and notice the absence of the error -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10756] Carousel Display of New Titles on OPAC home page
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10756] Carousel Display of New Titles on OPAC home page
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 --- Comment #10 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 51176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51176&action=ed… Bug 10756 - Carousel Display of New Titles on OPAC home page test plan... 1/ import some bibs into your database for testing (important) $ wget http://www.loc.gov/catdir/cpso/RDAtest/extra_bib_marc.zip $ unzip extra_bib_marc.zip $ bulkmarcimport.pl -b -m ISO2709 -file ./formal_extra_all_final.bib 2/ apply patches 3/ execute atomic update to add syspref and 'Carousel' table $ perl ./installer/data/mysql/atomicupdate/Bug-10756-carousel.pl 4/ open OPAC homepage in web-browser, observe no change 5/ set 'OpacCarousel' syspref to 'display' 6/ open OPAC homepage in web-browser, observe a new carousel :0) extra QA tests... 7/ run 5 carousel tests $ prove ./t/db_dependent/Carousel.t 8/ run qa-tool on patchset $ qa -c 2 Signed-off-by: Magnus Enger <magnus(a)libriotech.no> Followed the test plan, everything worked as expected. The front page displays a nice coverflow widget. More parameters to control the widget would be nice, but that could be added later. On first running this I got a nasty 500 error: "Can't call method "is_valid" on an undefined value at /home/magnus/scripts/kohaclone/Koha/Carousel.pm line 128." But I think I found a cure for that and will propose a followup patch. -- You are receiving this mail because: You are watching all bug changes.

1 0