May 2016 - Koha-bugs - lists.koha-community.org

[Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone"
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #30 from David Cook <dcook(a)prosentient.com.au> --- I don't think this patch is actually a good idea... you're only sometimes - and very unexpectedly - making a DateTime object with a floating timezone. Consider the following from DateTime's perldoc (http://search.cpan.org/~drolsky/DateTime-1.26/lib/DateTime.pm#) "Floating DateTimes The default time zone for new DateTime objects, except where stated otherwise, is the "floating" time zone. This concept comes from the iCal standard. A floating datetime is one which is not anchored to any particular time zone. In addition, floating datetimes do not include leap seconds, since we cannot apply them without knowing the datetime's time zone. The results of date math and comparison between a floating datetime and one with a real time zone are not really valid, because one includes leap seconds and the other does not. Similarly, the results of datetime math between two floating datetimes and two datetimes with time zones are not really comparable. If you are planning to use any objects with a real time zone, it is strongly recommended that you do not mix these with floating datetimes." -- I think it would be smarter to actually review where we're using timezones and re-read http://search.cpan.org/~drolsky/DateTime-1.26/lib/DateTime.pm#How_DateTime_…. -- Another idea would be to use DateTime->ymd() instead of DateTime->truncate() (http://search.cpan.org/~drolsky/DateTime-1.26/lib/DateTime.pm#$dt->ymd(_$optional_separator_),_$dt->mdy(...),_$dt->dmy(...)), so that you're actually just comparing the date portion of a datestamp rather than possibly creating an invalid local time. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8966] Koha::Calendar::is_holiday truncates the date
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8966 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16376 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8966] Koha::Calendar::is_holiday truncates the date
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8966 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #8 from David Cook <dcook(a)prosentient.com.au> --- I just noticed that the Calendar.t uses a DateTime object with a timezone of Europe/London. If we change the test to include the following, my $dt = DateTime->new( month => 9, year => 2015, day => 6, hour => 12, minute => 00, second => 00, time_zone => 'America/Santiago', ); my $calendar = Koha::Calendar->new(branchcode => "MAIN"); $calendar->is_holiday($dt); We'll get a fatal error with the following message: Invalid local time for date in time zone: America/Santiago See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13041] Can't add user as manager of basket if name includes a single quote
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13041 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16386 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14605] The description on pay/write off individual fine is wrong
by bugzilla-daemon＠bugs.koha-community.org 04 May '16

04 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel(a)gmail.com --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- (In reply to Blou from comment #9) > I rebased. > Regarding the "issues": The biblio's title was not part of the previous > functionality That's correct. It can be done, but I think in another bug. > As for correcting the current DB, that's feasible, but a bit dodgy. I don't know if it's possible, description in accountlines must be set initially. A fee entry does not reference the original biblio. I think that correct Status for this is Signed off, no problem if you need another sign but it's already signed by Mirko. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14668] Show serial enumeration in the checkin page and the patron's opac checkout summary
by bugzilla-daemon＠bugs.koha-community.org 03 May '16

03 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14668 Blou <philippe.blouin(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13430 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13430] Serial enumeration not visible when handling Serial Items. Show enumerations for Serial Items in the circ- and member-modules.
by bugzilla-daemon＠bugs.koha-community.org 03 May '16

03 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13430 Blou <philippe.blouin(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer(a)inlibro.com, | |francois.charbonnier@inlibr | |o.com, | |philippe.blouin(a)inlibro.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14668 --- Comment #6 from Blou <philippe.blouin(a)inlibro.com> --- Olli-Antti, any plan to fix this patch? Our first attemp at #14668 included changes you're making for this one. We cut them but are hoping this one goes through. Please let us know if you do not plan to move ahead. Thanks! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14605] The description on pay/write off individual fine is wrong
by bugzilla-daemon＠bugs.koha-community.org 03 May '16

03 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 Blou <philippe.blouin(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #9 from Blou <philippe.blouin(a)inlibro.com> --- I rebased. Regarding the "issues": The biblio's title was not part of the previous functionality, and I don't think it's right anyway, since I presume fines can be for things other than associated to a biblio. As for correcting the current DB, that's feasible, but a bit dodgy. I would really fear to replace perfectly valid subjects (corrected manually by the employee), and validating what is right or not might be a bit too much work for what it's worth. This patch is here to correct make life easier in the future, but it's not correcting a major bug that's worth a big discussion on "How to fix the current data", don't you think? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14605] The description on pay/write off individual fine is wrong
by bugzilla-daemon＠bugs.koha-community.org 03 May '16

03 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 Blou <philippe.blouin(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41218|0 |1 is obsolete| | --- Comment #8 from Blou <philippe.blouin(a)inlibro.com> --- Created attachment 51168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51168&action=ed… Bug 14605 - Corrects the individual fine's description When paying a fine, the description is built out of the borrower's type and title, instead of the actual fine's description. STEPS: 1) in the staff, go to a user with a fine to pay. a) if none, go to a user and Fines>>"Create manual invoice" with a distinctive description. 2) In Fines>>Pay fines, click the "Pay" button on the line of the fine. 3) This will take you a "Pay an individual fine" screen, where the description will look like "Staff Mrs", for the category and title of the borrower. Signed-off-by: Mirko Tietgen <mirko(a)abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8373] opacheader should not show in print layout
by bugzilla-daemon＠bugs.koha-community.org 03 May '16

03 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8373 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes.

1 0