May 2016 - Koha-bugs - lists.koha-community.org

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 02 May '16

02 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48871|0 |1 is obsolete| | --- Comment #52 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 51084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51084&action=ed… Bug 13321: Csv export - Display rrp and ecost with and without taxes If a basketgroup is exported as a CSV file, both prices should be displayed to avoid confusion. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 02 May '16

02 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48870|0 |1 is obsolete| | --- Comment #51 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 51083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51083&action=ed… Bug 13321: Tax and prices calculation - DB Changes This patch adds 7 columns to the aqorders table: * unitprice_tax_excluded * unitprice_tax_included * rrp_tax_excluded * rrp_tax_included * ecost_tax_excluded * ecost_tax_included * tax_value It also renames: * aqorders.gstrate with aqorders.tax_rate * aqbooksellers.gstrate with aqbooksellers.tax_rate The new columns are filled with the previous calculation method. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 02 May '16

02 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48869|0 |1 is obsolete| | --- Comment #50 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 51082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51082&action=ed… Bug 13321: Fix the prices calculation method Well, we have finally arrived here \o/ The method where the prices are calculated uses the equations listed on the wiki page (http://wiki.koha-community.org/wiki/GST_Rewrite_RFC) The ecost is calculated from the rrp (using the discount and the tax rate). That's why we removed the ability to edit this value. That's why we remove the ability to edit the ecost on ordering in a previous commit (bug 12840). The total is now calculated in the scripts. That's why this patch removes lines in the test file. In C4::Acquisition::populate_order_with_prices, the calculation on receiving must depend on the 'invoiceincgst' supplier parameter, and not listincgst (which is used on ordering). It also removes the rounding errors, now we store "exact" values in DB (10^-6). The values will be displayed using the Price TT plugin it will round the values for us. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 02 May '16

02 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48868|0 |1 is obsolete| | --- Comment #49 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 51081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51081&action=ed… Bug 13321: use the populate_with_prices where needed Now we need to calculate the prices (ecost, rrp, unitprice) and tax (tax_rate, tax_value) when the price is set for an order. This only appends in the 3 files impacted by this patch. addorder*.pl on ordering finishreceive.pl on receiving Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 02 May '16

02 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48867|0 |1 is obsolete| | --- Comment #48 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 51080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51080&action=ed… Bug 13321: Rename variables This patch renames the variable according to the new DB column names * gste => tax_excluded * gsti => tax_included * gstrate => tax_rate * gstvalue => tax_value This patch also modify the ModReceiveOrder subroutine: * Edit vendor note on receiving is not possible, so the code should not permit that. * Update ModReceiveOrder to pass a hashref And that's all! git grep on gste, gsti, gstrate and gstvalue should not return any code that can be executed. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee
by bugzilla-daemon＠bugs.koha-community.org 02 May '16

02 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16405 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405 [Bug 16405] Fix Circulation/NoIssuesChargeGuarantees.t test 2 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items
by bugzilla-daemon＠bugs.koha-community.org 02 May '16

02 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16404 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16404 [Bug 16404] Fix Circulation/Branch.t (tests 8-11) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11088] Patron entry page should use floating toolbar like cataloging interface
by bugzilla-daemon＠bugs.koha-community.org 02 May '16

02 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11088 --- Comment #24 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Owen Leonard from comment #23) > (In reply to Jonathan Druart from comment #22) > > When saving a patron, it will be at the bottom right. > > Should not we keep a consistency? > > Aleisha and I both tried to implement the floating toolbar for this bug in > the same way that it is implemented elsewhere, but the hidden form fields in > the search header make it difficult to implement the fixfloat() > functionality correctly (See Comment 2). I think I have managed to fix the issue on bug 16400, please have a look. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 02 May '16

02 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #300 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #299) > Hm, history.txt ends in December last year: > December 26 2015 Koha 3.20.7.1 released releases > New bug or fix that here? Chris regularly updated that one until now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 6416] koha-remove fails when dropping user
by bugzilla-daemon＠bugs.koha-community.org 02 May '16

02 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6416 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16410 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0