May 2016 - Koha-bugs - lists.koha-community.org

[Bug 10459] borrowers should have a timestamp
by bugzilla-daemon＠bugs.koha-community.org 02 May '16

02 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 --- Comment #35 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Katrin Fischer from comment #33) > It looks like we have a 'ton' of timestamp in the database. Apart from that > there seems to be no existing other schema for timestamps columns that I > could spot. I am not opposed to changing it - I think that's what Marcel > wanted to do? Indeed! I think we should standardize on a single format. I think "updated_on" for timestamps that are set on each update and "created_on" for timestamps that are only set at the time of creation would be appropriate. We could have a vote at the next dev meeting to formalize this ( or another proposed format ) and add it to the coding guidelines. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15562] Make Koha more suitable for shared hosting with plack
by bugzilla-daemon＠bugs.koha-community.org 02 May '16

02 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 --- Comment #41 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Jesse Weaver from comment #40) > I think that may be a devbox-specific problem, Kyle; this works for me, at > least in a single-site (OPAC/intranet) git installation. > > Though note that I used koha-multi.psgi, after adding: > > use Koha::Handler::Plack::CGI; Excellent! Do you think you can sign off on the patch set? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11089] Item edit screen should use floating toolbar like cataloging interface
by bugzilla-daemon＠bugs.koha-community.org 02 May '16

02 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11089 --- Comment #5 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Please see bug 16400 before QAing this patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14878] Tests - Create the branchcodes if needed
by bugzilla-daemon＠bugs.koha-community.org 02 May '16

02 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14878 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16390 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16390 [Bug 16390] Accounts.t does not need MPL -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days
by bugzilla-daemon＠bugs.koha-community.org 02 May '16

02 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16390 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16390 [Bug 16390] Accounts.t does not need MPL -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16406] New: Fix Context.t tests 27, 37
by bugzilla-daemon＠bugs.koha-community.org 02 May '16

02 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16406 Bug ID: 16406 Summary: Fix Context.t tests 27, 37 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: gmcharlt(a)gmail.com Resolves: t/db_dependent/Context.t (Wstat: 512 Tests: 40 Failed: 2) Failed tests: 27, 37 Non-zero exit status: 2 -- You are receiving this mail because: You are watching all bug changes.

1 5

[Bug 15581] Add a circ rule to limit the auto renewals given a delay
by bugzilla-daemon＠bugs.koha-community.org 02 May '16

02 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15581 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #21 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #20) > (In reply to Kyle M Hall from comment #19) > > Would you please update the code to pass the object instead of the keys? It > > makes sense to avoid fetching all this data multiple times when there is no > > need to do so. > > Kyle, > I have written GetLatestAutoRenewDate following the same pattern as > GetSoonestRenewDate. I have noticed the inconsistencies in this part of code > but opted to keep it as it instead of making the code diverge. > If you agree I'd prefer to fix the two subroutines on another bug report, > instead of adding a follow-up on this one. That sounds like a good plan to me! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14695] Add ability to place multiple item holds on a given record per patron
by bugzilla-daemon＠bugs.koha-community.org 02 May '16

02 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #132 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Benjamin Daeuber from comment #131) > Quick feedback on a few quirks. I don't know if any of these would prevent > closing this and pushing it to master, but nonetheless: > > In Circ Client > > 1. It appears staff can place item level holds when this feature is on, > regardless of whether item level holds are allowed. We tested on Wednesday, > and it appears Nicole has already identified this. I'll look into this! > > 2. The holds to place count (up to three) is set to 3. Select one barcode, > set “holds to place” dropdown to 3, and it only does one hold on the item. > This seems to be unexpected, but we don’t really know why that dropdown box > is there or what it is for. The "Holds to place" does not do anything when placing item specific holds. The last patch in this series should hide that pulldown when the record-level hold checkbox is unchecked. > > 3. Put three items on hold on one record. Once you check in one of the three > items you placed on hold, and it is now “waiting” for the patron, you can > place the fourth hold. You don’t need to check it out to the patron before > being able to place the fourth hold. Is this expected behavior? Yes. That is standard Koha behavior. > > In the OPAC > > 1. Related to point 1 above, this does not appear to affect the OPAC. Users > are blocked from placing item level holds if they are not allowed. > > In both > > 1. Item level holds seem to be disregarded by the hold limit. So if you have > a limit of 10, with 9 items on hold, you can still place 2 item level holds. > We haven’t tested this in more detail. This is also standard Koha behavior. If you want more accurate hold limits, you need to add a record level itemtype to each record so that Koha will have a fallback itemtype to check if the hold is a record level hold and not item level. > > 2. A patron can’t place a bib level and item level hold for the same item. > I’m actually struggling to think what scenario this might be used in, but > we’re nothing if not thorough. That is also intentional and expected behavior. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 02 May '16

02 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #54 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patches rebased on master + 1st patch amended to use $order->{ordernumber} instead of $ordernumber -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 02 May '16

02 May '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48872|0 |1 is obsolete| | --- Comment #53 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 51085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51085&action=ed… Bug 13321: Fix unitprice rounding We need to display the rounded value, but insert the exact value. The unit price can be change on receiving, so the input value can be modified. But if it's not, we must insert the exact (not rounded) unit price, which is the ecost value. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0