June 2016 - Koha-bugs - lists.koha-community.org

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '16

12 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 --- Comment #46 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52279&action=ed… Bug 6906: Tests - Do not assume CPL exists Since bug 14878, tests must create the data they need to pass and not assume they exist. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '16

12 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51378|0 |1 is obsolete| | Attachment #51393|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52278&action=ed… Bug 6906 - show 'Borrower has previously issued... New feature: provide granular means to configure warnings about items that have been issued to a particular borrower before, according to their checkout history. - Global syspref ('CheckPrevCheckout'), set to 'hardno' by default, allows users to enable this feature library wide. - Per patron category pref allows libraries to create overrides per category, falling back on the global setting by default. - Per patron pref allows switching the functionality on at the level of patron. Fall-back to category settings by default. * Koha/Patron (wantsCheckPrevCheckout, doCheckPrevCheckout): New methods. * C4/Circulation.pm (CanBookBeIssued): Introduce CheckPrevCheckout check. * admin/categories.pl: Pass along checkprevcheckout. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt: Expose CheckPrevCheckout per category setting. * koha-tmpl/intranet-tmpl/prog/en/modules/preferences/patrons.pref: Expose CheckPrevCheckout syspref. * koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: Expose per patron CheckPrevCheckout preference. * koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt: Expose per patron CheckPrevCheckout preference. * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: Add 'CHECKPREVCHECKOUT' confirmation message. * installer/data/mysql/kohastructure.sql: Modify structure of 'categories', 'borrowers', 'oldborrowers'. * installer/data/mysql/sysprefs.sql: Add 'CheckPrevCheckout'. * installer/data/mysql/atomicupdate/checkPrevCheckout.sql: New file. * t/db_dependent/Patron/CheckPrevCheckout.t: New file with unit tests. Test plan: - Apply patch. - Run updatedatabase. - Regenerate Koha Schema files. - Run the unit tests. - Verify 'CheckPrevCheckout' is visible in Patrons sysprefs and can be switched to 'hardyes', 'softyes', 'softno' and 'hardno'. + Check out previously checked out items to a patron, checking the message appears as expected. - Verify no 'Check previous checkouts' setting appears on the borrower category pages if the syspref is set to a 'hard' option. - Verify 'Check previous checkouts' setting appears on the borrower category pages and can be modified per borrower category. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the default setting if that is set to a 'soft' option). - Verify no 'Check previous checkouts' setting appears on the individual borrower pages if the syspref is set to a 'hard' option. - Verify 'Check previous checkouts' setting appears on individual borrower pages and can be modified. + Issue previously issued items to a borrower, checking the message appears as expected (This setting should override the category setting and the default setting if the latter is set to a 'soft' option). Followed test plan, works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '16

12 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 3669] Create a template for circ/add_message.pl
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '16

12 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 --- Comment #28 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- It would be nicer to get a message to inform the librarian that the message has been added successfully. Actually it would have been better to ajaxify this script, to avoid the reload and the problematic of POST form. Owen, do you think this is an acceptable solution and then we should ajaxify this script? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3669] Create a template for circ/add_message.pl
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '16

12 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 --- Comment #27 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52277&action=ed… Bug 3669: Remove parameters passed to action of form Sounds weird to pass parameters to the action of a POST form. This patch adds a workaround. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '16

12 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 --- Comment #32 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- As this is a major one, I'd suggest to move the automatic_renewals script before the fines calculation, and then open a new bug report for the error handling problem. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices
by bugzilla-daemon＠bugs.koha-community.org 12 Jun '16

12 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 --- Comment #31 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Katrin, I may be a bit lost here, but with this patch, the behavior changes between package and non-package installs. (In reply to Katrin Fischer from comment #29) > Please note: This whole discussion is about the file for non-package setups. > I think the behaviour for packages is different anyway. As we are using > packages I am fine with any solution. We use debian/koha-common.cron.daily > as changed in this patch for several versions now. The discussion is for both setups, as we want to have the same behavior :) What I understand is that, using packages, the overdue notices will be generated even if the fines are not generated correctly. And it's not what you want apparently. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2422] Cataloging searches with more than 1 page results show blank pages after page 1
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '16

11 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2422 Nicholas van Oudtshoorn <vanoudt(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |16.05 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2422] Cataloging searches with more than 1 page results show blank pages after page 1
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '16

11 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2422 --- Comment #15 from Nicholas van Oudtshoorn <vanoudt(a)gmail.com> --- Hmmmm.... I think my patch might be masking the problem (needed a quick fix!) I'll see about rolling a version without the patch this Thursday when I'm back in at that job 😃 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2422] Cataloging searches with more than 1 page results show blank pages after page 1
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '16

11 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2422 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.20 |unspecified -- You are receiving this mail because: You are watching all bug changes.

1 0