June 2016 - Koha-bugs - lists.koha-community.org

[Bug 14897] Header name mismatch in ./modules/catalogue/detail.tt
by bugzilla-daemon＠bugs.koha-community.org 10 Jun '16

10 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14897 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed to master for Koha 16.11, thanks Dimitris! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14605] The description on pay/write off individual fine is wrong
by bugzilla-daemon＠bugs.koha-community.org 10 Jun '16

10 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #13 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed to master for 16.11, thanks Philippe! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10459] borrowers should have a timestamp
by bugzilla-daemon＠bugs.koha-community.org 10 Jun '16

10 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #68 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed to master for 16.11, thanks Marcel, Mark and Jonathan! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
by bugzilla-daemon＠bugs.koha-community.org 10 Jun '16

10 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 --- Comment #11 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #10) > (In reply to Nick Clemens from comment #7) > > Small conflict in Items.pm > > > > Also, did you mean to use $another_barcode here: > > 660 $item = GetItem($item_itemnumber); > > 661 is ( $item->{barcode}, $a_barcode, 'items.barcode is not mapped > > anymore, so the DB column has not been updated' ); > > No I don't think so. > I don't remember exactly what I did, just remember that they were crazy > tests to write... Ok so actually we do not want to update the DB column because the marc field is not mapped. Just what the test description says :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
by bugzilla-daemon＠bugs.koha-community.org 10 Jun '16

10 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #10 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Nick Clemens from comment #7) > Small conflict in Items.pm > > Also, did you mean to use $another_barcode here: > 660 $item = GetItem($item_itemnumber); > 661 is ( $item->{barcode}, $a_barcode, 'items.barcode is not mapped > anymore, so the DB column has not been updated' ); No I don't think so. I don't remember exactly what I did, just remember that they were crazy tests to write... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
by bugzilla-daemon＠bugs.koha-community.org 10 Jun '16

10 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 --- Comment #9 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52250&action=ed… Bug 13074: (followup) remove useless diag On running all Items-related tests some useless diag showed up. Removing it. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
by bugzilla-daemon＠bugs.koha-community.org 10 Jun '16

10 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51329|0 |1 is obsolete| | Attachment #51330|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52249&action=ed… Bug 13074: Use Koha::Cache to cache the defaults values of a MARC record With the global %default_values_for_mod_from_marc variable, the changes made to the marc_subfield_structure table and especially the links between MARC and DB fields are not safe and might be outdated (if a field is linked/unlinked) Test plan: Under Plack: - Link the barcode field, edit a record and set a barcode. - Remove the mapping for the barcode field and then update again the barcode of the record. The items.barcode DB field must not have been updated. Without this patch, the field should have been updated. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14605] The description on pay/write off individual fine is wrong
by bugzilla-daemon＠bugs.koha-community.org 10 Jun '16

10 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51929|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 52248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52248&action=ed… Bug 14605 - Corrects the individual fine's description When paying a fine, the description is built out of the borrower's type and title, instead of the actual fine's description. STEPS: 1) in the staff, go to a user with a fine to pay. a) if none, go to a user and Fines>>"Create manual invoice" with a distinctive description. 2) In Fines>>Pay fines, click the "Pay" button on the line of the fine. 3) This will take you a "Pay an individual fine" screen, where the description will look like "Staff Mrs", for the category and title of the borrower. Signed-off-by: Mirko Tietgen <mirko(a)abunchofthings.net> Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14605] The description on pay/write off individual fine is wrong
by bugzilla-daemon＠bugs.koha-community.org 10 Jun '16

10 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache
by bugzilla-daemon＠bugs.koha-community.org 10 Jun '16

10 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |nick(a)bywatersolutions.com --- Comment #7 from Nick Clemens <nick(a)bywatersolutions.com> --- Small conflict in Items.pm Also, did you mean to use $another_barcode here: 660 $item = GetItem($item_itemnumber); 661 is ( $item->{barcode}, $a_barcode, 'items.barcode is not mapped anymore, so the DB column has not been updated' ); -- You are receiving this mail because: You are watching all bug changes.

1 0