June 2016 - Koha-bugs - lists.koha-community.org

[Bug 9701] Configure default indicator
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '16

08 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 PTFS Europe Sandboxes <sandboxes(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |sandboxes(a)ptfs-europe.com --- Comment #10 from PTFS Europe Sandboxes <sandboxes(a)ptfs-europe.com> --- Patch tested with a sandbox, by Eugene Jose Espinoza <eugenegf(a)yahoo.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15485] Allow choosing different XSLTs for lists
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '16

08 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15485 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen(a)gmail.com Summary|Show 520 on lists |Allow choosing different | |XSLTs for lists -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicator
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '16

08 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 --- Comment #9 from Eugene Espinoza <eugenegf(a)yahoo.com> --- Looks great now! :) I'm signing this one off. I have a question though but might not be related with this enhancement. When the tag is cloned/repeated and the indicator of this cloned tag is not the default indicator, it's not the difficult indicator that appears instead the indicator in the repeated/cloned tag. Well, that I guess is for another bug. But this enhancement does what original poster requested. Thanks a lot Joachim! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12375] Store serials enumeration data in separate fields
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '16

07 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12375 Jacek Ablewicz <abl(a)biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl(a)biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7595] Add branchcode to accountlines
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '16

07 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #38 from M. Tompsett <mtompset(a)hotmail.com> --- [SEVERELY EDIT'D AND REORDERED] (In reply to Kyle M Hall from comment #37) > (In reply to M. Tompsett from comment #36) > > chargelostitem, > > manualinvoice, > > _FixAccountForLostAndReturned > > makepayment, > > recordpayment_selectaccts, > > makepartialpayment > payment handling subroutines... unified by bug 15894. > Bug 15894 will include unit testing for payments. ... > chargelostitem, > manualinvoice, > _FixAccountForLostAndReturned ... > How does that sound? If 15894 will include testing for > makepayment, > recordpayment_selectaccts, > makepartialpayment then that would seem acceptable to me. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '16

07 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #14 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 52170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52170&action=ed… Bug 14048: (followup) move atomicupdate to SQL-based Somehow, the atomic update wasn't working. I'll fill a different bug for that. In the meantime this dev should move on as it doesn't strictly need the .perl atomic update. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '16

07 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #13 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 52169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52169&action=ed… Bug 14048: (QA followup) Rules should be defined for the chosen branch (or all) The original patches pull all defined rules for edition in the "Circulation and fines rules" page. This was not the intended behaviour for smart-rules.pl Instead, the modified rules should be constrained to the chosen branch (or the general default rule). This patch changes the templates and front-end scripts so they behave like that. To test: - Apply the patch - Open smart-rules.pl => SUCCESS: The text and refund rules section correctly refers to default global rules. The policy can be set to Yes and No, and works as expected. - Pick a specific branch => SUCCESS: The rule refers to the specific branch => SUCCESS: It detects the default rule is picked => SUCCESS: On changing the rules values are correctly retrieved if entering again to the page. => SUCCESS: The 'Use default' text is suffixed with the correct value set by the user in the 'All libraries' scenario. => Sign off :-D Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System ponsored-by: SWITCH Library Consortium -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7595] Add branchcode to accountlines
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '16

07 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #37 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to M. Tompsett from comment #36) > (In reply to Jonathan Druart from comment #35) > > Please provide tests for changes in modules. > > True, most is covered: > t/db_dependent/Accounts.t > t/db_dependent/Circulation.t > t/db_dependent/Circulation_issue.t > t/db_dependent/Reserves.t > > However, the makepayment, chargelostitem, manualinvoice, > recordpayment_selectaccts, and makepartialpayment need test coverage. > I'm also not certain how to trigger _FixAccountForLostAndReturned, except > that AddIssue does call it. I'm going to argue that we should for the time being, pass on tests for the three payment handling subroutines, as they will be unified by bug 15894. If this is agreeable, I will write tests for chargelostitem, manualinvoice, and _FixAccountForLostAndReturned. Bug 15894 will include unit testing for payments. How does that sound? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8483] Borrower reading history should include deleted items
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '16

07 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #54 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #53) > (In reply to Kyle M Hall from comment #51) > > I need someone to tell me what needs changed in order to for this to pqa. > > All of these changes are internal to Koha::Object and it's children. Taking > > advantage of the underlying DBIC object should not be an issue. Can someone > > please tell me specifically what needs to be changed? > > I am sorry but I do not have any good answers. > It seems that we are stuck with our Koha::Object[s] implementation at > different places. Here you are trying to cache something when we should rely > on DBIx::Class. Can you describe how we should be relying on DBIx::Class here? Are you saying I should be getting the data via the underlying DBIC connection which I can then wrap and return? If so I can do that! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '16

07 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28144|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 52168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52168&action=ed… Bug 7703 - QA Followup 2 -- You are receiving this mail because: You are watching all bug changes.

1 0