June 2016 - Koha-bugs - lists.koha-community.org

[Bug 7595] Add branchcode to accountlines
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '16

07 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #37 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to M. Tompsett from comment #36) > (In reply to Jonathan Druart from comment #35) > > Please provide tests for changes in modules. > > True, most is covered: > t/db_dependent/Accounts.t > t/db_dependent/Circulation.t > t/db_dependent/Circulation_issue.t > t/db_dependent/Reserves.t > > However, the makepayment, chargelostitem, manualinvoice, > recordpayment_selectaccts, and makepartialpayment need test coverage. > I'm also not certain how to trigger _FixAccountForLostAndReturned, except > that AddIssue does call it. I'm going to argue that we should for the time being, pass on tests for the three payment handling subroutines, as they will be unified by bug 15894. If this is agreeable, I will write tests for chargelostitem, manualinvoice, and _FixAccountForLostAndReturned. Bug 15894 will include unit testing for payments. How does that sound? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8483] Borrower reading history should include deleted items
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '16

07 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #54 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #53) > (In reply to Kyle M Hall from comment #51) > > I need someone to tell me what needs changed in order to for this to pqa. > > All of these changes are internal to Koha::Object and it's children. Taking > > advantage of the underlying DBIC object should not be an issue. Can someone > > please tell me specifically what needs to be changed? > > I am sorry but I do not have any good answers. > It seems that we are stuck with our Koha::Object[s] implementation at > different places. Here you are trying to cache something when we should rely > on DBIx::Class. Can you describe how we should be relying on DBIx::Class here? Are you saying I should be getting the data via the underlying DBIC connection which I can then wrap and return? If so I can do that! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '16

07 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28144|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 52168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52168&action=ed… Bug 7703 - QA Followup 2 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '16

07 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19115|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 52167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52167&action=ed… Bug 7703 - QA Followup -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '16

07 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 --- Comment #26 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 52166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52166&action=ed… Bug 7703 - Don't block bulk hold action if some items can't be placed on hold If you select multiple titles on the search results page in order to place a bulk hold and some of those titles have no items you get a JavaScript alert warning you can some cannot be placed on hold. You are blocked from completing the action until you deselect the invalid hold. This is unnecessary because the bulk hold process will safely refuse to place a hold on these titles later in the process. This patch removes the check that prevents submitting a multi-hold if one or more records in the multi-hold have no items. Test plan: 1) Apply patch 2) On the staff interface, do a search 3) On the search results, select at least one record with items and one record with no items. 4) Click the 'Place hold' button. 5) You should be redirected to reserve/request.pl with the message "Cannot place hold: this record has no items attached." Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Added a description of the problem and copied the test plan from the bug report, fulfilling commit message guidelines. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '16

07 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6664] enhancements to repeatable holidays
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '16

07 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6664 Amy Kearns <amy(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amy(a)bywatersolutions.com --- Comment #2 from Amy Kearns <amy(a)bywatersolutions.com> --- It seems hard to believe it is not possible to do this. I am sure many of our partners would want to be able to schedule this way on their calendars. Thanks! Amy -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 15630] Make Edifact module pluggable
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '16

07 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15630 --- Comment #15 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #14) > (In reply to David Cook from comment #13) > > > > +use Module::Pluggable search_path => ['Koha::Plugin'], except => qr/::Edifact(|::Line|::Message|::Order|::Segment|::Transport)$/; > > > > This seems suboptimal... since any plugin with additional packages would > > need an exception. > > Have the same feeling when I see these lines.. I agree. I'm sure there is a better solution! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '16

07 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14695] Add ability to place multiple item holds on a given record per patron
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '16

07 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #147 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #146) > (In reply to Kyle M Hall from comment #132) > > (In reply to Benjamin Daeuber from comment #131) > > > 1. It appears staff can place item level holds when this feature is on, > > > regardless of whether item level holds are allowed. We tested on Wednesday, > > > and it appears Nicole has already identified this. > > > > I'll look into this! > > What about this point? I had not considered that a bug. If you do let me know and I'll change that behavior. -- You are receiving this mail because: You are watching all bug changes.

1 0