June 2016 - Koha-bugs - lists.koha-community.org

[Bug 14645] Koha::RecordProcessor should deal with Koha::MetadataRecord objects
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '16

06 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14645 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #4 from David Cook <dcook(a)prosentient.com.au> --- I wonder too if we could implement a Koha::Filter::XML::XSLT class. Unfortunately, since XML::LibXSLT returns a new XML::LibXML::Document object and Koha::RecordProcessor returns the original object, we'd need to do something like this to make that work: sub filter { my $self = shift; my $record = shift; my $xslt = XML::LibXSLT->new(); my $style_doc = XML::LibXML->load_xml(location => "path_to_xslt.xsl"); my $stylesheet = $xslt->parse_stylesheet($style_doc); my $filtered_record = $stylesheet->transform($record); my $new_root = $filtered_record->documentElement; my $newest = $new_root->cloneNode(1); $record->removeChildNodes(); $record->setDocumentElement($newest); return $record; } I imagine cloneNode isn't very efficient, although I don't know the specifics. I thought about implementing this class for my work on bug 10662, but I think I'll just write my own few lines for now... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14828] Move the item types related code to Koha::ItemTypes
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '16

06 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan(a)catalyst.net.nz --- Comment #33 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- I'm having problems with t/db_dependent/HoldsQueue.t, line 64. $itemtype used to be a string, now is a record. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10459] borrowers should have a timestamp
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '16

06 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 --- Comment #58 from M. Tompsett <mtompset(a)hotmail.com> --- Hence the third patch which makes it updated_on, David Cook. Still ready for QA, like comment #56 says. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7170] Remove use of XML::Simple
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '16

06 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #18 from David Cook <dcook(a)prosentient.com.au> --- I'd love to see XML::Simple disappear... As per the synopsis for XML::Simple itself says, "You really don't want to use this module in new code." http://search.cpan.org/~grantm/XML-Simple-2.22/lib/XML/Simple.pm#SYNOPSIS -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1289] Bulk/global edit for MARC frameworks
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '16

06 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1289 --- Comment #4 from David Cook <dcook(a)prosentient.com.au> --- I used to like the idea of modifying the MARC frameworks, but in my experience people tend to do more harm than good when modifying them... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug.

1 0

[Bug 10459] borrowers should have a timestamp
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '16

06 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #57 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Kyle M Hall from comment #31) > I really dislike having a field name being the same as a mysql data type. I > think it introduces ambiguity. Would you or anyone else be opposed to naming > it "updated_on"? In addition to what Kyle has said, it appears that our own coding guidelines say that we shouldn't be using SQL92 keywords like "timestamp" as column names: https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL2:_SQL92_keywords -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12648] Link patrons to an order
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '16

05 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole(a)bywatersolutions.com --- Comment #80 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Christopher Brannon from comment #79) > I'm not finding any reference to this feature in the manual. Is it there? CCing Nicole. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 04 Jun '16

04 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14897] Header name mismatch in ./modules/catalogue/detail.tt
by bugzilla-daemon＠bugs.koha-community.org 04 Jun '16

04 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14897 Joy Nelson <joy(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52053|0 |1 is obsolete| | --- Comment #4 from Joy Nelson <joy(a)bywatersolutions.com> --- Created attachment 52056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52056&action=ed… Bug 14897 - Header name mismatch in ./modules/catalogue/detail.tt We changed the detail.tt file for staff interface from Publication details to "Serial enumeration / chronology" to match the cataloguing editor. Signed-off-by: Joy Nelson <joy(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14897] Header name mismatch in ./modules/catalogue/detail.tt
by bugzilla-daemon＠bugs.koha-community.org 04 Jun '16

04 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14897 Joy Nelson <joy(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0