June 2016 - Koha-bugs - lists.koha-community.org

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 03 Jun '16

03 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #9 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 52018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52018&action=ed… Bug 14048: Add syspref and atomic update This patch introduces the changes to the sysprefs and the atomic update that creates the new table. It picks the syspref value for RefundLostItemFeeOnReturn and uses it to create a default (branchcode='*') rule on the new table. Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 03 Jun '16

03 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #8 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 52017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52017&action=ed… Bug 14048: Unit tests This patch introduces unit tests for the feature. To test: - Have all patches from this bug applied - Run: $ prove -v t/db_dependent/RefundLostItemFeeRule.t => SUCCESS: All tests pass! Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 03 Jun '16

03 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 --- Comment #7 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 52016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52016&action=ed… Bug 14048: Add RefundLostItemFeeRule table and classes This patch introduces new classes for handling refund lost item fee rules. It introduces a new table for storing this rules. It is designed so it is possible to define a global rule, and then branch-specific ones. The specific is prefered if available. This behaviour is fully tested by unit tests introduced by the following patches. This cannot be tested on its own. Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6624] Allow Koha to use the new read API from OpenLibrary
by bugzilla-daemon＠bugs.koha-community.org 03 Jun '16

03 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6624 Mirko Tietgen <mirko(a)abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16649 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 03 Jun '16

03 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 03 Jun '16

03 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50174|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52015&action=ed… Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType This unnecessary complicated subroutine returned an arrayref and an hashref of the patron categories available for the logged in user, for a given category_type, ordered by categorycode. This can now be done with the search_limited method. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. They should be ordered as before this patch, by categorycode. - Add/edit a patron, change his/her patron category value. - On the 3 following reports: reports/bor_issues_top.pl reports/borrowers_out.pl reports/cat_issues_top.pl The display for these 3 reports are different than the 2 from the first patch (borrowers_stats.pl issues_avg_stats.pl): they are ordered by categorycode and the ones limited to other libraries are not displayed (should certainly be fixed). Note that the big part of this patch has already been tested before (update child related: CATCODE_MULTI). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 03 Jun '16

03 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50173|0 |1 is obsolete| | --- Comment #38 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52014&action=ed… Bug 15407: Koha::Patron::Categories - replace GetBorrowercategoryList C4::Members::GetBorrowercategoryList returned all the patron categories, ordered by description. This can be done using the search method of the Koha::Patron::Categories module. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. They should be ordered as before this patch, by description. - On the "patron attribute types" admin page (admin/patron-attr-types.pl). - On the "Batch patron deletion/anonymization" (tools/cleanborrowers.pl), the dropdown list should be filled correctly. - On the import patron tool - On the following report: reports/reserves_stats.pl Confirm that the patron categories are displayed and that the report still works as before. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron::Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 03 Jun '16

03 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50172|0 |1 is obsolete| | --- Comment #37 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52013&action=ed… Bug 15407: Koha::Patron::Categories - replace GetBorrowercategory The purpose of C4::Members::GetBorrowercategory was to return the patron category for a given categorycode. This can be done easily with the Koha::Patron::Categories->find method. Test plan: - Same prerequisite as before - Edit a guarantor and confirm the information will be updated for his/her guarantee(s). - Update a child to adult patron (Note: Should not we hide the patron categories limited to others libraries? If yes, it must be done on another bug report). There is a special behavior if there is only 1 adult category, the user does not need to select a category. So the same as before with only 1 adult patron category. - Import a patron with a category_code which does not exist. You should be warned. - Modify some patron using the batch patron modification tool. The patron category descriptions should correctly be displayed. Note that the overduerules page has already been tested in a previous patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7677] New area in subscriptions and new function when receiving
by bugzilla-daemon＠bugs.koha-community.org 03 Jun '16

03 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #87 from Matthias Meusburger <matthias.meusburger(a)biblibre.com> --- Created attachment 52010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52010&action=ed… Bug 7677 [QA Followup] - Replace GetItemnumberFromSerialId with use of Koha::Serial::Item(s) - use _type instead of type (see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15446 ) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15087] hardduedate should not be inserted as 0000-00-00 but NULL
by bugzilla-daemon＠bugs.koha-community.org 03 Jun '16

03 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris(a)bigballofwax.co.nz Attachment #52003|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0