June 2016 - Koha-bugs - lists.koha-community.org

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '16

23 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nicole C. Engard <nengard(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52665|0 |1 is obsolete| | --- Comment #56 from Nicole C. Engard <nengard(a)gmail.com> --- Created attachment 52754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52754&action=ed… Bug 14048 [QA Followup] - Delete only the removed system preference Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jason Robb <jrobb(a)sekls.org> Signed-off-by: Jennifer Schmidt <jschmidt(a)switchinc.org> Signed-off-by: Margaret Thrasher <p.thrasher(a)dover.nh.gov> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '16

23 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nicole C. Engard <nengard(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52664|0 |1 is obsolete| | --- Comment #55 from Nicole C. Engard <nengard(a)gmail.com> --- Created attachment 52753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52753&action=ed… Bug 14048: Add syspref and atomic update This patch introduces the changes to the sysprefs and the atomic update that creates the new table. It picks the syspref value for RefundLostItemFeeOnReturn and uses it to create a default (branchcode='*') rule on the new table. Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jason Robb <jrobb(a)sekls.org> Signed-off-by: Jennifer Schmidt <jschmidt(a)switchinc.org> Signed-off-by: Margaret Thrasher <p.thrasher(a)dover.nh.gov> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '16

23 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nicole C. Engard <nengard(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52663|0 |1 is obsolete| | --- Comment #54 from Nicole C. Engard <nengard(a)gmail.com> --- Created attachment 52752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52752&action=ed… Bug 14048: [QA Followup] Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jason Robb <jrobb(a)sekls.org> Signed-off-by: Jennifer Schmidt <jschmidt(a)switchinc.org> Signed-off-by: Margaret Thrasher <p.thrasher(a)dover.nh.gov> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '16

23 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nicole C. Engard <nengard(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52662|0 |1 is obsolete| | --- Comment #53 from Nicole C. Engard <nengard(a)gmail.com> --- Created attachment 52751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52751&action=ed… Bug 14048: Hook new rules into C4::Circulation This patch makes AddIssue and AddReturn use the new implementation The behaviour should respect the specification. Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jason Robb <jrobb(a)sekls.org> Signed-off-by: Jennifer Schmidt <jschmidt(a)switchinc.org> Signed-off-by: Margaret Thrasher <p.thrasher(a)dover.nh.gov> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '16

23 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nicole C. Engard <nengard(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52661|0 |1 is obsolete| | --- Comment #52 from Nicole C. Engard <nengard(a)gmail.com> --- Created attachment 52750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52750&action=ed… Bug 14048: Add a refund rules setting form in smart-rules This patch introduces the CRUD UI for managing the refund lost item fee rules on the general 'Circulation and fines rules' page. Verify that rules can be added and changed. Rules are correctly associated to the chosen branch (or the general default rule). To test: - Apply the patch - Open smart-rules.pl => SUCCESS: The text and refund rules section correctly refers to default global rules. The policy can be set to Yes and No, and works as expected. - Pick a specific branch => SUCCESS: The rule refers to the specific branch => SUCCESS: It detects the default rule is picked => SUCCESS: On changing the rules values are correctly retrieved if entering again to the page. => SUCCESS: The 'Use default' text is suffixed with the correct value set by the user in the 'All libraries' scenario. => Sign off :-D Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jason Robb <jrobb(a)sekls.org> Signed-off-by: Jennifer Schmidt <jschmidt(a)switchinc.org> Signed-off-by: Margaret Thrasher <p.thrasher(a)dover.nh.gov> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '16

23 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nicole C. Engard <nengard(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52660|0 |1 is obsolete| | --- Comment #51 from Nicole C. Engard <nengard(a)gmail.com> --- Created attachment 52749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52749&action=ed… Bug 14048: Unit tests This patch introduces unit tests for the feature. To test: - Have all patches from this bug applied - Run: $ prove -v t/db_dependent/RefundLostItemFeeRule.t => SUCCESS: All tests pass! Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jason Robb <jrobb(a)sekls.org> Signed-off-by: Jennifer Schmidt <jschmidt(a)switchinc.org> Signed-off-by: Margaret Thrasher <p.thrasher(a)dover.nh.gov> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '16

23 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048 Nicole C. Engard <nengard(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52659|0 |1 is obsolete| | --- Comment #50 from Nicole C. Engard <nengard(a)gmail.com> --- Created attachment 52748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52748&action=ed… Bug 14048: Add RefundLostItemFeeRule table and classes This patch introduces new classes for handling refund lost item fee rules. It introduces a new table for storing this rules. It is designed so it is possible to define a global rule, and then branch-specific ones. The specific is prefered if available. This behaviour is fully tested by unit tests introduced by the following patches. This cannot be tested on its own. Sponsored-by: DoverNet Sponsored-by: South-East Kansas Library System Sponsored-by: SWITCH Library Consortium Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Jason Robb <jrobb(a)sekls.org> Signed-off-by: Jennifer Schmidt <jschmidt(a)switchinc.org> Signed-off-by: Margaret Thrasher <p.thrasher(a)dover.nh.gov> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7441] search results showing wrong branch?
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '16

23 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52746|0 |1 is obsolete| | --- Comment #73 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 52747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52747&action=ed… Bug 7441 - search results showing wrong branch? When you search in the OPAC it shows you the HOME branch on the location in XSLT, but if you click through to the detail page it shows you the CURRENT BRANCH in the holdings table which is very confusing to patrons. I don't know what's the right solution - home or holding branch, but they should be the same in both places for the patron's sake. If you do the same search in the staff client you see the right branch info on the search results and on the detail page. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Search the catalog, you search should include results with items that have different home and holding libraries. 4) The results should look the same as before the patch 5) Change the system preference OPACResultsLibrary to "current location" 6) Refresh your page of search results 7) The results show now show the holding library instead of the home library Signed-off-by: Barbara Walters <bwalters(a)ncrl.org> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7441] search results showing wrong branch?
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '16

23 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Nicole C. Engard <nengard(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51963|0 |1 is obsolete| | --- Comment #72 from Nicole C. Engard <nengard(a)gmail.com> --- Created attachment 52746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52746&action=ed… Bug 7441 - search results showing wrong branch? When you search in the OPAC it shows you the HOME branch on the location in XSLT, but if you click through to the detail page it shows you the CURRENT BRANCH in the holdings table which is very confusing to patrons. I don't know what's the right solution - home or holding branch, but they should be the same in both places for the patron's sake. If you do the same search in the staff client you see the right branch info on the search results and on the detail page. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Search the catalog, you search should include results with items that have different home and holding libraries. 4) The results should look the same as before the patch 5) Change the system preference OPACResultsLibrary to "current location" 6) Refresh your page of search results 7) The results show now show the holding library instead of the home library Signed-off-by: Barbara Walters <bwalters(a)ncrl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7441] search results showing wrong branch?
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '16

23 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Nicole C. Engard <nengard(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0