June 2016 - Koha-bugs - lists.koha-community.org

[Bug 14583] Subfields not deleted when automatically merging authorities.
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '16

23 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14583 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16802 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15485] Allow choosing different XSLTs for lists
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '16

23 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15485 Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52741|0 |1 is obsolete| | --- Comment #17 from Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> --- Created attachment 52743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52743&action=ed… [SIGNED-OFF]Bug 15485: (QA followup) Simplify logic and use *ResultsDisplay value during upgrade This patch makes the new sysprefs work as the previously defined. Instead of falling back to what *ResultsDisplay is set, it now has its own 'default' (that still defaults to the *Results*.xslt). The default values are set to 'default' as the rest of XSLT-related sysprefs, and the upgrade picks whatever is set in OPACXSLTResultsDisplay and XSLTResultsDisplay so current behaviour is preserved. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> New XSLTs for Lists work as advertised -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15485] Allow choosing different XSLTs for lists
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '16

23 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15485 Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52740|0 |1 is obsolete| | --- Comment #16 from Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> --- Created attachment 52742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52742&action=ed… [SIGNED-OFF]Bug 15485: (QA followup) Fix behaviour and default values Jonathan noticed the current behaviour is that the lists rendering falls back to the XSLTResults, and if not defined (i.e. != 'default' and != some_path) it falls back to a legacy display (non-XSLT). The patchset changed this behaviour because 'default' is not a valid value for the lists. So it should fallback to the current behaivour (i.e. Results XSLT configuration) if not defined. This patch fixes this by adding || C4::Context->preference('XSLTResultsDisplay') (and the OPAC counterpart). It also fixes minor glitches on the update message (oops) and bad default value in sysprefs.sql for 'XSLTListsDisplay'. Thanks Jonathan! Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14903] Remove C4::Dates from circ/circulation.pl
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '16

23 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16780 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16780 [Bug 16780] Specify due date always sets time as AM when using 12 hour time format -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15485] Allow choosing different XSLTs for lists
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '16

23 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15485 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52701|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52741&action=ed… Bug 15485: (QA followup) Simplify logic and use *ResultsDisplay value during upgrade This patch makes the new sysprefs work as the previously defined. Instead of falling back to what *ResultsDisplay is set, it now has its own 'default' (that still defaults to the *Results*.xslt). The default values are set to 'default' as the rest of XSLT-related sysprefs, and the upgrade picks whatever is set in OPACXSLTResultsDisplay and XSLTResultsDisplay so current behaviour is preserved. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15485] Allow choosing different XSLTs for lists
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '16

23 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15485 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52398|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52740&action=ed… Bug 15485: (QA followup) Fix behaviour and default values Jonathan noticed the current behaviour is that the lists rendering falls back to the XSLTResults, and if not defined (i.e. != 'default' and != some_path) it falls back to a legacy display (non-XSLT). The patchset changed this behaviour because 'default' is not a valid value for the lists. So it should fallback to the current behaivour (i.e. Results XSLT configuration) if not defined. This patch fixes this by adding || C4::Context->preference('XSLTResultsDisplay') (and the OPAC counterpart). It also fixes minor glitches on the update message (oops) and bad default value in sysprefs.sql for 'XSLTListsDisplay'. Thanks Jonathan! Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15485] Allow choosing different XSLTs for lists
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '16

23 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15485 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52321|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52739&action=ed… Bug 15485: Use lists-specific XSLT sysprefs This patch makes the shelves.pl (staff) and opac-shelves.pl scripts use the new sysprefs for specifying custom XSLTs for lists display. XSLT.pm is patched so it defaults to the corresponding *Results.xsl files if none is specified. To test: - Create a list - Open the list in the staff interface - On a new tab, open the list in the OPAC. - Apply this patches === default behaviour - Open the list (both opac and staff) on new tabs => SUCCESS: They look exactly the same (hint: the syspref is set to '' so it should fallback to using the one we were using. === using the new functionality - Create custom XSLTs for lists, for example: $ cd /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/xslt $ cp MARC21slim2OPACResults.xsl MARC21slim2OPACLists.xsl - Edit your sysprefs, setting OPACXSLTListsDisplay to: /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/{langcode}/xslt/MARC21slim2OPACLists.xsl - Reload the OPAC list view => SUCCESS: Looks exactly as before - Make some minor tweak (for example in line 423 replace <xsl:text> </xsl:text> for <xsl:text> BLAH </xsl:text> - Reload the list => SUCCESS: BLAH shows in several places on the title. - Repeat for the staff interface - Sign off :-D So we can now set custom XSLTs for lists. Sponsored-by: Carnegie Stout Library Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Deb Stephenson <DStephen(a)dubuque.lib.ia.us> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15485] Allow choosing different XSLTs for lists
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '16

23 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15485 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52320|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 52738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52738&action=ed… Bug 15485: Introduce new sysprefs for lists XSLTs This patch introduces two new sysprefs, allowing the users to set custom XSLTs for lists display. This is done almost the usual way. If none is specified (value='') it defaults to the current behaviour: using the *Results.xsl file for the corresponding interface. Sponsored-by: Carnegie Stout Library Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Deb Stephenson <DStephen(a)dubuque.lib.ia.us> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15485] Allow choosing different XSLTs for lists
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '16

23 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15485 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14790] Link to OPAC view from within subscriptions, search and item editor
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '16

23 Jun '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14790 --- Comment #13 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #11) > In catalogue/detail.pl, we already have a "OPAC view" link (only for > non-XSLT views (?)). It tests if OPACBaseURL exists. It may be useful to add > this test in your patches: a library could use another OPAC and do not want > to have this link displayed. That's a good idea! Here's a followup to add that! -- You are receiving this mail because: You are watching all bug changes.

1 0