July 2016 - Koha-bugs - lists.koha-community.org

[Bug 9701] Configure default indicator
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52171|0 |1 is obsolete| | Attachment #52172|0 |1 is obsolete| | Attachment #52173|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 53403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53403&action=ed… Bug 9701 - Configure default indicator This patch adds the possibility to define default indicators in the MARC frameworks. It adds 2 columns in the marc_tag_structure table in the database in order to accomplish this. All files that reference this table have also been updated to reflect these added fields. Test: Add or edit a MARC framework. In the Field list should be 2 extra columns. It should be possible to add default indicators (1 character) in these fields. Nothing else should have changed in the meantime. The default indicator values are not yet visible in the cataloguing module. The default values are also loaded in the cataloguing form. Test: Define default values in some MARC framework. Go to cataloguing and create a new record using this framework. Verify that the defined defaults are visible when set. Verify the default is empty (as before) if no default was set. Verify that if the default is changed, the record is saved with the manually changed value. Verify that upon changing such a new record, the manually set indicator value is used and not the default one from the framework. Signed-off-by: Eugene Jose Espinoza <eugenegf(a)yahoo.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicator
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Joachim, I have squashed your 3 original patches to avoid conflicts caused by adding and removing the change to updatedatabase.pl in the first 2 patches. Also fixes the problem that only the last patch was signed off by the sandbox script. I also added a follow-up fixing tabs pointed out by the QA script - please keep in mind that we are using 4 spaces instead of tabs! The patches work really nicely. We are close to getting this through QA, but please add tests for your change to GetMarcStructure. For changes in the core modules, unit tests are mandatory. Please let us know if you need any help with that! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7677] New area in subscriptions and new function when receiving
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #88 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I've run the database update and created the schema files, but sadly, I am still seeing an error: DBIx::Class::ResultSource::unique_constraint_columns(): Unknown unique constraint primary on 'serialitems' at /home/katrin/kohaclone/Koha/Objects.pm line 83 It happens when I try to receive 2 serial issues at once. To reproduce this: - Search for a subscription - Go to it's serial collection page - Create a next issue - Try to receive both the now late issue and the expected one at once -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14668] Show serial enumeration in the patron's opac checkout summary
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14668 --- Comment #9 from Charles Farmer <charles.farmer(a)inlibro.com> --- There's a lot that's already been done from what I see; bugs #13430 and #13611 have already taken care of /svc, returns.pl and opac-user.pl. Everything that François wrote in his first post was corrected by somebody else. Something can still be done inside the RELATIVES loop of opac-user.pl, and the 'Check Out' section of circulation.pl. I'll submit a patch prompty to fix those. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9259] Delete marc batches from staged marc management
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx(a)gmail.com --- Comment #17 from Héctor Eduardo Castro Avalos <hector.hecaxmmx(a)gmail.com> --- +1 Aleisha this is very, very great -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16926] New: Display acquisitions notes in more areas
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16926 Bug ID: 16926 Summary: Display acquisitions notes in more areas Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org It would be nice to see order_internal notes on the invoice details page and possibly some other area as well aqbasket.order_internalnote and order_vendornote would be helpful to see in basket searches and maybe spent.pl as well -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14876] Show number of holds per record on the search results
by bugzilla-daemon＠bugs.koha-community.org 14 Jul '16

14 Jul '16

1 0

[Bug 14876] Show number of holds per record on the search results
by bugzilla-daemon＠bugs.koha-community.org 14 Jul '16

14 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 --- Comment #2 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 53402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53402&action=ed… Bug 14876 - Show number of holds on the staff side next to 'holds' link This patch adds a a Holds plugin for the templates to count existing holds on a record. We then use this in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt to display the current number of holds on a record. To test: 1 - Search in staff 2 - Note holds link has no extra information 3 - Apply patch 4 - prove -v t/db_dependent/Template/Plugin/Holds.t 5 - Do search in staff that returns records with some holds (i.e. place some holds) 6 - Note the number of holds now displays next to the text of the link: Holds (#) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14876] Show number of holds per record on the search results
by bugzilla-daemon＠bugs.koha-community.org 14 Jul '16

14 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15759] New: Allow Koha::Object derived objects to be used as hashrefs
by bugzilla-daemon＠bugs.koha-community.org 14 Jul '16

14 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15759 Bug ID: 15759 Summary: Allow Koha::Object derived objects to be used as hashrefs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org On occasion, bugs in Koha have been revealed to be a mis-use of Koha::Object. This seems to be due to our long standing use of hashrefs for data in Koha. For instance, a developer may accidentally write: my $borrowernumber = $borrower->{borrowernumber}; instead of my $borrowernumber = $borrower->borrowernumber; Since our object is a blessed hashref, this does not cause an error. Instead, we just access that key of the hashref, which is almost certainly undefined. With some extra code in Koha/Object.pm, we can allow hashref-like use of our Objects, which will not only prevent these errors, but allow drop-in use of Koha::Objects where we currently use hashrefs! -- You are receiving this mail because: You are watching all bug changes.

1 13