July 2016 - Koha-bugs - lists.koha-community.org

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #52 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #46) > perl -c reports/issues_stats.pl > Global symbol "@patron_categories" requires explicit package name at > reports/issues_stats.pl line 155. > Global symbol "@patron_categories" requires explicit package name at > reports/issues_stats.pl line 326. > Global symbol "@patron_categories" requires explicit package name at > reports/issues_stats.pl line 400. > Bareword "GetBorrowercategoryList" not allowed while "strict subs" in use at > reports/issues_stats.pl line 79 Hi Kyle, I do not recreate it, but I got a conflict on issues_stats.pl when applying the patches. I have rebased them against master. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52036|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53423&action=ed… Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType This unnecessary complicated subroutine returned an arrayref and an hashref of the patron categories available for the logged in user, for a given category_type, ordered by categorycode. This can now be done with the search_limited method. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. They should be ordered as before this patch, by categorycode. - Add/edit a patron, change his/her patron category value. - On the 3 following reports: reports/bor_issues_top.pl reports/borrowers_out.pl reports/cat_issues_top.pl The display for these 3 reports are different than the 2 from the first patch (borrowers_stats.pl issues_avg_stats.pl): they are ordered by categorycode and the ones limited to other libraries are not displayed (should certainly be fixed). Note that the big part of this patch has already been tested before (update child related: CATCODE_MULTI). Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52035|0 |1 is obsolete| | --- Comment #50 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53422&action=ed… Bug 15407: Koha::Patron::Categories - replace GetBorrowercategoryList C4::Members::GetBorrowercategoryList returned all the patron categories, ordered by description. This can be done using the search method of the Koha::Patron::Categories module. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. They should be ordered as before this patch, by description. - On the "patron attribute types" admin page (admin/patron-attr-types.pl). - On the "Batch patron deletion/anonymization" (tools/cleanborrowers.pl), the dropdown list should be filled correctly. - On the import patron tool - On the following report: reports/reserves_stats.pl Confirm that the patron categories are displayed and that the report still works as before. Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52034|0 |1 is obsolete| | --- Comment #49 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53421&action=ed… Bug 15407: Koha::Patron::Categories - replace GetBorrowercategory The purpose of C4::Members::GetBorrowercategory was to return the patron category for a given categorycode. This can be done easily with the Koha::Patron::Categories->find method. Test plan: - Same prerequisite as before - Edit a guarantor and confirm the information will be updated for his/her guarantee(s). - Update a child to adult patron (Note: Should not we hide the patron categories limited to others libraries? If yes, it must be done on another bug report). There is a special behavior if there is only 1 adult category, the user does not need to select a category. So the same as before with only 1 adult patron category. - Import a patron with a category_code which does not exist. You should be warned. - Modify some patron using the batch patron modification tool. The patron category descriptions should correctly be displayed. Note that the overduerules page has already been tested in a previous patch. Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52033|0 |1 is obsolete| | --- Comment #48 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53420&action=ed… Bug 15407: Koha::Patron::Categories - replace C4::Category->all The C4::Category module contained only 1 method to return the patron categories available for the logged in user. The new method Koha::Patron::Categories->search_limited does exactly the same thing (see tests) and must be used in place of it. Test plan: - Same prerequisite as before For the following pages, you should not see patron categories limited to other libraries. - On the 'Item circulation alerts' admin page (admin/item_circulation_alerts.pl), modify the settings for check-in and checkout (NOTE: Should not we display all patron categories on this page? If yes, it must be done in another bug report to ease backporting it). - Search for patrons in the admin (budget) and acquisition (order) module. - On the patron home page (search form in the header) Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52032|0 |1 is obsolete| | --- Comment #47 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 53419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53419&action=ed… Bug 15407: Koha::Patron::Categories - remove sql queries in some pl and pm This patch replaces sql queries done in some pl script and in C4::Reports::Guided. Since we have now a Koha::Patron::Categories module, we should use it where it is possible. Test plan: - Prerequisite: Be sure you have several patron categories created, with different option enabled, and limit some to certain libraries. - On the 'Circulation and fine rules' admin page (admin/smart-rules.pl), all the patron categories should be displayed (even the ones limited to another library), ordered by description. Try to add/update existing rules. - On the overdue rules page (tools/overduerules.pl), all the patron categories with overduenoticerequired set should be displayed. Try to add/update existing rules. - On the following reports: reports/borrowers_stats.pl reports/issues_avg_stats.pl The patron categories should be displayed. Note that there is an inconsistency with these 2 reports: the patron categories limited to other libraries are displayed on them, when they are not on the other reports. This should certainly be fixed (on another bug report). Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15541] Prevent normalization during matching/import process
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com --- Comment #22 from Kyle M Hall <kyle(a)bywatersolutions.com> --- This bug is marked as signed off, but the main patch has no sign-off. Is the status incorrect or did someone miss adding a sign-off? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12461] Add patron clubs feature
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #38 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I am sorry, there are too many conflicts for me to feel comfortable trying to fix: CONFLICT (content): Merge conflict in opac/opac-user.pl Auto-merging members/moremember.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging circ/circulation.pl CONFLICT (content): Merge conflict in circ/circulation.pl Auto-merging Koha/Schema/Result/Borrower.pm Auto-merging Koha/Patron.pm CONFLICT (content): Merge conflict in Koha/Patron.pm Please take a look! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 15 Jul '16

15 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hm, I have looked at the description and the code of this, but I have concerns about the use of the expirationdate column in the reserves table. I think with this patch, it will be used for 2 different things: 1) The date set by the patron when placing the hold "I don't need this after..." 2) The date a waiting hold expires It looks like when setting the hold waiting, this will overwrite the expiration date set by the patron. Is this what we want? My feeling is no. I think we shouldn't change the date the user set to avoid confusion (see also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12204#c10) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0