July 2016 - Koha-bugs - lists.koha-community.org

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '16

13 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #75 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 53363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53363&action=ed… Bug 15006 Drop raw connection if login fails raw_connection was not behaving correctly if an invalid string was passed or a login failed. It was not checking that the login succeeded ( it checked that account existed not that it contained data and it existed even if login failed) and so failed logins instead of aborting immediately fell through into the sip_protocol_loop, forcing that to timeout invalid connections. It now checks that account has id set and returns if not. The timeout alarm is now set on the while loop, in normal running this should not be triggered as the socket is opened and the first data should be a login message and the while loop should only iterate once, but lets not go into an infinite loop due to unforeseen circumstances. I have reindented the routine as the flow was not clear (the while was not indented at all. Also if using Net::Server::PreFork when a new connection comes in you may be handed the the successful login parameters from a preceding call. Because of this you could successfully transmit transactions and Koha would carry them out without having received a valid login ( and possibly with the wrong account details!) We now delete any existing account for new connections. NB: This patch requires that the patch for bug 13807 has been applied Signed-off-by: Srdjan <srdjan(a)catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8352] Add automatic printing of 'hold to pull' notices
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '16

13 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Fiona Borthwick <fiona.borthwick(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '16

13 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Fiona Borthwick <fiona.borthwick(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '16

13 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #74 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Srdjan Jankovic from comment #73) > I still think that > > $server->get_timeout({}) > $self->get_timeout({}) > > beats > > C4::SIP::Sip::get_timeout($server, {}) > C4::SIP::Sip::get_timeout($self, {}) Thx Srdjan for testing. Of course, you are right. Only problem is I need to mock some SIPServer stuff to still have a working unit test. Patch forthcoming. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '16

13 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53260|0 |1 is obsolete| | --- Comment #96 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 53362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53362&action=ed… Bug 10662 - Icarus job server and Koha UI for it NOTE: You cannot use koha-gitify to test changes to koha-conf.xml NOTE: Check koha_perl_deps.pl; you may need to install POE.pm <To be updated> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '16

13 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53259|0 |1 is obsolete| | --- Comment #95 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 53361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53361&action=ed… Bug 10662 - Create svc/import_oai API -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3311] Statistical reports should error if row and column aren' t selected
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '16

13 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 --- Comment #16 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Jonathan Druart from comment #15) > (In reply to M. Tompsett from comment #11) > > (In reply to Jonathan Druart from comment #10) > > > 2/ How can be useful the changes done in the perl script? > > > > The value of $do_it is wrong without those changes, and causes nasty > > crashes. That is why I provided test coverage. > > How can I get the crash with the JS alert blocking the form submission? Hard coded URLs. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '16

13 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #73 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- I still think that $server->get_timeout({}) $self->get_timeout({}) beats C4::SIP::Sip::get_timeout($server, {}) C4::SIP::Sip::get_timeout($self, {}) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '16

13 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53312|0 |1 is obsolete| | --- Comment #72 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 53360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53360&action=ed… [SIGNED-OFF] Bug 15006: [QA Follow-up] Satisfy qa tools with one tab less Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Srdjan <srdjan(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '16

13 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0