July 2016 - Koha-bugs - lists.koha-community.org

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '16

13 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53311|0 |1 is obsolete| | --- Comment #71 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 53359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53359&action=ed… [SIGNED-OFF] Bug 15006 Correct indentation of EXPORTs in Sip.pm Removed tabs and used spaces consistently Used 'use base' to remove unnecessary BEGIN sub and explicit setting of ISA at application level Signed-off-by: Srdjan <srdjan(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '16

13 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53310|0 |1 is obsolete| | --- Comment #70 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 53358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53358&action=ed… [SIGNED-OFF] Bug 15006: Centralize timeout logic and allow zero client timeout Moving timeout logic to one routine in Sip.pm (with unit test). This further implements two suggestions from Kyle and Larry: [1] You could use a client_timeout of 0 to specify no timeout at all. [2] Have the client_timeout default to the timeout if not defined. Test plan: [1] Run t/SIP_Sip.t [2] Test login timeout for raw and telnet. [3] Check ACS status message for timeout value. Should match policy timeout from institution. [4] Test client timeout (zero and non-zero). [5] Remove client timeout. Test fallback to service. [6] Remove service timeout too. Test fallback to 30 at login. Signed-off-by: Srdjan <srdjan(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '16

13 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53309|0 |1 is obsolete| | --- Comment #69 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 53357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53357&action=ed… [SIGNED-OFF] Bug 15006: Introduce client_timeout in SIPconfig.xml Most selfchecks have persistent connections and send a periodic status request at intervals (approx every 5mins appears the norm) The timeout was dropping connections by default every 30secs which for the client appears as a very flakey network. This patch adds a separate parameter client_timeout that can be used if you do want to force a disconnect if the client sends no requests for a period. The sample config sets it to 600, but you can also define a 0 value meaning no timeout. If the parameter is not defined, it will fallback to service timeout. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Restored this patch from Colin in order to separate it from the get_timeout patch. Adjusted the commit message slightly. The original value of 600 from Colin's earlier patch may give less discussion than setting to 0 (no timeout) in a later proposal. Signed-off-by: Srdjan <srdjan(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '16

13 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53133|0 |1 is obsolete| | --- Comment #68 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 53356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53356&action=ed… [SIGNED-OFF] Bug 15006 Remove tabs from sip_protocol_loop Remove the tabs causing inconsistent indentation of sip_protocol_loop and replace with spaces Reimplements the renaining parts of Marcel de Rooy's original QA patch No logic changes in this patch - layout only Signed-off-by: Srdjan <srdjan(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '16

13 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53132|0 |1 is obsolete| | --- Comment #67 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 53355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53355&action=ed… [SIGNED-OFF] Bug 15006 Drop raw connection if login fails raw_connection was not behaving correctly if an invalid string was passed or a login failed. It was not checking that the login succeeded ( it checked that account existed not that it contained data and it existed even if login failed) and so failed logins instead of aborting immediately fell through into the sip_protocol_loop, forcing that to timeout invalid connections. It now checks that account has id set and returns if not. The timeout alarm is now set on the while loop, in normal running this should not be triggered as the socket is opened and the first data should be a login message and the while loop should only iterate once, but lets not go into an infinite loop due to unforeseen circumstances. I have reindented the routine as the flow was not clear (the while was not indented at all. Also if using Net::Server::PreFork when a new connection comes in you may be handed the the successful login parameters from a preceding call. Because of this you could successfully transmit transactions and Koha would carry them out without having received a valid login ( and possibly with the wrong account details!) We now delete any existing account for new connections. NB: This patch requires that the patch for bug 13807 has been applied Signed-off-by: Srdjan <srdjan(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14803] Rental and fine fees are not updating on circulation screen
by bugzilla-daemon＠bugs.koha-community.org 13 Jul '16

13 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #11 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Yes. And run t/db_dependent/Circulation/issue.t, first two patches is the test fix. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7595] Add branchcode to accountlines
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '16

12 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #44 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I have done some first tests - not so bad so far, but I worry about paying via SIP. Can you please verify that this works still as well? Which branch should be logged? The branch of the SIP user from the config file? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7595] Add branchcode to accountlines
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '16

12 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #43 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- There are no sign-off lines on these patches - Kyle & Marc, can you please check? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14138] Patroncard: Warn user if PDF creation fails
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '16

12 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53307|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 53352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53352&action=ed… [PASSED QA] Bug 14138: Patroncard: Warn user if PDF creation fails Change patroncards/create-pdf.pl to redirect with an error message instead of writing an invalid pdf that does not open in pdf viewer. To test: - Apply patch - Test that pdf creator behaves as before (with valid batches and patron lists) - While testing, copy pdf link address from window with title 'Click the following link(s) to download...' - Open another staff client browser tab - Paste link to browser address field, change batch id rsp. patron list id to an invalid value and submit - The window should redirect to cgi-bin/koha/patroncards/create-pdf.pl and display an error message - Bonus test 1: Create an empty patron list and test patron card creation. You should get an error message as appropriate. - Bonus test 2: Use a link with params like the following: ...create-pdf.pl?borrower_number=61&template_id=2&layout_id=1&start_card=1 Verify that you can create a pdf with a valid borrower_number and that you get the error message with an invalid borrower number Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14138] Patroncard: Warn user if PDF creation fails
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '16

12 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0