July 2016 - Koha-bugs - lists.koha-community.org

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '16

12 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53134|0 |1 is obsolete| | Attachment #53135|0 |1 is obsolete| | --- Comment #61 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 53309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53309&action=ed… Bug 15006: Introduce client_timeout in SIPconfig.xml Most selfchecks have persistent connections and send a periodic status request at intervals (approx every 5mins appears the norm) The timeout was dropping connections by default every 30secs which for the client appears as a very flakey network. This patch adds a separate parameter client_timeout that can be used if you do want to force a disconnect if the client sends no requests for a period. The sample config sets it to 600, but you can also define a 0 value meaning no timeout. If the parameter is not defined, it will fallback to service timeout. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Restored this patch from Colin in order to separate it from the get_timeout patch. Adjusted the commit message slightly. The original value of 600 from Colin's earlier patch may give less discussion than setting to 0 (no timeout) in a later proposal. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15006] Need to distinguish client timeout from login timeout
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '16

12 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14919] Reserves history for patron
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '16

12 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Fiona Borthwick <fiona.borthwick(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3311] Statistical reports should error if row and column aren' t selected
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '16

12 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3311 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14138] Patroncard: Warn user if PDF creation fails
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '16

12 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53248|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 53307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53307&action=ed… [SIGNED-OFF] Bug 14138: Patroncard: Warn user if PDF creation fails Change patroncards/create-pdf.pl to redirect with an error message instead of writing an invalid pdf that does not open in pdf viewer. To test: - Apply patch - Test that pdf creator behaves as before (with valid batches and patron lists) - While testing, copy pdf link address from window with title 'Click the following link(s) to download...' - Open another staff client browser tab - Paste link to browser address field, change batch id rsp. patron list id to an invalid value and submit - The window should redirect to cgi-bin/koha/patroncards/create-pdf.pl and display an error message - Bonus test 1: Create an empty patron list and test patron card creation. You should get an error message as appropriate. - Bonus test 2: Use a link with params like the following: ...create-pdf.pl?borrower_number=61&template_id=2&layout_id=1&start_card=1 Verify that you can create a pdf with a valid borrower_number and that you get the error message with an invalid borrower number Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14138] Patroncard: Warn user if PDF creation fails
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '16

12 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '16

12 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #26 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to M. Tompsett from comment #23) > ::: misc/stage_file.pl > @@ +85,4 @@ > > > > my $dbh = C4::Context->dbh; > > $dbh->{AutoCommit} = 0; > > +process_batch($format, $input_file, $record_type, $match, $add_items, $batch_comment); > > Could we hashref this, please? We should not per se hashref to hashref imo. This is just a local sub of one script. But seeing the mix of parameters and file level vars, I decided to do it after all. Hopefully a slight improvement of the code. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '16

12 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #25 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 53306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53306&action=ed… Bug 10407: [QA Follow-up] Hashref process_batch params As requested by Mark Tompsett. Hope this guarantees a signoff now.. Note: For consistency four additional parameters were needed to no longer use file level vars in this subroutine. Test plan: Import a file with stage_file.pl. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Imported a marc file and a marcxml file with stage_file.pl. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14826] Resurrect account offsets table
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '16

12 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14827 |15894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14827 [Bug 14827] Merge various subroutines for paying fees into one https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894 [Bug 15894] Unify all account fine payment functions -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14827] Merge various subroutines for paying fees into one
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '16

12 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14827 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14826 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 [Bug 14826] Resurrect account offsets table -- You are receiving this mail because: You are watching all bug changes.

1 0