July 2016 - Koha-bugs - lists.koha-community.org

[Bug 10407] Allow MARCXML records to be imported via GUI
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53164|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported via GUI
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #20 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 53221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53221&action=ed… Bug 10407: Add two subtests to t/ImportBatch.t Creates a few simple tests for the two new subroutines in ImportBatch.pm. Test plan: Run t/ImportBatch.t. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported via GUI
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #19 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 53220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53220&action=ed… Bug 10407: Add marcxml import (follow-up) This patch makes the following changes: [1] Based on the groundwork of the former patch, add call to RecordsFromMARCXMLFile in stage-marc-import. Use format param. [2] Add format to the template. Use file extension to determine. If you use .xml or .marcxml as extension, MARCXML is selected. [3] In stage-marc-import.tt mark UTF-8 encoding as UTF-8 not as utf8. [4] BatchStageMarcRecords: do not call plugin if you have no records. [5] RecordsFromISO2709File: also return errors in an array. [6] In misc/stage_file.pl also use UTF-8. Handling of errors from [5]. Test plan: [1] Import an empty file as MARC or MARCXML (with Tools/Stage..import). [2] Import an non-empty file with invalid contents as MARC or MARCXML. [3] Export a few records with Tools/Export as MARC and MARCXML. [4] Import these two files. Check selected format versus file extension. [5] Import a MARCXML file with misc/stage_file.pl. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported via GUI
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #18 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 53219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53219&action=ed… Bug 10407: Resolve warnings from child process After the staging job finishes, the child tries to print results to STDOUT (which is closed). This creates warnings like: stage-marc-import.pl: binmode() on closed filehandle STDOUT at C4/Templates.pm line 120. stage-marc-import.pl: Filehandle STDOUT reopened as FH only for input at /usr/lib/perl5/Template/Provider.pm line 964. Resolving it is simple: the child should exit after marking the job as finished. Test plan: Import a marc file. Observe that you do no longer have such warnings. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported via GUI
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #17 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 53218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53218&action=ed… Bug 10407: Allow MARCXML records to be imported via GUI (groundwork) Patch from Olli, manual rebase by Marcel (July 7, 2016). Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Needs follow-up. Test plan in the third patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported via GUI
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16076] New: DBIx searches - performance issues
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16076 Bug ID: 16076 Summary: DBIx searches - performance issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: abl(a)biblos.pk.edu.pl QA Contact: testopia(a)bugs.koha-community.org While testing Bug 11998 and Bug 15341, I did some quick & dirty comparisons on DBI vs DBIx search performace - how long does it take to fetch from the database: one small system preference (marcflavour) and all system preferences (545 rows). Results: 1) one syspref, DBI: 130 microseconds ( using 'SELECT value FROM systempreferences WHERE variable = ? LIMIT 1') 2) one syspref, DBIx: 1.25 miliseconds ( Koha::Config::SysPrefs->find($var)->value() ) 3) all preferences, DBI: 1.8 miliseconds ( 'SELECT variable, value FROM systempreferences' ) 4) all preferences, DBIx: 21 miliseconds ( Koha::Config::SysPrefs->search()->unblessed(), like in Bug 15341) If I use my $all_prefs_rs = Koha::Config::SysPrefs->search( undef, { columns => [qw/value variable/] } )->unblessed(); in 4), search is a bit quicker (17.1 ms). Maybe it can be improved somehow further, but I don't know how - any ideas? Those numbers may look not very significant at the first glanace, but remember that it's not uncommon for the Koha script to make 2000+ DBI calls (in such cases, they are usually very repetitive - small stuff fetched from uncomplicated tables, over and over again). -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 15341] Performance - Retrieve all sysprefs at once
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 Jacek Ablewicz <abl(a)biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16076 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #19 from Lari Taskula <larit(a)student.uef.fi> --- (In reply to Julian Maurice from comment #18) > > - /accountlines/:borrowernumber/amountpayment is confusing because of > > :borrowernumber. How about /accountlines/amountpayment?borrowernumber=X > I believe it's not a good idea to mix GET and POST parameters. What about > POST /borrowers/:borrowernumber/payment ? > Good point. That makes more sense. > > - Do you think it would be useful to return total and currency? e.g. > > GET /accountlines?borrowernumber=1 > > { > > "total": 100.00, > > "currency": "USD", > > "rows": [ > > { > > // accountline-object with amountoutstanding 25, > > // accountline-object with amountoutstanding 60, > > // accountline-object with amountoutstanding 15 > > } > > ] > > } > I think it couldn't hurt. But what currency should we return ? The default > (active) currency ? I think yes. Could there be a situation where active currency would not be the correct one, apart from misconfiguration of the active currency? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14868] REST API: Swagger2-driven permission checking
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth(a)kul.oslo.k | |ommune.no --- Comment #22 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- This a very good idea! If you reconsider on the automatic minifying of swagger made in bug 16212 I would be happy to sign off! -- You are receiving this mail because: You are watching all bug changes.

1 0