July 2016 - Koha-bugs - lists.koha-community.org

[Bug 16076] New: DBIx searches - performance issues
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16076 Bug ID: 16076 Summary: DBIx searches - performance issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: abl(a)biblos.pk.edu.pl QA Contact: testopia(a)bugs.koha-community.org While testing Bug 11998 and Bug 15341, I did some quick & dirty comparisons on DBI vs DBIx search performace - how long does it take to fetch from the database: one small system preference (marcflavour) and all system preferences (545 rows). Results: 1) one syspref, DBI: 130 microseconds ( using 'SELECT value FROM systempreferences WHERE variable = ? LIMIT 1') 2) one syspref, DBIx: 1.25 miliseconds ( Koha::Config::SysPrefs->find($var)->value() ) 3) all preferences, DBI: 1.8 miliseconds ( 'SELECT variable, value FROM systempreferences' ) 4) all preferences, DBIx: 21 miliseconds ( Koha::Config::SysPrefs->search()->unblessed(), like in Bug 15341) If I use my $all_prefs_rs = Koha::Config::SysPrefs->search( undef, { columns => [qw/value variable/] } )->unblessed(); in 4), search is a bit quicker (17.1 ms). Maybe it can be improved somehow further, but I don't know how - any ideas? Those numbers may look not very significant at the first glanace, but remember that it's not uncommon for the Koha script to make 2000+ DBI calls (in such cases, they are usually very repetitive - small stuff fetched from uncomplicated tables, over and over again). -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 15341] Performance - Retrieve all sysprefs at once
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 Jacek Ablewicz <abl(a)biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16076 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #19 from Lari Taskula <larit(a)student.uef.fi> --- (In reply to Julian Maurice from comment #18) > > - /accountlines/:borrowernumber/amountpayment is confusing because of > > :borrowernumber. How about /accountlines/amountpayment?borrowernumber=X > I believe it's not a good idea to mix GET and POST parameters. What about > POST /borrowers/:borrowernumber/payment ? > Good point. That makes more sense. > > - Do you think it would be useful to return total and currency? e.g. > > GET /accountlines?borrowernumber=1 > > { > > "total": 100.00, > > "currency": "USD", > > "rows": [ > > { > > // accountline-object with amountoutstanding 25, > > // accountline-object with amountoutstanding 60, > > // accountline-object with amountoutstanding 15 > > } > > ] > > } > I think it couldn't hurt. But what currency should we return ? The default > (active) currency ? I think yes. Could there be a situation where active currency would not be the correct one, apart from misconfiguration of the active currency? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14868] REST API: Swagger2-driven permission checking
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth(a)kul.oslo.k | |ommune.no --- Comment #22 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- This a very good idea! If you reconsider on the automatic minifying of swagger made in bug 16212 I would be happy to sign off! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #18 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Lari Taskula from comment #15) > - Payments should be POST instead of PUT (PUT is idempotent, but > making multiple payments has different effect than sending just one) I agree > - If patron has amountoustanding 0, payment is still possible. > Should we return an error instead? Yes, probably > - /accountlines/:borrowernumber/amountpayment is confusing because of > :borrowernumber. How about /accountlines/amountpayment?borrowernumber=X I believe it's not a good idea to mix GET and POST parameters. What about POST /borrowers/:borrowernumber/payment ? > - Do you think it would be useful to return total and currency? e.g. > GET /accountlines?borrowernumber=1 > { > "total": 100.00, > "currency": "USD", > "rows": [ > { > // accountline-object with amountoutstanding 25, > // accountline-object with amountoutstanding 60, > // accountline-object with amountoutstanding 15 > } > ] > } I think it couldn't hurt. But what currency should we return ? The default (active) currency ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14642] Add logging of hold modifications
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch --- Comment #15 from Marc Véron <veron(a)veron.ch> --- Logging holds is enabled by default. Is that intended? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new borrower field : main contact method.
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #59 from Marc Véron <veron(a)veron.ch> --- installer/data/mysql/updatedatabase.pl adds a field primary_contact_method to borrowers That makes borrowers_primary_contact_method.sql fail (adding fields to borrowers, deletedborrowers, borrower_modifications). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11440] Duplicate authorities when edit a bibliographic record
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11440 Nicholas van Oudtshoorn <vanoudt(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vanoudt(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7170] Remove use of XML::Simple
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com --- Comment #19 from M. Tompsett <mtompset(a)hotmail.com> --- I was looking in the svc ones and came up with this hackiness. sub build_xml_output { my ($xml_hash, $root_name) = @_; my @xml_tags = keys %{$xml_hash}; my @values = map { { 'key' => $_, 'value' => $xml_hash->{$_} } } @xml_tags; my $xml_values; foreach my $value (@values) { $xml_values->{$value->{key}} = $value->{value}; } my $dom = XML::LibXML::Document->new( '1.0', q{} ); $dom->setStandalone(1); my $root = $dom->createElement( $root_name ); $dom->setDocumentElement( $root ); foreach my $xml_tag (@xml_tags) { my $xml_value = $xml_values->{$xml_tag}; my $text = $dom->createTextNode( "\n " ); $root->appendChild($text); my $element = $dom->createElement( $xml_tag ); $root->appendChild($element); if ($xml_value =~ /\<datafield/ ) { my $parser = XML::LibXML->new(); my $fragment = $parser->parse_balanced_chunk( $xml_value ); $element->appendChild( $fragment ); } else { $text = $dom->createTextNode( $xml_value ); $element->appendTextNode($text); } } my $text = $dom->createTextNode( "\n" ); $root->appendChild($text); my $xml_output = $dom->toString(0); print $xml_output; } You can see why XML::Simple with its XMLout method is desirable. :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Nicholas van Oudtshoorn <vanoudt(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vanoudt(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0