July 2016 - Koha-bugs - lists.koha-community.org

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #18 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Lari Taskula from comment #15) > - Payments should be POST instead of PUT (PUT is idempotent, but > making multiple payments has different effect than sending just one) I agree > - If patron has amountoustanding 0, payment is still possible. > Should we return an error instead? Yes, probably > - /accountlines/:borrowernumber/amountpayment is confusing because of > :borrowernumber. How about /accountlines/amountpayment?borrowernumber=X I believe it's not a good idea to mix GET and POST parameters. What about POST /borrowers/:borrowernumber/payment ? > - Do you think it would be useful to return total and currency? e.g. > GET /accountlines?borrowernumber=1 > { > "total": 100.00, > "currency": "USD", > "rows": [ > { > // accountline-object with amountoutstanding 25, > // accountline-object with amountoutstanding 60, > // accountline-object with amountoutstanding 15 > } > ] > } I think it couldn't hurt. But what currency should we return ? The default (active) currency ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14642] Add logging of hold modifications
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch --- Comment #15 from Marc Véron <veron(a)veron.ch> --- Logging holds is enabled by default. Is that intended? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new borrower field : main contact method.
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #59 from Marc Véron <veron(a)veron.ch> --- installer/data/mysql/updatedatabase.pl adds a field primary_contact_method to borrowers That makes borrowers_primary_contact_method.sql fail (adding fields to borrowers, deletedborrowers, borrower_modifications). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11440] Duplicate authorities when edit a bibliographic record
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11440 Nicholas van Oudtshoorn <vanoudt(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vanoudt(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7170] Remove use of XML::Simple
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com --- Comment #19 from M. Tompsett <mtompset(a)hotmail.com> --- I was looking in the svc ones and came up with this hackiness. sub build_xml_output { my ($xml_hash, $root_name) = @_; my @xml_tags = keys %{$xml_hash}; my @values = map { { 'key' => $_, 'value' => $xml_hash->{$_} } } @xml_tags; my $xml_values; foreach my $value (@values) { $xml_values->{$value->{key}} = $value->{value}; } my $dom = XML::LibXML::Document->new( '1.0', q{} ); $dom->setStandalone(1); my $root = $dom->createElement( $root_name ); $dom->setDocumentElement( $root ); foreach my $xml_tag (@xml_tags) { my $xml_value = $xml_values->{$xml_tag}; my $text = $dom->createTextNode( "\n " ); $root->appendChild($text); my $element = $dom->createElement( $xml_tag ); $root->appendChild($element); if ($xml_value =~ /\<datafield/ ) { my $parser = XML::LibXML->new(); my $fragment = $parser->parse_balanced_chunk( $xml_value ); $element->appendChild( $fragment ); } else { $text = $dom->createTextNode( $xml_value ); $element->appendTextNode($text); } } my $text = $dom->createTextNode( "\n" ); $root->appendChild($text); my $xml_output = $dom->toString(0); print $xml_output; } You can see why XML::Simple with its XMLout method is desirable. :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Nicholas van Oudtshoorn <vanoudt(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vanoudt(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Nicholas van Oudtshoorn <vanoudt(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vanoudt(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16720] New: DBIx ActionLogs.pm should be removed
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16720 Bug ID: 16720 Summary: DBIx ActionLogs.pm should be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org It is just a leftover. The update_dbix_class_files.pl now produces non-plural names, and we have ActionLog.pm in the source tree. -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 16502] New: Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502 Bug ID: 16502 Summary: Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Happened to notice that running this test (t/db_dependent/Plugin.t) twice may not have the expected result. Sometimes(?) I need to manually drop the table. Note that quickly adding a transaction does not resolve it. -- You are receiving this mail because: You are watching all bug changes.

1 34

[Bug 10958] no need for home link on home page
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '16

08 Jul '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10958 --- Comment #7 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- why can we not just remove the link from the tt file? -- You are receiving this mail because: You are watching all bug changes.

1 0