August 2016 - Koha-bugs - lists.koha-community.org

[Bug 14504] Add command-line script to batch delete items based on lost/ withdrawn statuses
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '16

22 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54518|0 |1 is obsolete| | --- Comment #60 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 54695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54695&action=ed… Bug 14504: (QA followup) use TestBuilder, remove do_not_commit Use t::lib::TestBuilder in t/db_dependent/Items_DelItemCheck.t Remove the option 'do_not_commit' from C4::Items::DelItemCheck. Whitespace cleanup. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14504] Add command-line script to batch delete items based on lost/ withdrawn statuses
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '16

22 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54517|0 |1 is obsolete| | --- Comment #59 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 54694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54694&action=ed… bug 14504: use C4::Items::DelItemCheck in delete_items.pl Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14504] Add command-line script to batch delete items based on lost/ withdrawn statuses
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '16

22 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54516|0 |1 is obsolete| | --- Comment #58 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 54693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54693&action=ed… bug 14504: split logic from DelItemCheck() into ItemSafeToDelete() Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14504] Add command-line script to batch delete items based on lost/ withdrawn statuses
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '16

22 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54515|0 |1 is obsolete| | --- Comment #57 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 54692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54692&action=ed… Bug 14504: (QA followup) * Fix POD warning. * Remove redundant 'use stric' and 'use warnings' * Remove $VERSION and --version option. * Remove --dry-run option * Split test for --help and check for @criteria into two separate pod2usage calls, enabling -msg on the latter. * Fix 'target_tiems' typo. * Test for holds on items to be deleted. * Fix whitespace * Fix test for holds. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14504] Add command-line script to batch delete items based on lost/ withdrawn statuses
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '16

22 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54514|0 |1 is obsolete| | --- Comment #56 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 54691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54691&action=ed… Bug 14504: Add delete_items.pl: a command line batch deletion tool http://bugs.koha-community.org/show_bug.cgi?id=14504 Signed-off-by: Heather Braum <hbraum(a)nekls.org> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12236] Collapse unused message transport types in notice editor
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '16

22 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12236 --- Comment #6 from M. Tompsett <mtompset(a)hotmail.com> --- Feel free to fix it then. :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12236] Collapse unused message transport types in notice editor
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '16

22 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12236 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12236] Collapse unused message transport types in notice editor
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '16

22 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12236 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '16

22 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #39 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Kyle M Hall from comment #37) > As far as I understand, my followup takes care of the error handling > problem. Not sure about that. You just run them one after another without looking at the exit code of the previous script as initially proposed. Since this keeps package and non-package more in sync, I would agree though. I think we c/should try to resolve the effects of a failing cronjob on other cronjobs in another report. Some implicit consensus about that in the former comments. Sounds like a larger thing btw than just an exit code. And now fix the obvious order. [ Anyone still willing to write the koha-cron.pl that does it all (moving all code to modules)? .. ] Can we merge both patches and have these cronjobs on separate lines again? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14699] Intranet search history issues due to DataTables pagination
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '16

22 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699 --- Comment #8 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Owen Leonard from comment #7) > (In reply to Nick Clemens from comment #6) > > > 2 - Select all searches but respect filters. If I filter down to 8 searches > > it should select only those. If my filter finds 21 searches (default 20 > > visible) it should select all 21, but not searches limited by filter. > > Labels would say "With ## selected searches: delete" > > I think this is the correct goal. With a filtered result clicking "select > all" shouldn't select lines which are not visible because of the filter. > However, with a filtered or unfiltered result clicking "select all" should > select records across all pages. I think there is a problem with this solution: we can't do that with AJAX-paginated tables. It's not the case of this particular table, but if we want to have a consistent behaviour for all the "Select all/Clear all" buttons we must do something that is possible on every table. So, for this particular table I suggest to keep the current behaviour, change only the labels to "Select all visible rows" or something similar, and maybe add an action "Clear all history" ? -- You are receiving this mail because: You are watching all bug changes.

1 0