August 2016 - Koha-bugs - lists.koha-community.org

[Bug 14876] Show number of holds per record on the search results
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '16

22 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 --- Comment #10 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- >From catalogue/detail.pl: #we only need to pass the number of holds to the template my $holds = C4::Reserves::GetReservesFromBiblionumber({ biblionumber => $biblionumber, all_dates => 1 }); $template->param( holdcount => scalar ( @$holds ) ); -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16960] New: Patron::Modifications should be fixed
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '16

22 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960 Bug ID: 16960 Summary: Patron::Modifications should be fixed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The changes from opac-memberentry do not reach the table, since the Patron::Modifications object does not work well. Look at this from opac-memberentry: Koha::Patron::Modifications->new( borrowernumber => $borrowernumber ); Passing borrowernumber here is useless, since it is an instance of Koha::Objects. On the contrary, the following call $m->DelModifications; should have the borrowernumber passed ! So what could we add a sub new to Patron::Modifications like: +sub new { + my ( $class, $params ) = @_; + my $self = $class->SUPER::new(); + $self->{borrowernumber} = $params->{borrowernumber}; + return $self; +} And in opac-memberentry: + my $patronmod = Koha::Patron::Modifications->new({ borrowernumber => $borrowernumber }); + $patronmod->DelModifications({ borrowernumber => $borrowernumber }); + $patronmod->AddModifications(\%borrower_changes); But this is a horrible hack. We should not use a Koha::Objects like that.. And what about its unit test: t/db_dependent/Koha_borrower_modifications.t Currently fails ! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 42

[Bug 13452] Average checkout report always uses biblioitems.itemtype
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '16

22 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|katrin.fischer(a)bsz-bw.de |julian.maurice(a)biblibre.com Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14876] Show number of holds per record on the search results
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '16

22 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de, | |m.de.rooy(a)rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com, tomascohen(a)gmail.com --- Comment #9 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- CCing Katrin, Tomas, Marcel and Martin. It's not clear to me when we need a TT plugin. Sometimes it's obvious (get branch names, get patron category description, filter (json, date, price), pref values, etc.) But sometimes it's not: Borrowers.IsDebarred, Borrowers.HasOverdues. Holds.count is part of this second group. I don't think plugins should be a lazy solution for developers. We need to define when we can use a plugin, otherwise any methods from Koha modules could have their plugin wrapper. And we will have to maintain: Koha::Holds->count({biblionumber => $biblionumber }); Koha::Template::Plugin::Holds->count($biblionumber); and Koha::REST::V1::Hold->count($biblionumber); # does not exist (yet) (I don't switch to in discussion otherwise you will hate me) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13501] Allow autocompletion on drop-down lists
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '16

22 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #47 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Julian Maurice from comment #41) > (In reply to Jonathan Druart from comment #40) > > (In reply to Julian Maurice from comment #37) > > > Created attachment 54637 [details] [review] [review] [review] > > > Bug 13501: Highlight select2 control if field is required and value is > > > missing > > > > Are you sure you want to remove select2.min.css? > > I didn't remove select2.min.css, I added a new file select2.css for custom > CSS related to select2 Sorry I have misread the diff, everything is fine! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13501] Allow autocompletion on drop-down lists
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '16

22 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #46 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 54678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54678&action=ed… Bug 13501: Fix behavior of 'Delete subfield' button on select2 controls Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13501] Allow autocompletion on drop-down lists
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '16

22 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #45 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 54677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54677&action=ed… Bug 13501: Highlight select2 control if field is required and value is missing Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13501] Allow autocompletion on drop-down lists
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '16

22 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #44 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 54676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54676&action=ed… Bug 13501: Move "Required" and checkbox after input/select Signed-off-by: Aleisha <aleishaamohia(a)hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13501] Allow autocompletion on drop-down lists
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '16

22 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #43 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 54675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54675&action=ed… Bug 13501: Indentation fix (batchMod-edit.tt) Signed-off-by: Aleisha <aleishaamohia(a)hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13501] Allow autocompletion on drop-down lists
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '16

22 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54634|0 |1 is obsolete| | Attachment #54635|0 |1 is obsolete| | Attachment #54636|0 |1 is obsolete| | Attachment #54637|0 |1 is obsolete| | Attachment #54638|0 |1 is obsolete| | --- Comment #42 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 54674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54674&action=ed… Bug 13501: Add JS library select2 3.5.4 use it on cataloguing and batch items edit pages Signed-off-by: Aleisha <aleishaamohia(a)hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0