August 2016 - Koha-bugs - lists.koha-community.org

[Bug 15295] Move the C4::Branch related code to Koha::Libraries - part 2
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '16

17 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15295 Jacek Ablewicz <abl(a)biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17142 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17142 [Bug 17142] Don't show library group selection in advanced search if groups are not defined -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14535] Late orders doensn't show orders with price = 0
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '16

17 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14535 --- Comment #2 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Just had another library reporting this as a bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '16

17 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #25 from M. Tompsett <mtompset(a)hotmail.com> --- The addbiblio.tt conflict is easy enough to resolve, though you need to look into fontawesome classes instead of icon-ok. The C4/Biblio.pm conflict is harder to resolve, as the logic which is ripped out and replaced with a function has changed. This means the logic in the new function needed to be rechecked. Please rebase. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13914] The holds statistics report returns random data
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '16

17 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13914 Sophie MEYNIEUX <sophie.meynieux(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt(a)gmail.com |sophie.meynieux(a)biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13736] Enable EDS Plugin Patch
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '16

17 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13736 --- Comment #5 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 42894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42894 EDS Plugin Patches Code checks to see if setting EDSEnabled is ON and integrates the EDS Plugin to the Opac Review of attachment 42894: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=137…) ----------------------------------------------------------------- I'm pretty sure something jquery/ajax-y could be written to get the plugin to accomplish the same thing. I too, like Katrin in comment #4, have some misgivings about this implementation. ::: C4/Auth.pm @@ +471,4 @@ > AuthorisedValueImages => C4::Context->preference("AuthorisedValueImages"), > BranchesLoop => GetBranchesLoop($opac_name), > BranchCategoriesLoop => GetBranchCategories( 'searchdomain', 1, $opac_name ), > + EDSEnabled => C4::Context->preference("EDSEnabled"), Never needed. Access [% Koha.Preference('EDSEnabled') %] in template files. ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc @@ +48,4 @@ > function _(s) { return s } // dummy function for gettext > </script> > <script type="text/javascript" src="[% interface %]/[% theme %]/lib/modernizr.min.js"></script> > +[% IF ( EDSEnabled ) %]<script type="text/javascript" language="javascript" src="/plugin/Koha/Plugin/EDS/js/EDSScript.js"></script>[% END %] Including a plugin javascript link should be possible in the OPACUserJS system preference. Make sure to carefully add/remove as needed! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16372] New: Replace the use of "onclick" for deletion confirmation in some templates
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '16

17 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16372 Bug ID: 16372 Summary: Replace the use of "onclick" for deletion confirmation in some templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Several templates include the use of an "onclick" attribute to handle deletion confirmations: intranet-main.tt patron_lists/lists.tt patroncards/image-manage.tt tools/koha-news.tt These should be modified so that events are handled in JavaScript. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 14251] style discharge letter
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '16

17 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 --- Comment #7 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Not totally sure - we haven't played much with the discharge notices so far. We have added a few line breaks so far, but no more formatting I think. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 6499] MARC21 035 -- Other-control-number -- Indexing & Matching
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '16

17 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499 Frédéric Demians <frederic(a)tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic(a)tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #26 from Frédéric Demians <frederic(a)tamil.fr> --- Pushed in 16.05. Will be in 16.05.03. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17068] New: empty list item in opac-reserves.tt
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '16

17 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17068 Bug ID: 17068 Summary: empty list item in opac-reserves.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: ephetteplace(a)cca.edu QA Contact: testopia(a)bugs.koha-community.org There's an empty <li> in opac-reserves.tt around line 280: </li> [% END # / IF OpacHoldNotes %] <li> </li> [% IF bibitemloo.itemholdable %]  etc... I'll add a patch in a bit that just deletes this tag. Testing plan: - sign in as user, go to place a hold - view source on the holds page, find empty <li> in between the "hold notes" textarea and the  comment - apply patch - revisit holds page - no more empty list item -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 16622] New: some tests triggered by prove t fail for unset KOHA_CONF
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '16

17 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16622 Bug ID: 16622 Summary: some tests triggered by prove t fail for unset KOHA_CONF Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: mtompset(a)hotmail.com QA Contact: gmcharlt(a)gmail.com unset'ing KOHA_CONF from your environment, and then triggering 'prove t' results in several tests warning and complaining about C4::Context. Make sure failing tests are in the correct location (t vs t/db_dependent), properly mocked, or catch the warnings. The second option being the preferred one. -- You are receiving this mail because: You are watching all bug changes.

1 22