August 2016 - Koha-bugs - lists.koha-community.org

[Bug 16849] New: Move IsDebarred to Koha::Patron->is_debarred
by bugzilla-daemon＠bugs.koha-community.org 15 Aug '16

15 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 Bug ID: 16849 Summary: Move IsDebarred to Koha::Patron->is_debarred Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 15 Aug '16

15 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Mirko Tietgen <mirko(a)abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost
by bugzilla-daemon＠bugs.koha-community.org 15 Aug '16

15 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 --- Comment #20 from Marc Véron <veron(a)veron.ch> --- (In reply to M. Tompsett from comment #19) > (In reply to Marc Véron from comment #17) > > I tested and got following results: > > OPAC: > > Detail page: > > http://www.amazon.com/dp/3907142330?tag=TEST& > > Missing ref=sib_dp_pt/002-7879865-0184864 is not the issue. The issue is the > dangling ampersand. Though if you really think that adding the ref portion > is the correct course of action, I could do that. What say you, Marc? I did some research, it seems that http://www.amazon.com/dp/3907142330?tag=TEST will be OK. Trailing & is superfluous. It seems to do no harm but can we remove it anyway? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 15 Aug '16

15 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50168|0 |1 is obsolete| | --- Comment #104 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 54452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54452&action=ed… bug_11213: Check for $item->{itype} presence to avoid warning -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 15 Aug '16

15 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 15 Aug '16

15 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50167|0 |1 is obsolete| | --- Comment #103 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 54451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54451&action=ed… bug_11213: Added XSLTParse4Display() to Items test -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 15 Aug '16

15 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50166|0 |1 is obsolete| | --- Comment #102 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 54450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54450&action=ed… bug_11213: GetItemsInfo() test -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 15 Aug '16

15 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50165|0 |1 is obsolete| | --- Comment #101 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 54449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54449&action=ed… bug_11213: Include XSLT processing for searchResults() test * Added template paths to temp test dir, so XSLT templates can be picked up -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 15 Aug '16

15 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50164|0 |1 is obsolete| | --- Comment #100 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 54448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54448&action=ed… bug_11213: whitespace correction -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 15 Aug '16

15 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50163|0 |1 is obsolete| | --- Comment #99 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 54447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54447&action=ed… bug_11213: Changed XSLTParse4Display() interface The list of biblio items is passed on now, instead of GetItemsInfo() being called. This is because the callers already have the list ready, so the GetItemsInfo() call is being duplicated unnecessarily. Search::searchResults() builds items list from XML, and that one is passed instead. * XSLT::XSLTParse4Display() - supply the items list as input param - removed hidden items list param - hidden should not be in the items list - changed buildKohaItemsNamespace() accordingly * Items - added sort_by input param to GetItemsInfo() * catalogue/detail.pl, opac/opac-detail.pl, shelfpage() - added items list to the XSLTParse4Display() call * Search::searchResults() - include all available info when building items lists - added combined items list (available, on loan, other) to the XSLTParse4Display() call To test: This change is a noop, so following screens need to be checked against any changes: * Intranet: - catalogue/search.pl (results) - catalogue/detail.pl - virtualshelves/shelves.pl * Opac - opac-search.pl (results, hidelostitems syspref on and off) - opac-detail.pl - opac-shelves.pl The display should stay the same before and after patch. The speed should increase though. -- You are receiving this mail because: You are watching all bug changes.

1 0