August 2016 - Koha-bugs - lists.koha-community.org

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 15 Aug '16

15 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50166|0 |1 is obsolete| | --- Comment #102 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 54450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54450&action=ed… bug_11213: GetItemsInfo() test -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 15 Aug '16

15 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50165|0 |1 is obsolete| | --- Comment #101 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 54449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54449&action=ed… bug_11213: Include XSLT processing for searchResults() test * Added template paths to temp test dir, so XSLT templates can be picked up -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 15 Aug '16

15 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50164|0 |1 is obsolete| | --- Comment #100 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 54448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54448&action=ed… bug_11213: whitespace correction -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11213] GetItemsInfo() called twice
by bugzilla-daemon＠bugs.koha-community.org 15 Aug '16

15 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50163|0 |1 is obsolete| | --- Comment #99 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 54447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54447&action=ed… bug_11213: Changed XSLTParse4Display() interface The list of biblio items is passed on now, instead of GetItemsInfo() being called. This is because the callers already have the list ready, so the GetItemsInfo() call is being duplicated unnecessarily. Search::searchResults() builds items list from XML, and that one is passed instead. * XSLT::XSLTParse4Display() - supply the items list as input param - removed hidden items list param - hidden should not be in the items list - changed buildKohaItemsNamespace() accordingly * Items - added sort_by input param to GetItemsInfo() * catalogue/detail.pl, opac/opac-detail.pl, shelfpage() - added items list to the XSLTParse4Display() call * Search::searchResults() - include all available info when building items lists - added combined items list (available, on loan, other) to the XSLTParse4Display() call To test: This change is a noop, so following screens need to be checked against any changes: * Intranet: - catalogue/search.pl (results) - catalogue/detail.pl - virtualshelves/shelves.pl * Opac - opac-search.pl (results, hidelostitems syspref on and off) - opac-detail.pl - opac-shelves.pl The display should stay the same before and after patch. The speed should increase though. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11232] Retrieve facets from Zebra
by bugzilla-daemon＠bugs.koha-community.org 15 Aug '16

15 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17123 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost
by bugzilla-daemon＠bugs.koha-community.org 15 Aug '16

15 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 --- Comment #19 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Marc Véron from comment #17) > I tested and got following results: > OPAC: > Detail page: > http://www.amazon.com/dp/3907142330?tag=TEST& Missing ref=sib_dp_pt/002-7879865-0184864 is not the issue. The issue is the dangling ampersand. Though if you really think that adding the ref portion is the correct course of action, I could do that. What say you, Marc? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 15 Aug '16

15 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #100 from David Cook <dcook(a)prosentient.com.au> --- (In reply to M. Tompsett from comment #99) > I'm going to guess off the top of my head without checking... But I usually > state the file where the problem is. That's why it is marked as "Patch does > not apply". How very concise. In hindsight, "PerlDependencies issue." and "Patch does not apply" does imply that the patch didn't apply, because of an issue with the PerlDependencies.pm changes. Thanks for that. I'll look into it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7595] Add branchcode to accountlines
by bugzilla-daemon＠bugs.koha-community.org 15 Aug '16

15 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #51 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Continued testing, but didn't get much further: IV CIRCULATION 1) Checkout with rental fine OK 2) Renew with rental fine NOT OK - no rental fine recorded >From the logs: [Mon Aug 15 00:09:28.378180 2016] [cgi:error] [pid 20899] [client 127.0.0.1:48043] AH01215: [Mon Aug 15 00:09:28 2016] renew: DBD::mysql::st execute failed: Unknown column 'branch' in 'field list' [for Statement "INSERT INTO accountlines, referer: http://localhost:8080/cgi-bin/koha/circ/circulation.pl?borrowernumber=1 [Mon Aug 15 00:09:28.378352 2016] [cgi:error] [pid 20899] [client 127.0.0.1:48043] AH01215: [Mon Aug 15 00:09:28 2016] renew: (date, borrowernumber, accountno, amount, manager_id,, referer: http://localhost:8080/cgi-bin/koha/circ/circulation.pl?borrowernumber=1 [Mon Aug 15 00:09:28.378447 2016] [cgi:error] [pid 20899] [client 127.0.0.1:48043] AH01215: [Mon Aug 15 00:09:28 2016] renew: description,accounttype, amountoutstanding, itemnumber, branch), referer: http://localhost:8080/cgi-bin/koha/circ/circulation.pl?borrowernumber=1 [Mon Aug 15 00:09:28.378810 2016] [cgi:error] [pid 20899] [client 127.0.0.1:48043] AH01215: [Mon Aug 15 00:09:28 2016] renew: VALUES (now(),?,?,?,?,?,?,?,?,?)" with ParamValues: 0="1", 1='43', 2=0.1000, 3="1", 4="Renewal of Rental Item Something", 5='Rent', 6=0.1000, 7="751", 8="TPL"] at /home/katrin/kohaclone/C4/Circulation.pm line 3120., referer: http://localhost:8080/cgi-bin/koha/circ/circulation.pl?borrowernumber=1 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7595] Add branchcode to accountlines
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '16

14 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #50 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I am testing with a staff patron logged in at a different branch than their homebranch. The problems spotted so far concern writing off fines. Some first test results: I GENERAL - Passes QA test tools - Passes perl t/db_dependent/Accounts.t - Database update ok II API 1) Koha offline circulation - Payment is correctly applied. Logged-in branch of the staff user is recorded. 2) SIP - ( To be tested ) III PATRON ACCOUNT - STAFF 1) Reverse payment OK 2) Create manual invoice OK 3) Create manual credit OK 4) Pay (single fine) OK 5) Pay selected OK 6) Write off (single fine) NOT OK - doesn't record a branchcode. 7) Pay an amount (partial) OK 8) Write off all NOT OK - doesn't record a branchcode. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17122] New: Paying fines via Koha offline circulation reports false success for non-existing cardnumbers
by bugzilla-daemon＠bugs.koha-community.org 14 Aug '16

14 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17122 Bug ID: 17122 Summary: Paying fines via Koha offline circulation reports false success for non-existing cardnumbers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com If the cardnumber doesn't exist, applying the koc file will still report success. - Upload .koc file, don't apply directly, but add to queue. - Take a look at the queue - verify cardnumbers shows in red and is not linked (not found) - Apply payment anyway - verify it reports "Success." The logs show: [Sun Aug 14 23:05:43.150296 2016] [cgi:error] [pid 18058] [client 127.0.0.1:43714] AH01215: [Sun Aug 14 23:05:43 2016] process.pl: DBD::mysql::st execute failed: Column 'borrowernumber' cannot be null [for Statement "INSERT INTO accountlines, referer: http://localhost:8080/cgi-bin/koha/offline_circ/list.pl [Sun Aug 14 23:05:43.150512 2016] [cgi:error] [pid 18058] [client 127.0.0.1:43714] AH01215: [Sun Aug 14 23:05:43 2016] process.pl: (borrowernumber, accountno,date,amount,description,accounttype,amountoutstanding,manager_id, note), referer: http://localhost:8080/cgi-bin/koha/offline_circ/list.pl [Sun Aug 14 23:05:43.150848 2016] [cgi:error] [pid 18058] [client 127.0.0.1:43714] AH01215: [Sun Aug 14 23:05:43 2016] process.pl: VALUES (?,?,now(),?,'',?,?,?,?)" with ParamValues: 0=undef, 1=1, 2=-1.05, 3='Pay', 4=-1.05, 5="1", 6=''] at /home/katrin/kohaclone/C4/Accounts.pm line 157., referer: http://localhost:8080/cgi-bin/koha/offline_circ/list.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0