August 2016 - Koha-bugs - lists.koha-community.org

[Bug 8964] AllowHoldsOnDamagedItems and AllowOnShelfHolds don' t work with Professional category type
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '16

12 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8964 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Owen Leonard <oleonard(a)myacpl.org> --- I cannot reproduce this bug in master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 11121] Patron Card Creator batch export cannot handle special characters ( usually)
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '16

12 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11121 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #4 from Owen Leonard <oleonard(a)myacpl.org> --- This appears to be fixed in master. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8875] Cataloging authorithy search plugin displays badly accented characters
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '16

12 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8875 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|In Discussion |RESOLVED --- Comment #6 from Owen Leonard <oleonard(a)myacpl.org> --- This appears to be fixed in master. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10187] precision needed in serials-collection.tt (1/quarter)
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '16

12 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |FIXED --- Comment #11 from Owen Leonard <oleonard(a)myacpl.org> --- (In reply to Katrin Fischer from comment #10) > Is this bug still valid with the reworked serials module? I'm going to say not, since frequencies are no longer coded into the template. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '16

12 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #78 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #76) > Patch 3 > It will probably work most of the time, but we assume often here that the > find returned a record and access its columns rightaway without checking. Yes, and it was almost the same before. Except that now the app will explode :) At least we able to catch if something is wrong elsewhere. But you are right, we need to focus on these calls. > Patch 4 > admin/patron-attr-types.pl: Why collecting first in scalar context and later > in list context ? Seeing no difference, just slightly inconsistent.. Fixed in last follow-up. > Passed QA Thanks! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '16

12 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #77 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 54371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54371&action=ed… Bug 15407: Uniformise calls in patron-attr-types Does not make sense to call first in list context and later in scalar context. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '16

12 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | Patch complexity|--- |Medium patch Status|Signed Off |Passed QA --- Comment #76 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: Code looks good to me. Tested selectively. Especially checked the code carefully; hard to test everything in limited time. With a quick push we will have some time before release to fix one or two things if needed. The number of follow-ups here shows that we already found some. Bonus points for the rest. Patch 3 It will probably work most of the time, but we assume often here that the find returned a record and access its columns rightaway without checking. Patch 4 admin/patron-attr-types.pl: Why collecting first in scalar context and later in list context ? Seeing no difference, just slightly inconsistent.. Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '16

12 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 --- Comment #75 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 54369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54369&action=ed… Bug 15407: [QA Follow-up] Confusing cathash removed One of the patches removed %cathash. Some kind of silly remainder was left in a string. Just used as a text field to explain the filters used on borrowers_stats.pl. The filter name cathash is not really easy and also was confusing in relation to the variable. So just a string patch, replacing it with Patron category. NOTE: The output of borrowers_stats.pl with the filters listed, is not one of the most beautiful Koha screens. Furthermore, translatibility of these filters is still an issue to be handled on another report. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '16

12 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54355|0 |1 is obsolete| | --- Comment #74 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 54368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54368&action=ed… Bug 15407: (follow-up) Koha::Patron::Categories - replace C4::Category->al Categories.GetName should not have been removed in the previous patch (merge conflict issue). Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2
by bugzilla-daemon＠bugs.koha-community.org 12 Aug '16

12 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54353|0 |1 is obsolete| | --- Comment #73 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 54367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54367&action=ed… Bug 15407: [QA Follow-up] Joubu, add your tests Trivial fix (yes again). Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0