August 2016 - Koha-bugs - lists.koha-community.org

[Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '16

09 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 --- Comment #46 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Katrin Fischer from comment #45) > Hi Jacek, how do you add to the po files? > You should not need to change anything manually there. For a git > installation try: > - switch to misc/translator in your koha directory > - perl translate update <langcode> > - perl translate install <langcode> > > The first updates the templates the second installs them from the po file > for testing. That's how I've been trying to test it. Well, manually adding a few odd extra strings in the .po file and 'translate install' without 'translate update' is not below my dignity too ;) - I know it's not a proper way, but it should work just fine for testing purposes (usually does in similar circumstances). Problem is that messages embedded in the .js file ("This field is required", "Please enter a valid email address", ...) are not picked up for translation. This is most likely normal, I just wasn't aware of that. Looks like there are several ways to fix this issue, either globally for OPAC/bootstrap - like it was done for intranet/prog in Bug 6209, or locally in the given OPAC templates, e.g. using a combination of jQuery.extend(jQuery.validator.messages, { required: _("This field is required."), email: _("Please enter a valid email address."), ... for the "regular" mandatory fields, and/or jQuery.validator.addMethod("year", function(value, element) { ... }, _("Please enter a year in the valid format (YYYY, YY--)")); for a field with the pattern. I guess preferably it should be fixed globally for the OPAC (opac-memberentry.tt is affected by this too), but I'm a bit out of my depth here - I'll better open a separate bug report for that part. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14642] Add logging of hold modifications
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '16

09 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 --- Comment #22 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 54177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54177&action=ed… Bug 14642: (QA followup) Add tests for Koha::Hold->delete Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14642] Add logging of hold modifications
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '16

09 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '16

08 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 --- Comment #45 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Jacek, how do you add to the po files? You should not need to change anything manually there. For a git installation try: - switch to misc/translator in your koha directory - perl translate update <langcode> - perl translate install <langcode> The first updates the templates the second installs them from the po file for testing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15200] t/Creators.t fails when using build-git-snapshot
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '16

08 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200 Mirko Tietgen <mirko(a)abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14678] Update Koha language codes to ISO 639-2 spec
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '16

08 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14678 Lisette <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2559] Language limit on Spanish returns Russian records or is it English ...
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '16

08 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2559 Lisette <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '16

08 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 --- Comment #44 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- > > Note that there is a JS validation plugin available in the OPAC if you want > > to use it. See opac-memberentry.tt for an example. The plugin can be set up > > to validate a form based on the markup (requiring fields which are , so it's > > not necessary to dynamically configure the fields in the JS if you don't > > want to. > > Hm, would it be as simple as adding jquery.validate.min.js include and one > jquery call > > $('#add_suggestion_form').validate(); > > to the template? Let me see how it works ( please do not adjust your set).. So far so good, it's working (almost) fine, apart from two small issues: 1) for 'pattern' rule to work I guess additional include (additional-methods.js or pattern.js ?) may be needed, but neither seems to be anywhere in the code tree yet (?) - or maybe there is some other bug report waiting in the queue which includes one of them, that I can test and sign instead? 2) translateability - no matter what I try to add to the .po files etc., "This field is required" still appears only in english (but so is the "Please enter a valid email address." message in opac-memberentry.tt ?). Perhaps it's just my test install which is missing something, or in order for this message to be translateable some additional trickery may be needed.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15567] Update API to allow multiple holds for the same record
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '16

08 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15567 Lisette <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15106] Batch Patron Modification Performance Improvement
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '16

08 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15106 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

1 0