August 2016 - Koha-bugs - lists.koha-community.org

[Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '16

08 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 --- Comment #43 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Katrin Fischer from comment #41) > Would this be improved by Owen's suggestion of using the existing JS > validation plugin? JQuery validation plugin (instead of - or as an addition to - HTML5 attributes alone) seems to be a better choice (more configurable, extensible, and probably more predictable with old browsers as well). However so far I have zero experience with this plugin (or any other jQuery plugins for that matter). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15200] t/Creators.t fails when using build-git-snapshot
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '16

08 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200 --- Comment #5 from Mirko Tietgen <mirko(a)abunchofthings.net> --- *** Bug 17046 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17046] New: t/Creators.t kills master packages
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '16

08 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17046 Bug ID: 17046 Summary: t/Creators.t kills master packages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: mirko(a)abunchofthings.net QA Contact: gmcharlt(a)gmail.com debian/build-git-snapshot on master dies because of t/Creators.t: ERROR in koha-conf.xml -- missing /path/to/font.ttf at /build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 120. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 120. # Failed test 'testing StrWidth() returns correct point width' # at t/Creators.t line 55. # got: '19.344' # expected: '23.044921875' # Failed test 'testing Text() writes to the correct x-value' # at t/Creators.t line 59. # got: '29.344' # expected: '33.044921875' ERROR in koha-conf.xml -- missing /path/to/font.ttf at /build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 120. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 120. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 120. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 120. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 120. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 120. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 120. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 120. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 120. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 120. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 120. ERROR in koha-conf.xml -- missing /path/to/font.ttf at /build/koha-16.06~nightly+20160804085200.4a70dc58/blib/PERL_MODULE_DIR/C4/Creators/PDF.pm line 120. Wide character in compress at /usr/share/perl5/PDF/Reuse.pm line 820. # Looks like you planned 41 tests but ran 39. # Looks like you failed 2 tests of 39 run. # Looks like your test exited with 25 just after 39. t/Creators.t ........................ Dubious, test returned 25 (wstat 6400, 0x1900) Failed 4/41 subtests -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 15200] t/Creators.t fails when using build-git-snapshot
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '16

08 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15200 --- Comment #4 from Mirko Tietgen <mirko(a)abunchofthings.net> --- Building packages should work without Koha installed anyway. And no other test fails for that, just this one. This needs to be fixed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7441] Search results showing wrong branch
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '16

08 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7441] Search results showing wrong branch
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '16

08 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #90 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I didn't intend to block - just to look into it. Failed is to strong.. In Discussion has a bad reputation :) Can we just add a little note to the pref for documentation sakes? I can do so in a follow-up. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7441] Search results showing wrong branch
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '16

08 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #89 from Magnus Enger <magnus(a)libriotech.no> --- (In reply to Jonathan Druart from comment #88) > I am not sure it's a valid to fail QA these patches, or we need someone > taking on NORMARC changes. > Especially when the patches are waiting for 4 years. Please don't wait for me. :-) I'll have a look and do a followup later for NORMARC. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7441] Search results showing wrong branch
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '16

08 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #88 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #87) > This shouldn't break things for NORMARC, but I'd like Magnus to take a look. > We should support NORMARC or note that we don't (I'd prefer the former). I am not sure it's a valid to fail QA these patches, or we need someone taking on NORMARC changes. Especially when the patches are waiting for 4 years. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '16

08 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17069 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17069 [Bug 17069] Can't create new patron category on the intranet -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '16

08 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 --- Comment #42 from Jacek Ablewicz <abl(a)biblos.pk.edu.pl> --- (In reply to Owen Leonard from comment #38) > I find that it's not possible to make the "library" selection mandatory. Is > there a reason for that? No, I just forgot about it. While it would not affect form submission itself (there will be always some non-empty value submitted in case when AllowPurchaseSuggestionBranchChoice is enabled), similar logic applies for itemtype, and yet our librarians found it vitally important that this field too could be marked as mandatory. And I agreed, good for consistency. Also still useful as an optional remainder for the user that a given field is relatively important and that they should pay a closer attention to set it accordingly. > Note that there is a JS validation plugin available in the OPAC if you want > to use it. See opac-memberentry.tt for an example. The plugin can be set up > to validate a form based on the markup (requiring fields which are , so it's > not necessary to dynamically configure the fields in the JS if you don't > want to. Hm, would it be as simple as adding jquery.validate.min.js include and one jquery call $('#add_suggestion_form').validate(); to the template? Let me see how it works ( please do not adjust your set).. -- You are receiving this mail because: You are watching all bug changes.

1 0