August 2016 - Koha-bugs - lists.koha-community.org

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '16

07 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #112 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 54091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54091&action=ed… [PASSED QA] Bug 6934: QA Follow-up Tried to address every single thing that QA mentioned : 1)Removed isNull function 2)Changed datepicker properly 3)We have to fill in two dates not to be flooded with old entries if we don't want to. 4)The first two fieldsets are now in one bigger field set 5)Removed the use of $fullreportname variable 6)Removed the use of dt_from_string when it already recieved a DT. 7)Removed comments starting with "###" in cash_register_stats.pl 8)Used Text::CSV::Encoded to generate the CSV file (used guided_reports.pl as an example) 9)I am not sure if using C4::Reports::Guided is the right choice here. I instead used the same column names as the one recieved by the query in cash_register_stats because this report uses columns from 5 different tables in addition of using both firstname and surname twice. For the ninth point, I would like to know more about C4::Reports::Guided if you still think using it would be a better solution. Thank you! Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '16

07 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #111 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 54090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54090&action=ed… [PASSED QA] Bug 6934: New features, note added to transaction information, total caculated for negative types of transaction To be more specific, the column note from accountlines is now displayed in the table of the transactions. The grand total is now calculated for neagtive types like Credit or Payment and isn't counted for Write off types. Credit (return item) 'CR' has been added to drop down of transaction type Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Works as advertised Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '16

07 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #110 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 54089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54089&action=ed… [PASSED QA] Bug 6934: Fix code in CashRegisterStats (dataTables pagination, more accurate descriptions, add a delimiter pull down, change C4::Dates to Koha::DateUtils) I cleaned up the code according to comment #23. I got rid of DHTMLcalendar_dateformat, beacause it wasn't use in cash_register_stats.tt. C4::Dates is deprecated, Koha::DateUtils is now used. Some column names are changed and the pagination for the dataTables is fixed. Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '16

07 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #109 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 54088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54088&action=ed… [PASSED QA] Bug 6934: New report Cash Register Statistics This patch creates a new report that outputs cash register stats for a specific period. Changes: koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc - Added cash register report link koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash-register_stats.tt - new file koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt - Added cash register report link reports/cash-register_stats.pl - new file Testing: I Apply the patch 0) Go to reports home page (Home › Reports); 1) Validate link << Cash Register >> under Statistics wizards; 2) Click link; 3) Validate page with three fieldsets; 4) Chose a date interval, a transaction type, a library and an output; 5) Validade the result. Signed-off-by: Nicole <nicole(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 17042] New: Fix missing properties in Swagger definition for Hold
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '16

07 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042 Bug ID: 17042 Summary: Fix missing properties in Swagger definition for Hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: larit(a)student.uef.fi QA Contact: testopia(a)bugs.koha-community.org api/v1/definitions/hold.json is missing a property itemtype. Add this property. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 14803] Rental and fine fees are not updating on circulation screen
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '16

07 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Christopher Brannon <cbrannon(a)cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon(a)cdalibrary.org Status|Needs Signoff |Failed QA --- Comment #16 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- >From what I can tell, when the patches are applied, it breaks the form #mainform, and is not displayed. Cannot follow test plan. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9851] way to get full records for purchase suggestions
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '16

07 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9851 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Sandre - thx for your comments! If you don't order from suggestions the 'ordered' and 'available' status can not be reached for the suggestion. Could it be a workaround to overlay the record with z39.50 after creating the order line? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '16

07 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 barbara.johnson(a)bedfordtx.gov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54021|0 |1 is obsolete| | --- Comment #40 from barbara.johnson(a)bedfordtx.gov --- Created attachment 54084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54084&action=ed… Bug 10848 - Allow configuration of mandatory/required fields on the suggestion form in OPAC - part 2 Add 'OPACSuggestionMandatoryFields' syspref definition plus an atomic DB update for the new preference. Signed-off-by: barbara johnson <barbara.johnson(a)bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '16

07 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 barbara.johnson(a)bedfordtx.gov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54020|0 |1 is obsolete| | --- Comment #39 from barbara.johnson(a)bedfordtx.gov --- Created attachment 54083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54083&action=ed… Bug 10848 - Allow configuration of mandatory/required fields on the suggestion form in OPAC This patch adds a configuration option which allows to define which fields should be mandatory for a patron purchase suggestion form in OPAC. Test plan: 1/ Apply patch. 2/ Play with the new OPACSuggestionMandatoryFields system preference (select some fields as manadatory, select all, deselect all, try to submit some suggestions with mandatory fields filled and/or not filled etc.) to ensure that required fields (and only required fields) are enforced in the browser to be filled. 3/ With all options deselected, 'Title' field should still be mandatory (by default). Signed-off-by: barbara johnson <barbara.johnson(a)bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '16

07 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848 barbara.johnson(a)bedfordtx.gov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0