August 2016 - Koha-bugs - lists.koha-community.org

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '16

07 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #118 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 54097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54097&action=ed… [PASSED QA] Bug 6934: Make CSV header column translatable and add total amounts in csv file Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '16

07 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #117 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 54096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54096&action=ed… [PASSED QA] Bug 6934: fix problem when export it open in LibreOffice - show values of itype and use TT plugin Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '16

07 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #116 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 54095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54095&action=ed… [PASSED QA] Bug 6934: QA follow-up - fixed tabs - fixed capitalization on reports start page Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '16

07 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #115 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 54094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54094&action=ed… [PASSED QA] Bug 6934: fixed encoding issue Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Encoding issue fixed Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '16

07 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #114 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 54093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54093&action=ed… [PASSED QA] Bug 6934: second fix to calendars Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '16

07 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #113 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 54092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54092&action=ed… [PASSED QA] Bug 6934: Fixed Calendar and removed used of unexisting and unused C4::Budgets getCurrency Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '16

07 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #112 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 54091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54091&action=ed… [PASSED QA] Bug 6934: QA Follow-up Tried to address every single thing that QA mentioned : 1)Removed isNull function 2)Changed datepicker properly 3)We have to fill in two dates not to be flooded with old entries if we don't want to. 4)The first two fieldsets are now in one bigger field set 5)Removed the use of $fullreportname variable 6)Removed the use of dt_from_string when it already recieved a DT. 7)Removed comments starting with "###" in cash_register_stats.pl 8)Used Text::CSV::Encoded to generate the CSV file (used guided_reports.pl as an example) 9)I am not sure if using C4::Reports::Guided is the right choice here. I instead used the same column names as the one recieved by the query in cash_register_stats because this report uses columns from 5 different tables in addition of using both firstname and surname twice. For the ninth point, I would like to know more about C4::Reports::Guided if you still think using it would be a better solution. Thank you! Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '16

07 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #111 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 54090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54090&action=ed… [PASSED QA] Bug 6934: New features, note added to transaction information, total caculated for negative types of transaction To be more specific, the column note from accountlines is now displayed in the table of the transactions. The grand total is now calculated for neagtive types like Credit or Payment and isn't counted for Write off types. Credit (return item) 'CR' has been added to drop down of transaction type Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Works as advertised Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '16

07 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #110 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 54089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54089&action=ed… [PASSED QA] Bug 6934: Fix code in CashRegisterStats (dataTables pagination, more accurate descriptions, add a delimiter pull down, change C4::Dates to Koha::DateUtils) I cleaned up the code according to comment #23. I got rid of DHTMLcalendar_dateformat, beacause it wasn't use in cash_register_stats.tt. C4::Dates is deprecated, Koha::DateUtils is now used. Some column names are changed and the pagination for the dataTables is fixed. Signed-off-by: Hector Castro <hector.hecaxmmx(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6934] New report Cash Register Statistics
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '16

07 Aug '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #109 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 54088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54088&action=ed… [PASSED QA] Bug 6934: New report Cash Register Statistics This patch creates a new report that outputs cash register stats for a specific period. Changes: koha-tmpl/intranet-tmpl/prog/en/includes/reports-menu.inc - Added cash register report link koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash-register_stats.tt - new file koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt - Added cash register report link reports/cash-register_stats.pl - new file Testing: I Apply the patch 0) Go to reports home page (Home › Reports); 1) Validate link << Cash Register >> under Statistics wizards; 2) Click link; 3) Validate page with three fieldsets; 4) Chose a date interval, a transaction type, a library and an output; 5) Validade the result. Signed-off-by: Nicole <nicole(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0