September 2016 - Koha-bugs - lists.koha-community.org

[Bug 11921] memcached configuration should be moved back to koha-conf.xml
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '16

08 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #27 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14695] Add ability to place multiple item holds on a given record per patron
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '16

08 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #219 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 55332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55332&action=ed… Bug 14695 [QA Followup] * Add tests for CanItemBeReserved returns 'itemAlreadyOnHold' to t/db_dependent/Holds.t * Don't let GetReserveId explode * Use search instead of map * Remove instances of resbarcode * Fix badly formed li closing tag -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14695] Add ability to place multiple item holds on a given record per patron
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '16

08 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6852] Staged import reports wrong success for items with false branchcode
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '16

08 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6852 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55330|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6852] Staged import reports wrong success for items with false branchcode
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '16

08 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6852 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6852] Staged import reports wrong success for items with false branchcode
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '16

08 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6852 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt(a)gmail.com |m.de.rooy(a)rijksmuseum.nl CC| |m.de.rooy(a)rijksmuseum.nl Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6852] Staged import reports wrong success for items with false branchcode
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '16

08 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6852 --- Comment #6 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 55331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55331&action=ed… Bug 6852: Staged import reports wrong success for items If we import items that have a wrong branch code, the items will not be imported but manage-marc-import reports them as imported. (A wrong branch code probably occurs most, but other causes are possible too.) The underlying cause is that AddItem does not look at the error returned from _koha_new_item in Items.pm. This patch deals with that omission in the most economical way. It adjusts AddItem so that it returns undef if no item was added. In ImportBatch.pm I check if an item was added and adjust the totals accordingly instead of just always counting them. Note: Several scripts like additem.pl use AddItemFromMarc to call AddItem. They do not report an error, but fail silently. With this patch, these scripts get undef and will still fail silently. (No change.) Adding error checks around calls of AddItemFromMarc is outside the scope of this report. Here we are taking care of correct imported item numbers. Test plan: [1] Verify that additem.pl still works by adding a new item. [2] Run t/db_dependent/Items.t [3] Add a new branchcode, say XXX. [4] Pick a biblio record with a few items (n) and set one item to branch XXX. [5] Export this biblio with items to a MARC file. [6] Change the XXX item to the original branch and remove branch XXX. [7] Import the MARC file. Verify that one item was not imported and that the number of imported items reflects that (equals n-1). -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 14695] Add ability to place multiple item holds on a given record per patron
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '16

08 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #218 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #209) > t/db_dependent/Reserves/MultiplePerRecord.t > What's the difference between rule3 and rule4? They have different itemtypes to demonstrate the behavior that if a record has mixed itemtypes the highest max holds per record is used. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6852] Staged import reports wrong success for items with false branchcode
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '16

08 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6852 --- Comment #5 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Owen Leonard from comment #3) > This is still valid in master. In my test I had a record with 7 items, the > first of which was invalid. No items were imported. This is not what I experienced. I tested one record with two items. One item had a wrong branchcode and was not imported. But the other item was imported. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6852] Staged import reports wrong success for items with false branchcode
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '16

08 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6852 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6041 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0