September 2016 - Koha-bugs - lists.koha-community.org

[Bug 6041] Errors from _koha_modify_item are ignored in ModItem (C4/Items)
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '16

08 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6041 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6852 --- Comment #2 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Similar comment can be made for _koha_new_item in AddItem. See bug 6852 that may present a fix for the new item case. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6852] Staged import reports wrong success for items with false branchcode
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '16

08 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6852 --- Comment #4 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 55330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55330&action=ed… Bug 6852: Preliminary test -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '16

08 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #40 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Alex Sassmannshausen from comment #38) > Hi Jonathan, > > I think it is used in HouseboundProfile.pm->housebound_visits. Yes it is! I have misread the git grep output. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '16

08 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #39 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- members/housebound.pl should not die but display an error message instead :) t/db_dependent/Patron/Borrower_*.t should be moved to /db_dependent/Patron/*.t I'd say -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '16

08 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #38 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Hi Jonathan, I think it is used in HouseboundProfile.pm->housebound_visits. I'll join IRC now for easier comms if you have any questions. Alex -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '16

08 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #37 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- 50 sub chooser { 51 my ( $self ) = @_; 52 return $self->_result->chooser_brwnumber; 53 } should be sub chooser { my ( $self ) = @_ my $rs = $self->_result->chooser_brwnumber; return Koha::Patron->_new_from_dbic( $rs ); } See bug 17094. And then you can remove the TODO in the tests :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '16

08 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #36 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Koha::Patron::HouseboundVisits->special_search is not used anywhere in the code, should be removed? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '16

08 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #35 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Cheers for looking at this Chris — glad to see it still applies :-) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '16

08 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54384|0 |1 is obsolete| | --- Comment #34 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 55326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55326&action=ed… Bug 5670: Housebound Readers Module New module to handle management of circulation to Housebound readers. - Ability to create housebound profiles & scheduled visits for patrons. - Ability to record users as Deliverers or Choosers (or both), using extended patron attributes. - Ability to link choosers and deliverers to individual delivery runs. - 'Delivery Frequencies' are customizable through authorised values ('HSBND_FREQ'). * koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc: add Housebound menu if appropriate. * Koha/Patron.pm (housebound_profile): New method. * Koha/Patrons.pm (housebound_choosers, housebound_deliverers): New methods. * Koha/Patron/HouseboundProfile.pm: New File. * Koha/Patron/HouseboundProfiles.pm: New File. * Koha/Patron/HouseboundVisits.pm: New File. * Koha/Patron/HouseboundVisit.pm: New File. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: New file. * members/housebound.pl: New file. * installer/data/mysql/kohastructure.sql: Add housebound_* tables. * installer/data/mysql/sysprefs.sql: Add HouseboundModule syspref. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: Add HouseboundModule syspref. * installer/data/mysql/atomicupdate/housebound_tables.sql: New file. * t/db_dependent/Patron/Borrower_Housebound.t: New file. * t/db_dependent/Patron/Borrower_HouseboundProfiles.t: New file. * t/db_dependent/Patron/Borrower_HouseboundVisits.t: New file. Test plan: - Apply patch. - Run atomic update script. - Run Unit Tests (t/db_dependent/Patron/Housebound*) - Optionally, add additional authorised values to 'HSBND_FREQ'. - Switch on 'HouseboundModule' syspref. - Ensure 'ExtendedPatronAttributes syspref is on. - On patron pages, when editing, add some to the Housebound deliverer and chooser groups by setting their extended attributes. - On a patron page, the Housebound menu should now be present. - create housebound profile + ensure Frequency values seem pulled from 'HSBND_FREQ'. - create 'housebound visits' (deliveries) + ensure chooser/deliverer lists are populated with patrons that have the Chooser or Deliverer Attribute type. - edit visits. - delete visits. - Switch off 'HouseboundModule' - the Housebound menu should disappear Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 08 Sep '16

08 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0