September 2016 - Koha-bugs - lists.koha-community.org

[Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions)
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '16

30 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55952|0 |1 is obsolete| | --- Comment #12 from Marc Véron <veron(a)veron.ch> --- Created attachment 55964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55964&action=ed… Bug 6782 - Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions). Currently the card number is generated when the user enters the patron creation form. This creates a problem of concurrency - when two or more simulataneous users are registering members, the error "card no. in use" can occur. This change moves the card number generation to occur after the "Save" button is pressed. Changes: -C4/Members.pm: Added code to fixup_cardnumber,If the cardnumber is blank and "autoMemberNum" ON. -koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: Added code to display "leave blank for auto calc during registration" in cardnumber label in patron registration form only if "autoMemberNum" ON. -members/memberentry.pl: Added code to get weather or not "autoMemberNum" is on or off and removed fixup_cardnumber generation. Test cases: -If "autoMemberNum" ON: ->In blank case, must generate auto card number in simulataneous users. ->If user entered, check for unique card number. -If "autoMemberNum" OFF: Must work normal. Followed test plan, works as expected. Note: Syspref PorrowerMandatoryField must not include cardnumber, otherwise you can not save. Maybe that should be mentioned in the comment for syspref autoMemberNum. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3707] Add system preference for customization of the OPAC login page
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '16

30 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3707 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15503] Grab Item Information from Order Files
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '16

30 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #31 from Kyle M Hall <kyle(a)bywatersolutions.com> --- I hereby withdraw my 'loc' and 'itemprice' comments! I should have read the code more closely. It would be better if all the terms matched up, but they *do* work. I can also understand the difficulty of making this work in an abstract way, especially for the view layer. I would still like to see itemcallnumber implemented. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15503] Grab Item Information from Order Files
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '16

30 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #30 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Maybe this is asking too much, but why use a hard coded list of item fields instead of abstracting it so that any set of arbitrary item fields could be given in MarcItemFieldsToOrder? As I wrote earlier, it seems like typos from the spec were hard-coded into the patch ( e.g. loc vs location ). If the code were abstracted so the fields aren't hard coded, this wouldn't be an issue. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16692] New: Error "No method update!" when creating new serial issue
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '16

30 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16692 Bug ID: 16692 Summary: Error "No method update!" when creating new serial issue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com An improper method call was left over in C4::Serials::NewIssue from the switch from DBIx::Class to Koha::Object. Test Plan: 1) prove t/db_dependent/Serials.t 2) Note the errors 3) Apply this patch 4) prove t/db_dependent/Serials.t 5) No errors! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 15503] Grab Item Information from Order Files
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '16

30 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #29 from Benjamin Daeuber <bdaeuber(a)cityoffargo.com> --- (In reply to Kyle M Hall from comment #28) > I see the same issue with 'itemprice'. There is no itemprice column in the > db, it would support the price and replacementprice fields instead! Just to echo what Kyle said, price and replacement price would be very helpful, as otherwise replacement price would need to be manually updated (price being what we paid, replacement price being what's charged to the customer when the item is lost or damaged). Really mapping anything in the item record is welcome, but call number, price and replacement price are definitely data we might get from a vendor in an order file. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5269] link to patron edit form when editing turned off
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '16

30 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5269 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14899] Mapping configuration page for Elastic search
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '16

30 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55918|0 |1 is obsolete| | --- Comment #33 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 55960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55960&action=ed… Bug 14899: Add a reset option For developpers only at the moment, if you want to reset your mappings, you can hit: admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14899] Mapping configuration page for Elastic search
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '16

30 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55917|0 |1 is obsolete| | --- Comment #32 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 55959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55959&action=ed… Bug 14899: Add a link to the new page in the admin Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14899] Mapping configuration page for Elastic search
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '16

30 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55916|0 |1 is obsolete| | --- Comment #31 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 55958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55958&action=ed… Bug 14899: Add the mapping configuration page in the admin module This new page (admin/searchengine/elasticsearch/mappings.pl) will permit to manage the ES mappings. For the biblios and authorities indexes, the different mappings can be managed from this single page. The interface let you add, remove and update mappings and search fields. It's also possible to reorder the mappings, as the order can be important in the indexation process. Note that the table can be displayed in a different order that the one it was before saving, but the mappings are grouped by search field and the order inside the search field is preserved. Limitations: - If something went wrong during the insertion/deletion/modification, the users will loose all these changes. TODO: - Add a specific permission (?) - Add some data checks client side (JS) - Use checkboxes for facet and suggestible (lazy today...) - Understand the difference between the 3 values that sortable can have and improve the value for the options in the select box. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0