September 2016 - Koha-bugs - lists.koha-community.org

[Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions)
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '16

30 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Revived patch, tests will need to be provided for changes to C4::Members::AddMember, but everything is testable. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions)
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '16

30 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10625|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 55952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55952&action=ed… Bug 6782 - Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions). Currently the card number is generated when the user enters the patron creation form. This creates a problem of concurrency - when two or more simulataneous users are registering members, the error "card no. in use" can occur. This change moves the card number generation to occur after the "Save" button is pressed. Changes: -C4/Members.pm: Added code to fixup_cardnumber,If the cardnumber is blank and "autoMemberNum" ON. -koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: Added code to display "leave blank for auto calc during registration" in cardnumber label in patron registration form only if "autoMemberNum" ON. -members/memberentry.pl: Added code to get weather or not "autoMemberNum" is on or off and removed fixup_cardnumber generation. Test cases: -If "autoMemberNum" ON: ->In blank case, must generate auto card number in simulataneous users. ->If user entered, check for unique card number. -If "autoMemberNum" OFF: Must work normal. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions)
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '16

30 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17056] New: Remove event attributes from various templates
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '16

30 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17056 Bug ID: 17056 Summary: Remove event attributes from various templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org I'm working on a patch which will remove event attributes from the following templates: catalogue/MARCdetail.tt catalogue/labeledMARCdetail.tt offline_circ/process_koc.tt reports/guided_reports_start.tt -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 16519] New: Do not use global variables in [opac-]addbybiblionumbers.pl
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '16

30 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16519 Bug ID: 16519 Summary: Do not use global variables in [opac-]addbybiblionumbers.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 16517, 16518 To avoid bug like bug 16518 and to ease the readability/maintainability of these scripts, it would be great to see them rewritten not to use global variables. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16517 [Bug 16517] A server error is raised when creating a new list with an existing name https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16518 [Bug 16518] opac-addbybiblionumber is not plack safe -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 6271] GetItemIssue(s) : renewals in both items and issues tables
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '16

30 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6271 --- Comment #10 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- GetItemIssue has been fixed by commit 5b4752e027ce32492166c7018d44d4a687afae36 Bug 8365: FIX Return issue values instead of item values GetItemIssues is still buggy, but the only place 'renewals' is used is in catalogue/issuehistory.tt: [% IF ( issue.renewals ) %] And it happens only if the itemnumber parameter is passed to the script. However this parameter is never passed from Koha. That means we could remove the subroutine GetItemIssues as well as the related code in the pl and tt. Would you agree to remove it? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 9896] Show vendor in subscription search when creating an order for a subscription
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '16

30 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9896 Frédéric Demians <frederic(a)tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic(a)tamil.fr --- Comment #8 from Frédéric Demians <frederic(a)tamil.fr> --- Pushed in 16.05. Will be in 16.05.05. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17331] New: Show holding branch in holds awaiting pickup report
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '16

30 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17331 Bug ID: 17331 Summary: Show holding branch in holds awaiting pickup report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Currently waitingreserves.pl shows an items homebranch plus callnumber as 'location' When viewing all libraries this information is confusing and on the 'holds over' tab the location is missing a <br /> tag so the info can appear oddly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 9

[Bug 17304] New: C4::Matcher::_get_match_keys is not tested
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '16

30 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17304 Bug ID: 17304 Summary: C4::Matcher::_get_match_keys is not tested Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: tomascohen(a)gmail.com QA Contact: gmcharlt(a)gmail.com This function is used in several places, but it's behaviour is not covered by tests, thus trying to patch it can be problematic without introducing regressions. -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 30 Sep '16

30 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #101 from Sebastian Hierl <s.hierl(a)aarome.org> --- Just a brief note to confirm that we are also very interested in harvesting records via OAI-PMH. This mainly to update Koha with records from our ArchivesSpace implementation, but also beyond. Sebastian -- You are receiving this mail because: You are watching all bug changes.

1 0