September 2016 - Koha-bugs - lists.koha-community.org

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 29 Sep '16

29 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #69 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- oh, I might have misread - chooser and deliverer would also each link to a borrowernumber. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 29 Sep '16

29 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #68 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Wondering, could be chooser and deliverer be the same person? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 29 Sep '16

29 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #67 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Alex Sassmannshausen from comment #66) > (In reply to Jonathan Druart from comment #65) > > (In reply to Jonathan Druart from comment #64) > > > > My alternative proposal now would be: > > > > - create a new custom table "housebound_role" > > > > - with three columns (borrower_id, deliverer, chooser) > > > > The PK for this new table would be borrower_id, so should not it be 2 new > > columns in the borrowers table instead? > > I considered that, but proposed a new table because: > - the borrowers table is quite large as it is. Adding columns to it would > make it slightly less discoverable > - the vast majority of borrowers in the system will have neither a > "deliverer" nor a "chooser" role, so those columns will just be empty/false > in the borrowers table (this is particularly the case if the housebound > module is switched off!). > - in the housebound_role table the columns will only exist if the borrower > is in fact a volunteer of some form (either chooser or deliverer), so each > entry will be "doing something". > > Conversely, joins are quite cheap, so I think I prefer this design. My concern is more about the DB normalization, I think we need to keep that in mind and normalize it as much as possible to keep data integrity. I'd like to get more opinions before you start. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 14899] Mapping configuration page for Elastic search
by bugzilla-daemon＠bugs.koha-community.org 29 Sep '16

29 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14899] Mapping configuration page for Elastic search
by bugzilla-daemon＠bugs.koha-community.org 29 Sep '16

29 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17372 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17372 [Bug 17372] Elasticsearch paths need to be standardized -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12478] Elasticsearch support for Koha
by bugzilla-daemon＠bugs.koha-community.org 29 Sep '16

29 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17372 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17372 [Bug 17372] Elasticsearch paths need to be standardized -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 29 Sep '16

29 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #66 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- (In reply to Jonathan Druart from comment #65) > (In reply to Jonathan Druart from comment #64) > > > My alternative proposal now would be: > > > - create a new custom table "housebound_role" > > > - with three columns (borrower_id, deliverer, chooser) > > The PK for this new table would be borrower_id, so should not it be 2 new > columns in the borrowers table instead? I considered that, but proposed a new table because: - the borrowers table is quite large as it is. Adding columns to it would make it slightly less discoverable - the vast majority of borrowers in the system will have neither a "deliverer" nor a "chooser" role, so those columns will just be empty/false in the borrowers table (this is particularly the case if the housebound module is switched off!). - in the housebound_role table the columns will only exist if the borrower is in fact a volunteer of some form (either chooser or deliverer), so each entry will be "doing something". Conversely, joins are quite cheap, so I think I prefer this design. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 14876] Show number of holds per record on the search results
by bugzilla-daemon＠bugs.koha-community.org 29 Sep '16

29 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55892|0 |1 is obsolete| | --- Comment #18 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 55910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55910&action=ed… Bug 14876 - Show number of holds per record on the search results This patch edits catalogue/search.pl to pass back the count of holds along with other data for display in results.tt To test: 1 - Search in staff 2 - Note holds link has no extra information 3 - Apply patch 4 - Do search in staff that returns records with some holds (i.e. place some holds) 5 - Note the number of holds now displays next to the text of the link: Holds (#) Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 29 Sep '16

29 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #65 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #64) > > My alternative proposal now would be: > > - create a new custom table "housebound_role" > > - with three columns (borrower_id, deliverer, chooser) The PK for this new table would be borrower_id, so should not it be 2 new columns in the borrowers table instead? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 29 Sep '16

29 Sep '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #64 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Alex Sassmannshausen from comment #63) > (In reply to Jonathan Druart from comment #62) > > (In reply to Alex Sassmannshausen from comment #61) > > > > Same for HSBND_ROLE, it seems that another value is not taken into account > > > > completely. It appears when editing a patron, but not on the housebound > > > > details. What is the use case exactly? > > > > > > You should find that HSBND_ROLE appears when creating an individual > > > housebound_visit. Any patrons tagged as chooser or deliverer will then > > > appear as values which can be selected in the chooser and deliverer > > > dropdowns in the edit/create visit screen. > > > > Ok but what could be a third value? What could be a third value and how it > > is supposed to behave? > > Thinking about this some more last night, it feels like the current design > is not appropriate. You're quite right asking whether there could be third > values, and the answer is there cannot. The UI expects there to be only two > values. > > My alternative proposal now would be: > - create a new custom table "housebound_role" > - with three columns (borrower_id, deliverer, chooser) > - remove the current dependency on extended patron attributes > - remove HSBND_ROLE authorised values > > So within this approach, I reduce complexity (no extended attributes, fewer > authorised values), and confirm that housebound roles are not supposed to be > extensible. > > WDYT? Yes, I think that it makes more sense and will be less confusing for developers and users. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0