January 2017 - Koha-bugs - lists.koha-community.org

[Bug 14764] Add OPAC News branch selector
by bugzilla-daemon＠bugs.koha-community.org 30 Jan '17

30 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57110|0 |1 is obsolete| | --- Comment #36 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 59648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59648&action=ed… [SIGNED-OFF] Bug 14764: OPAC news selector Test plan: 1) Add more than one library, at least two in total is needed. Make note of which is your current user's home branch. 2) Go to Tools -> News and add one global ("All") news item and one specific for each branch. 3) Apply the patches. 4) Perform database upgrades when you log in. 5) Go to OPAC main, it should work as before: Showing global news as well as the news for your home branch once logged in. 6) Go to System Preferences -> OPAC and set 'OPACNewsBranchSelect' to yes. 7) Go to OPAC main, you should see the global news item plus any items for your home branch for the current user if logged in. 8) Above the news, you will see a dropdown that lists the branches. Select one, and click "Change library." 9) You should now see global news and the news for the selected branch, regardless of whether logged in or not. Sponsored-By: Halland County Library Fixes QA comments: * Keep the current selected branch selected * Change OPACNewsBranchSelect -> OPACNewsLibrarySelect * fix 'system wide only' view for logged in user. We still show system wide even when a library is selected. * Removed the "change library" link * Added a label to the field. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14764] Add OPAC News branch selector
by bugzilla-daemon＠bugs.koha-community.org 30 Jan '17

30 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication
by bugzilla-daemon＠bugs.koha-community.org 30 Jan '17

30 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 --- Comment #9 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Thx! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication
by bugzilla-daemon＠bugs.koha-community.org 30 Jan '17

30 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 --- Comment #8 from Oliver Bock <oliver.bock(a)aei.mpg.de> --- Sorry, I thought the description was clear enough. Ok, let's see: 1) Create an extended patron attribute (that exists in LDAP) 2) Map that attribute in your LDAP auth config 3) Log in (first replication, should give no error in OPAC log) 4) Log out 5) Update attribute in LDAP 6) Log in 7) Error (see first comment) should be visible in OPAC log -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication
by bugzilla-daemon＠bugs.koha-community.org 30 Jan '17

30 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 --- Comment #7 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Oliver, testing steps can also be a "step by step" on how to reproduce the error. 1) go to the login page 2) enter... ... and so on. This makes it easier for people to understand the problem and test your code. Given the number of devs and Koha's age, we might not be able to find the original developer :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication
by bugzilla-daemon＠bugs.koha-community.org 30 Jan '17

30 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 --- Comment #6 from Oliver Bock <oliver.bock(a)aei.mpg.de> --- Not really, unfortunately. I'm not a Koha dev so I don't know anything about the unit test framework you use. Also, my patch was just meant as a proposal: it works for us but it should certainly be vetted (fixed/improved?) by the original author of that code section. Thanks, Oliver -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
by bugzilla-daemon＠bugs.koha-community.org 30 Jan '17

30 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52704|0 |1 is obsolete| | --- Comment #34 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Created attachment 59643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59643&action=ed… Bug 15261: Verify if checkouts/reserves requests periods overlap... ... with existing reserves When checking out or placing hold, we should check if an existing reserve whose period overlap exists. A user place an hold from opac whose requested period overlap an existing reserve period => prevent reserve, A librarian place an hold from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation), A librarian make a checkout from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation). Test plan: Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod 1 (staff side): Place a hold on title (which has only one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are warned about an existing reserve 2 (staff side): Place a hold on title (which has more than one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are NOT warned about an existing reserve. Because it remains at least one item not reserved. 3 (staff side): Place a hold on item level with start date and expiration date. Place another hold on item level with period overlaping this reserve. Check you are warned about an existing reserve. 4 (opac side): Do the same than for staff side. Instead of a warn, reserve is prevented. 5: Place a hold on title (which has only one items) level with start date and expiration date. Try to checkout the unique item from this title with period overlaping the reserve period. Check you are warned about an existing reserve 6: Place a hold on title (which has more than one items) level with start date and expiration date. Checkout an item from this title with period overlaping the reserve period. Check you are NOT warned about an existing reserve. 7: Place a hold on item level with start date and expiration date. Checkout this item period overlaping the reserve period. Check you are warned about an existing reserve Rabased on master Rebased on master (2016-06-23) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 30 Jan '17

30 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59637|0 |1 is obsolete| | --- Comment #49 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 59641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59641&action=ed… [SIGNED-OFF] Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summary" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Patch adds syspref "AllowIssueNotes" - default off. Test Plan: 1) Apply this patch 2) Update database 3) Rebuild schema 4) Turn on 'AllowIssueNote' syspref 5) Check out three different items to a borrower (may be easiest to check out to yourself) 6) Log in as that borrower (or yourself) on the OPAC side and go to your summary 7) Confirm text field shows under Note column for all checkouts. Set a note for each issue, confirm all save. 8) Check the message_queue in mysql for the entries for ALL THREE issue notes. 9) Disable javascript in your browser 10) Refresh your summary page. Confirm that you can no longer edit the notes in the text field. Click the 'Create/edit note' button and confirm you are redirected to a new page. 11) Confirm that the correct title and author show for the note button you clicked. 12) Set the note and click Submit -> confirm you are redirected back to summary page and note is saved 13) Confirm there is a new entry in message_queue 14) Enable javascript and go back to the your checkouts page in the staff client for the borrower you issued the items to 15) Check in TWO items 16) Confirm that the issue notes show under the "Date due" column for the two items you checked in, and are accurate to the item (i.e. the right issue note under the right item) 17) Go to circ/returns.pl and check in the final item using the barcode. Confirm the issue note shows and the date is formatted correctly. Sponsored-by: Region Halland Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 30 Jan '17

30 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 30 Jan '17

30 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #48 from Josef Moravec <josef.moravec(a)gmail.com> --- Ad 3) Rebuild schema Change for for table issues are in your patch, but for old_issues not - probably better to be consistant here, just for more convinience testing. But not reason to fail the patch -- You are receiving this mail because: You are watching all bug changes.

1 0