January 2017 - Koha-bugs - lists.koha-community.org

[Bug 16376] New: Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '17

29 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 Bug ID: 16376 Summary: Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Koha::Calendar->is_holiday calls the following DateTime truncate method: $localdt->truncate( to => 'day' ); This will truncate 2015-09-06 12:00:00 down to 2015-09-06 00:00:00. This causes major problems in Santiago, Chile, because 2015-09-06 is an invalid local time due to DST. I can't explain why it's a problem in 2015 because DST is weird in Chile in 2015, but it's obviously a problem for every other year as well: http://www.timeanddate.com/time/change/chile/santiago?year=2015 Consider 2014: 2014 Sunday, 27 April, 12:00 Midnight Sunday, 7 September, 12:00 Midnight You shouldn't have a problem on 27 April, because when 27 April 12:00 midnight hits (relative to UTC), local time is changed to 27 April 11:00pm. While UTC marches on, local time has been magically moved back an hour. You will have a problem on 7 September 12:00 midnight though, because that time doesn't exist. As soon as we roll over from 6 September 11:59pm to the next minute... we're actually on to 7 September 01:00:00am. Midnight doesn't exist on that day, which creates the following error in DateTime.pm: "Invalid local time for date in time zone: America/Santiago" This is a problem that the DateTime writer predicted. You can see their comments here: http://cpansearch.perl.org/src/DROLSKY/DateTime-1.26/lib/DateTime.pm https://rt.cpan.org/Public/Bug/Display.html?id=93347 We should probably do something like: eval { $dt->truncate(to => 'day'); } || warn "Eval failed with '$@'\n"; Why are we even doing this day truncation? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 41

[Bug 17513] New: koha-create does not set GRANTS correctly
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '17

29 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513 Bug ID: 17513 Summary: koha-create does not set GRANTS correctly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org There is a behavior change between MySQL and MariaDB: With: CREATE DATABASE koha_kohadev; CREATE USER koha_kohadev@localhost IDENTIFIED BY 'password'; CREATE USER koha_kohadev@'%' IDENTIFIED BY 'password'; GRANT ALL PRIVILEGES ON koha_kohadev.* TO koha_kohadev; Using Mysql, as admin user: mysql> SHOW GRANTS FOR koha_kohadev@'localhost'; GRANT USAGE ON *.* TO 'koha_kohadev'@'localhost' IDENTIFIED BY PASSWORD '*2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19' mysql> SHOW GRANTS FOR koha_kohadev; GRANT USAGE ON *.* TO 'koha_kohadev'@'%' IDENTIFIED BY PASSWORD '*2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19' GRANT ALL PRIVILEGES ON `koha_kohadev`.* TO 'koha_kohadev'@'%' Using Mysql, as koha_user user: mysql> SHOW GRANTS FOR koha_kohadev@'localhost'; GRANT USAGE ON *.* TO 'koha_kohadev'@'localhost' IDENTIFIED BY PASSWORD <secret> mysql> SHOW GRANTS FOR koha_kohadev; GRANT USAGE ON *.* TO 'koha_kohadev'@'%' IDENTIFIED BY PASSWORD <secret> GRANT ALL PRIVILEGES ON `koha_kohadev`.* TO 'koha_kohadev'@'%' Using MariaDB, as admin user: MariaDB [(none)]> SHOW GRANTS FOR kohaçkohadev@localhost; GRANT USAGE ON *.* TO 'koha_kohadev'@'%' IDENTIFIED BY PASSWORD '*'2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19 MariaDB [(none)]> SHOW GRANTS FOR kohaçkohadev; GRANT USAGE ON *.* TO 'koha_kohadev'@'%' IDENTIFIED BY PASSWORD '*'2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19 GRANT ALL PRIVILEGES ON `koha_kohadev`.* TO 'koha_kohadev'@'%' So all the same so far :) But, Using MariaDB, as koha_user user: MariaDB [(none)]> SHOW GRANTS FOR kohaçkohadev@localhost; GRANT USAGE ON *.* TO 'koha_kohadev'@'%' IDENTIFIED BY PASSWORD '*'2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19 MariaDB [(none)]> SHOW GRANTS FOR kohaçkohadev; ERROR 1044 (42000): Access denied for user 'koha_kohadev'@'localhost' to database 'mysql' BOOM! The installer does not parse the expected output and then raise an error. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 17660] New: Field 773 $t not editable in any framework
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '17

29 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17660 Bug ID: 17660 Summary: Field 773 $t not editable in any framework Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: mik(a)adminkuhn.ch QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Trying to change a copy of the standard framework. To catalogue sets with volumes MARC field 773 needs to be unhided in the framework. It is no problem to unhide 773 $w by clicking on "Advanced constraints" and marking the field "Editor", the click "Save changes". But also $t (for the title) is needed. There, when clicking on "Advanced constraints", nothing happens, so the tab will not open to mark the field "Editor". Instead, if "Basic constraints" is open, it will close "Basic constraints", but still "Advanced constraints" will not open. It was possible to export the framework and edit the XML file... in the part of the XML file decribing field 773 $t I found some characters like this: <ss:Data ss:Type="Number">-6</ss:Data> and I replaced them by <ss:Data ss:Type="Number">0</ss:Data> Now the behaviour while editing of the framework is still as described above (tab "Advanced constraints" won't open). But when actually using the framework during catalogueing, the MARC field 773 is there with both configured subfields $t and $w. I don't know why the exported XML file has around 4.4 million characters but only 28 lines - this makes it VERY painful to edit this file with an editor like vi. I would prefer a more structured file with more lines that are actually editable. -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 15029] Tests fail if launched after 23:00
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '17

29 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18009 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18009 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18009 [Bug 18009] IssueSlip.t test fails if launched between 00:00 and 00:59 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17310] New: Broken URLs in 'Item renewed' / 'Cannot renew' messages
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '17

27 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17310 Bug ID: 17310 Summary: Broken URLs in 'Item renewed' / 'Cannot renew' messages Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: arouss1980(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Description of the problem: In the Staff client, under Circulation > Renew, the message shown after successful renewal of an item contains broken URLs like these: /cgi-bin/koha/catalogue/detail.pl?biblionumber=Koha::Schema::Result::Biblio=HASH(0x7714d88) /cgi-bin/koha/catalogue/moredetail.pl?itemnumber=7&biblionumber=Koha::Schema::Result::Biblio=HASH(0x7714d88)&bi=1286#item7 This is also true for the message shown when you try to renew an item that is not checked out. Valid in latest stable (v16.05.03) and in the current master (0254fd7). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 12

[Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '17

27 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #33 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- (In reply to Fridolin SOMERS from comment #32) > Change in C4/Installer/PerlDependencies.pm is useless I think I think you are right Frido -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4126] bulkmarcimport.pl allows -b and -a to be specified simultaneously
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '17

27 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4126 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58833|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 59618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59618&action=ed… Bug 4126 - Exit bulkmarcimport if -a and -b given Currently it is possible to spceify both --biblios and --authorities as command line switches to bulkmarcimport.pl. This does not make sense so we should exit early and explain that these switches are mutually exclusive. To test: - Run one of these and check that there is no complaint about missing options: perl misc/migration_tools/bulkmarcimport.pl -a -b sudo koha-shell -c "perl misc/migration_tools/bulkmarcimport.pl -a -b" kohadev - Observe that this displays the perldoc, but does not complain about mutually exclusive switches. - Apply the patch - Rerun the command(s) from earlier. - Verify that the script is now halted and a small explanation given. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4126] bulkmarcimport.pl allows -b and -a to be specified simultaneously
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '17

27 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4126 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 15280] Switch default CHECKOUT notice to Template Toolkit
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '17

27 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 --- Comment #15 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #14) > (In reply to Jonathan Druart from comment #13) > > I think that this patch should not be pushed before bug 17964. > > There is no direct connection? These patches do a simple change to the > default notice that works and only depends on biblio and branch, not issues. They prove that CHECKIN and CHECKOUT work and will still work if a change is done in template processing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15030] Certain values in serials' items are lost on next edit
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '17

27 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #35 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Critical bug, can we get this moving again? We had another report for barcode going missing when editing from the serials module. That's bad. -- You are receiving this mail because: You are watching all bug changes.

1 0