January 2017 - Koha-bugs - lists.koha-community.org

[Bug 9594] order item subfields in framework
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9594 --- Comment #2 from Marjorie Barry-Vila <marjorie.barry-vila(a)ccsr.qc.ca> --- +1 Marjorie -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7654] Add location at opac subscription view
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 --- Comment #23 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to M. Tompsett from comment #22) > Comment on attachment 58869 [details] [review] > Bug 7654: Add location at opac subscription view > > Review of attachment 58869 [details] [review]: > ----------------------------------------------------------------- > > Here are some untested thoughts. :) > > ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt > @@ +796,4 @@ > > <p>There are [% subscriptionsnumber %] subscription(s) associated with this title.</p> > > [% FOREACH subscription IN subscriptions %] > > [% IF ( subscription.branchcode ) %] > > + <h3>At library: [% Branches.GetName( subscription.branchcode ) %]</h3> > > What if it gets a branch, but someone failed to enter a description or it is > blank? Displaying the branchcode in that case would make sense. I do not > think this correction is correct. That's actually not a problem. The branchcode and branchname are both mandatory. It's not possible to have a branch without a branchname in Koha. Using the TT plugin like this is common in Koha. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7654] Add location at opac subscription view
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 --- Comment #22 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 58869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58869 Bug 7654: Add location at opac subscription view Review of attachment 58869: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=765…) ----------------------------------------------------------------- Here are some untested thoughts. :) ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ +796,4 @@ > <p>There are [% subscriptionsnumber %] subscription(s) associated with this title.</p> > [% FOREACH subscription IN subscriptions %] > [% IF ( subscription.branchcode ) %] > + <h3>At library: [% Branches.GetName( subscription.branchcode ) %]</h3> What if it gets a branch, but someone failed to enter a description or it is blank? Displaying the branchcode in that case would make sense. I do not think this correction is correct. [% at_library = Branches.GetName( subscription.branchcode ) %] [% SET at_library = subscription.branchcode IF at_library.length=0 %] [% IF at_library %] <h3>At library: [% at_library ) %]</h3> [% END %] @@ -799,5 @@ > - <h3>At library: [% Branches.GetName( subscription.branchname ) %]</h3> > - [% ELSE %] > - [% IF ( subscription.branchcode ) %] > - <h3>At library: [% subscription.branchcode %]</h3> > - [% END %] I'm pretty sure this code was intending to display a branch name if possible, but if not just the branch code. And clearly, it is wrong about that. @@ +813,5 @@ > <p>[% subscription.opacnote FILTER html_line_break %]</p> > [% END %] > + [% IF subscription.location_description || subscription.location %] > + <p>Location: [% IF subscription.location_description %][% subscription.location_description %][% ELSE %][% subscription.location %][% END %]</p> > + [% END %] [% location_description = subscription.location_description %] [% SET location_description = subscription.location IF ! defined location_description || location_description.length=0 %] [% IF location_description %] <p>Location: [% location_description %]</p> [% END %] -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5250] Various enhancements to web based checkouts
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5250 Agnes Rivers-Moore <arm(a)hanover.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm(a)hanover.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13146] Improve GetRecordValue function by caching field mapping
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13146 --- Comment #8 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 44132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44132 Bug 13146 UT Review of attachment 44132: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=131…) ----------------------------------------------------------------- Test::DBIx::Class isn't required to run Koha, just the tests, correct? Probably should skip tests we know we can't run. This will run fine on kohadevbox, but not necessarily on another users koha git box. ::: t/db_dependent/FieldMapping.t @@ +21,5 @@ > +use File::Basename; > +use File::Path; > +use DateTime; > +use Test::MockModule; > +use Test::More tests => 18; Just use Test::More; because of suggested change below. @@ +25,5 @@ > +use Test::More tests => 18; > +use C4::Biblio; > +use Koha::Schema; > + > + use Module::Load::Conditional qw/check_install/; BEGIN { if ( check_install( module => 'Test::DBIx::Class' ) ) { plan tests => 18; # or is it 19... whatever works. } else { plan skip_all => "Need Test::DBIx::Class" } } @@ +43,5 @@ > + _new_schema => sub { return Schema(); } > +); > + > + > +if (0) { What is the point of keeping the code, if it isn't run? @@ +55,5 @@ > +} > + > + > +SetFieldMapping('', 'maintitle', '245', 'a'); > +ok my $fm = Fieldmapping->find( {field => 'maintitle'} ) Multiple side-effects on the same line of code is more difficult to read. @@ +56,5 @@ > + > + > +SetFieldMapping('', 'maintitle', '245', 'a'); > +ok my $fm = Fieldmapping->find( {field => 'maintitle'} ) > + => 'maintitle field mapping properly set for default framework'; While this is valid, given that you did the simpler version of is() below, could this not be: my $fm = Fieldmapping->find( {field => 'maintitle'} ); ok( defined $fm, 'maintitle field mapping properly set for default framework'); instead? This is more readable. @@ +60,5 @@ > + => 'maintitle field mapping properly set for default framework'; > + > +SetFieldMapping('', 'subtitle', '245', 'b'); > +ok $fm = Fieldmapping->find( {field => 'subtitle'} ) > + => 'subtitle field mapping properly set for default framework'; same here. @@ +70,5 @@ > +}, 'expected fields are there'; > + > +SetFieldMapping('BOOK', 'subtitle', '245', 'b'); > +ok $fm = Fieldmapping->find( {frameworkcode => 'BOOK', field => 'subtitle'} ) > + => 'subtitle field mapping properly set for BOOK framework'; same here. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17813 |17234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 [Bug 17813] Table borrower_attributes needs a primary key -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17813 CC| |tomascohen(a)gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 [Bug 17813] Table borrower_attributes needs a primary key -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58880|0 |1 is obsolete| | --- Comment #19 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 58882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58882&action=ed… Bug 14187: (QA followup) Properly check DB structure before altering it Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58730|0 |1 is obsolete| | --- Comment #18 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 58881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58881&action=ed… Bug 14187: branchtransfer needs a primary key (id) for DBIx and common sense. * C4/Circulation.pm (GetTransfers, GetTransfersFromTo): Also return branchtransfer_id in return columns. * installer/data/mysql/atomicupdate/14187.perl: New file. * installer/data/mysql/kohastructure.sql: Modify branchtransfers structure. * t/db_dependent/Circulation/transfers.t: Update tests to expect branchtransfer_id. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Test plan successful on all steps. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Amended patch: Remove Schema changes from this patch Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 --- Comment #17 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 58880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58880&action=ed… Bug 14187: (QA followup) Properly check DB structure before altering it Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0