January 2017 - Koha-bugs - lists.koha-community.org

[Bug 13146] Improve GetRecordValue function by caching field mapping
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13146 --- Comment #8 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 44132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44132 Bug 13146 UT Review of attachment 44132: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=131…) ----------------------------------------------------------------- Test::DBIx::Class isn't required to run Koha, just the tests, correct? Probably should skip tests we know we can't run. This will run fine on kohadevbox, but not necessarily on another users koha git box. ::: t/db_dependent/FieldMapping.t @@ +21,5 @@ > +use File::Basename; > +use File::Path; > +use DateTime; > +use Test::MockModule; > +use Test::More tests => 18; Just use Test::More; because of suggested change below. @@ +25,5 @@ > +use Test::More tests => 18; > +use C4::Biblio; > +use Koha::Schema; > + > + use Module::Load::Conditional qw/check_install/; BEGIN { if ( check_install( module => 'Test::DBIx::Class' ) ) { plan tests => 18; # or is it 19... whatever works. } else { plan skip_all => "Need Test::DBIx::Class" } } @@ +43,5 @@ > + _new_schema => sub { return Schema(); } > +); > + > + > +if (0) { What is the point of keeping the code, if it isn't run? @@ +55,5 @@ > +} > + > + > +SetFieldMapping('', 'maintitle', '245', 'a'); > +ok my $fm = Fieldmapping->find( {field => 'maintitle'} ) Multiple side-effects on the same line of code is more difficult to read. @@ +56,5 @@ > + > + > +SetFieldMapping('', 'maintitle', '245', 'a'); > +ok my $fm = Fieldmapping->find( {field => 'maintitle'} ) > + => 'maintitle field mapping properly set for default framework'; While this is valid, given that you did the simpler version of is() below, could this not be: my $fm = Fieldmapping->find( {field => 'maintitle'} ); ok( defined $fm, 'maintitle field mapping properly set for default framework'); instead? This is more readable. @@ +60,5 @@ > + => 'maintitle field mapping properly set for default framework'; > + > +SetFieldMapping('', 'subtitle', '245', 'b'); > +ok $fm = Fieldmapping->find( {field => 'subtitle'} ) > + => 'subtitle field mapping properly set for default framework'; same here. @@ +70,5 @@ > +}, 'expected fields are there'; > + > +SetFieldMapping('BOOK', 'subtitle', '245', 'b'); > +ok $fm = Fieldmapping->find( {frameworkcode => 'BOOK', field => 'subtitle'} ) > + => 'subtitle field mapping properly set for BOOK framework'; same here. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17813 |17234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 [Bug 17813] Table borrower_attributes needs a primary key -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17813 CC| |tomascohen(a)gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 [Bug 17813] Table borrower_attributes needs a primary key -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58880|0 |1 is obsolete| | --- Comment #19 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 58882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58882&action=ed… Bug 14187: (QA followup) Properly check DB structure before altering it Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58730|0 |1 is obsolete| | --- Comment #18 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 58881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58881&action=ed… Bug 14187: branchtransfer needs a primary key (id) for DBIx and common sense. * C4/Circulation.pm (GetTransfers, GetTransfersFromTo): Also return branchtransfer_id in return columns. * installer/data/mysql/atomicupdate/14187.perl: New file. * installer/data/mysql/kohastructure.sql: Modify branchtransfers structure. * t/db_dependent/Circulation/transfers.t: Update tests to expect branchtransfer_id. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Test plan successful on all steps. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Amended patch: Remove Schema changes from this patch Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 --- Comment #17 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 58880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58880&action=ed… Bug 14187: (QA followup) Properly check DB structure before altering it Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #4 from Olli-Antti Kivilahti <olli-antti.kivilahti(a)jns.fi> --- (In reply to Benjamin Rokseth from comment #2) > I notice this bug is rather old, but we actually suffered badly from this, > as we have several fully automated branches that are open 24/7 without staff. > They get better with age, like good wine and other stuff. Sorry to hear about your misery. We can completely relate to that :) > Our solution, by any mean not ideal, was to have separated branches for > automated selfcheck machines, a SIP translation proxy that fixes the items > that are NOT reserved so they can be put directly on the shelf, and finally > a cronjob to clean up the branchtransfer mess. > Our self-service libraries are separate branches and strangely I haven't heard of this problem manifesting yet for us, but I know sooner or later someone will notice. > We (Oslo Public Library) would gladly cooperate on this if any good ideas > turn up! You could attach the opening hours of the pickup library in the hold notification? Maybe this would help? Tinker a bit with the Letters-module. The C4::Letters::GetPreparedLetter() is very very hairy tho. Also you would need to add the library opening hours somewhere. Easiest thing to do is to make a YAML-config syspref with those opening hours per branch. Super fast GUI-replacement and will get this problem solved in no time. No need for DB or GUI code. >Instead of an email being sent immediately at that point to the patron next in >line for the request, the item would have a new circulation status e.g. ‘In >SelfService’ this removes the item from the patron’s record but does not >trigger the next hold until it is checked-in by a member of the library, at >which point the item moves onto the next circulation status that it would have >had before going into ‘In SelfService’ (e.g. ‘On hold’ or ‘in transit’ etc.) >However if the limbo-available-state between check-in can be fixed, (this >might be more trouble than it's worth) I guess this would make sense. Maybe this idea is a good solution? Put all SIP2-server checkouts to a Limbo-state Skip catching holds and transfers when put to a 'Limbo'-status? But relinguish ties to the previous borrower. Show in OPAC/Intra the status as Limbo, this is more brittle to program. Shouldn't be too difficult to test and program in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12584] koha-conf.xml for package installations get out of sync
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12584 --- Comment #8 from Magnus Enger <magnus(a)libriotech.no> --- Here is another example. The <server> part of koha-conf.xml got drastically simplified by bug 9612 (in 2014): http://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=etc/koha-conf… But this was never carried over to debian/templates/koha-conf-site.xml.in: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=debian/templates/… -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15165] REST API routes to list, edit and pay borrower's accountlines
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Bug 15165 depends on bug 15897, which changed state. Bug 15897 Summary: Use Koha::Account::pay internally for recordpayment_selectaccts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8306] Patron stats, patron activity : no active doesn't work
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '17

12 Jan '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8306 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Julian Maurice <julian.maurice(a)biblibre.com> --- My test plan: 1. Create a borrower X 2. Check out an item to borrower X 3. Check in the same item 4. Delete borrower X So now, I have an old_issues line with borrowernumber = NULL 5. Go to patron stats, Row = category, Column = library, Patron activity filter = no active ==> no results 6. Apply patch 7. Repeat 5 ==> results! -- You are receiving this mail because: You are watching all bug changes.

1 0