October 2017 - Koha-bugs - lists.koha-community.org

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '17

26 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68548|0 |1 is obsolete| | --- Comment #158 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Created attachment 68563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68563&action=ed… Bug 7317: Overload Koha::Illrequest::TO_JSON This patch implements an overloaded TO_JSON method, that introduces the option to (selectively) embed information required on the REST api. Tests are included for the new method. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Illrequests.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Magnus Enger <magnus(a)libriotech.no> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '17

26 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68547|0 |1 is obsolete| | --- Comment #157 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Created attachment 68562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68562&action=ed… Bug 7317: (QA folowup) 404 if module is disabled (intranet) Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Magnus Enger <magnus(a)libriotech.no> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '17

26 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68546|0 |1 is obsolete| | --- Comment #156 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Created attachment 68561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68561&action=ed… Bug 7317: DO NOT PUSH: Update OPAC CSS Signed-off-by: Magnus Enger <magnus(a)libriotech.no> It's impossible to give a test plan for this... I have implemented a "plugin" for Norwegian ILL (based on NCIP): https://github.com/Libriotech/koha-illbackend-nncipp Several issues have been discovered while writing the plugin, and Alex has fixed them along the way. Currently I do not know about any funcional issues, and I am happy to sign off. I think this is one of those things we need to get into Koha so we can start using it and find any remaining bugs. One non-functional thing that needs to be looked at are the tests. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '17

26 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68545|0 |1 is obsolete| | --- Comment #155 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Created attachment 68560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68560&action=ed… Bug 7317: Interlibrary loans framework for Koha. This Commit is at the heart of adding an interlibrary loans framework for Koha. The framework does not prescribe a particular workflow. Instead it provides a general framework that can be extended & implemented by individual backends whose responsibility it is to implement a specific workflow. The module is largely self-sufficient: it adds new tables to the Koha database and touches only a few files in the Koha source tree. Primarily, we add our files to the Makefile and the koha-conf.xml, define ill paths for the REST API, and introduce links from the main intranet, opac pages & user permissions. Outside of this we simply add new files & functionality. Signed-off-by: Magnus Enger <magnus(a)libriotech.no> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '17

26 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68544|0 |1 is obsolete| | --- Comment #154 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Created attachment 68559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68559&action=ed… Bug 7317: DO NOT PUSH: Updated Schema Files. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '17

26 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68543|0 |1 is obsolete| | --- Comment #153 from Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> --- Created attachment 68558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68558&action=ed… Bug 7317: Add SQL templates & sysprefs. * installer/data/mysql/atomicupdate/ill_tables.sql: New file. * installer/data/mysql/kohastructure.sql: Add tables. * installer/data/mysql/sysprefs.sql: Add sysprefs. * installer/data/mysql/userflags.sql: Add userflags. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add sysprefs to UI. Signed-off-by: Magnus Enger <magnus(a)libriotech.no> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '17

26 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #51 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hm, it didn't work for me until I had changed the frameworkcode this morning - I actually had missed the step at first and then went back to look for a reason why it would not work. I had created a new framework, imported into the empty framework, page relaoded, but it remained empty. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '17

26 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #50 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 68556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68556&action=ed… Bug 13952: [FOLLOW-UP] Fixing JS error Missing a bracket that stopped the export modal from closing after clicking the button. Now fixed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '17

26 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #49 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- (In reply to Katrin Fischer from comment #44) > Hi Aleisha, export is all looking good now. Signing off. > > Not a blocker for me: > > 1) When exporting authority types, the window stays open in the background, > when exporting bibliographic frameworks it closes after clicking the > 'export' button. Will fix this. > > 2) Not a blocker as this is the current behaviour, but maybe something for > the future: > > >6) IMPORTANT STEP: > > Before you import, make sure that the authtypecode of the file you > > are going to import matches the Code of your new authority type. > > Wouldn't it be better to display a warning in the case that the selected > framework for import and the code in the file don't match? It seems like > this could cause some unwanted data loss. I fixed this in Comment 31, you don't have to match up the authtypecode anymore, this step is from an old test plan. For those in the future testing, please use the most recent test plan from Comment 45. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19038] New: Remove OPACShowBarcode syspref
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '17

26 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038 Bug ID: 19038 Summary: Remove OPACShowBarcode syspref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org With bug 16759 there's no need to have a syspref for hiding a specific column that doesn't contain sensitive data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13