October 2017 - Koha-bugs - lists.koha-community.org

[Bug 9031] Overdue items crossing DST boundary throw invalid local time exception
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '17

26 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 --- Comment #21 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Nick, Please confirm that these changes work for you. And the test passes with you too. After that I will pass QA. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9031] Overdue items crossing DST boundary throw invalid local time exception
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '17

26 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9031] Overdue items crossing DST boundary throw invalid local time exception
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '17

26 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 --- Comment #20 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 68578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68578&action=ed… Bug 9031: (QA follow-up) Final changes to Calendar::days_between The crash is caused by comparing two datetimes where one datetime is floating and the other one was not. In that case the floating is converted. Note too that DateTime overloads comparison operators. This patch clones the two dates first. Puts them in floating both. And just after that starts comparing etc. Similar small change in hours_between. Adding a test where the parameters are swapped for days_between. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9031] Overdue items crossing DST boundary throw invalid local time exception
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '17

26 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 --- Comment #19 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 68577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68577&action=ed… Bug 9031: Overdue items crossing DST boundary throw invalid local time exception To test: 1 - Set TZ to America/New York 2 - Checkout item and set due date to '2016-03-09 02:29:00" 3 - Make sure fines are set for the item type, fine mode production, calculate fines on return 4 - Check in item - invalid date time warning in logs 5 - Apply patch 6 - Check in item - no error 7 - prove t/Calendar.t Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Bug 9031: Use floating instead of UTC Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Squashed the changes for Calendar.pm; will add a follow-up to finally overcoming the crash on Invalid local time. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9031] Overdue items crossing DST boundary throw invalid local time exception
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '17

26 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 --- Comment #18 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 68576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68576&action=ed… Bug 9031: (QA follow-up) Pass the same timezone in Calendar.t We do not need to change $ENV{TZ} or call tzset. Pass $tz too for the second date. Replace checking the datetime hash by delta calls. Replacing the number of minutes. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> We will still crash with: Invalid local time for date in time zone: America/New_York But the changes in Calendar.pm will now resolve that. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9031] Overdue items crossing DST boundary throw invalid local time exception
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '17

26 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63718|0 |1 is obsolete| | Attachment #64910|0 |1 is obsolete| | Attachment #64911|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 68575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68575&action=ed… Bug 9031: Unit tests for DST crossing in (days|hours)_between Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Without the patch for Calendar.pm, this crashes on: Invalid local time for date in time zone: America/New_York But even with the original change to Calendar.pm, I would see: Invalid local time for date in time zone: Europe/Amsterdam Adding a follow-up for that. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9031] Overdue items crossing DST boundary throw invalid local time exception
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '17

26 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19341] New: Default location is always PROC when enter Item first time manually
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '17

26 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19341 Bug ID: 19341 Summary: Default location is always PROC when enter Item first time manually Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: mishravk79(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org When added item first time directly from cataloguing module after creating new biblio and selecting some new location i.e. other than PROC , even though system fixed PROC location unless we again modify the item shelving location. Tested on Koha 16.11.11 installed on debian via package. The test plan are: 1. Make NewItemsDefaultLocation is system preferences "PROC" and in ACQ framework default 952$c is also PROC 2. Enter new biblio in system 3. Add item informatin and choose shelving location other than PROC 4. Save the record/Item 5. Check the item shelving location, its still PROC 6. Now edit the same item 7. Select the new shelving location and save it 8. The new shelving location is visible The requirement is if we manually modify item shelving location (First time or later) it should obey the same. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 19331] New: When filtering by library, the analyticals are not recovered
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '17

26 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19331 Bug ID: 19331 Summary: When filtering by library, the analyticals are not recovered Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs(a)lists.koha-community.org Reporter: leire(a)scanbit.net When I look for the title of an analytical, I get the analytical I am looking for. But when I filter by library, I don't get the analyical in any of libraries. This is because the analytical have not any item, but it should appear in the libraries of the source document. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 17381] New: Add system preference SCOUserHTML
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '17

26 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Bug ID: 17381 Summary: Add system preference SCOUserHTML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org Add a system preference SCOUserHTML to display content on the self checkout page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 25