October 2017 - Koha-bugs - lists.koha-community.org

[Bug 13847] Cannot download large reports as Open Office Spreadsheet ODS
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13847 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #141 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 68525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68525&action=ed… Bug 7317: (followup) Fix id and class on body tag The HTML body tag looked like this: <body id="acq_suggestion" class="acq"> Probably an overlooked copypasta. This patch changes it to: <body id="illrequests" class="ill"> This should not have any visual side effects. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68516|0 |1 is obsolete| | --- Comment #140 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 68524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68524&action=ed… Bug 7317: Adjust packages koha-conf.xml Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Magnus Enger <magnus(a)libriotech.no> Original sign off message: It's impossible to give a test plan for this... I have implemented a "plugin" for Norwegian ILL (based on NCIP): https://github.com/Libriotech/koha-illbackend-nncipp Several issues have been discovered while writing the plugin, and Alex has fixed them along the way. Currently I do not know about any funcional issues, and I am happy to sign off. Update: I have applied the new patchset and done some exploratory testing, using the Dummy backend. Everything seems to be fine after the patches were re-arranged and with the followups from Tomas. All tests pass. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68485|0 |1 is obsolete| | --- Comment #139 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 68523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68523&action=ed… Bug 7317: (followup) Migrate endpoint to OpenAPI This patch moves the current endpoint implementation from Swagger2 to the OpenAPI plugin. It also takes advantage of the overloaded Koha::Illrequest::TO_JSON method which has now the option to embed what's needed for the REST api. The path spec is adjusted to fit OpenAPI, and some minor fixes are applied: - Missing 'metadata' query param - 'ill' permissions should be required instead of 'borrowers' - Full test coverage To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/api/v1/illrequests.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Magnus Enger <magnus(a)libriotech.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68484|0 |1 is obsolete| | --- Comment #138 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 68522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68522&action=ed… Bug 7317: Overload Koha::Illrequest::TO_JSON This patch implements an overloaded TO_JSON method, that introduces the option to (selectively) embed information required on the REST api. Tests are included for the new method. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Illrequests.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Magnus Enger <magnus(a)libriotech.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68483|0 |1 is obsolete| | --- Comment #137 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 68521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68521&action=ed… Bug 7317: (QA folowup) 404 if module is disabled (intranet) Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Magnus Enger <magnus(a)libriotech.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68409|0 |1 is obsolete| | --- Comment #136 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 68520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68520&action=ed… Bug 7317: DO NOT PUSH: Update OPAC CSS Signed-off-by: Magnus Enger <magnus(a)libriotech.no> It's impossible to give a test plan for this... I have implemented a "plugin" for Norwegian ILL (based on NCIP): https://github.com/Libriotech/koha-illbackend-nncipp Several issues have been discovered while writing the plugin, and Alex has fixed them along the way. Currently I do not know about any funcional issues, and I am happy to sign off. I think this is one of those things we need to get into Koha so we can start using it and find any remaining bugs. One non-functional thing that needs to be looked at are the tests. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68408|0 |1 is obsolete| | --- Comment #135 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 68519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68519&action=ed… Bug 7317: Interlibrary loans framework for Koha. This Commit is at the heart of adding an interlibrary loans framework for Koha. The framework does not prescribe a particular workflow. Instead it provides a general framework that can be extended & implemented by individual backends whose responsibility it is to implement a specific workflow. The module is largely self-sufficient: it adds new tables to the Koha database and touches only a few files in the Koha source tree. Primarily, we add our files to the Makefile and the koha-conf.xml, define ill paths for the REST API, and introduce links from the main intranet, opac pages & user permissions. Outside of this we simply add new files & functionality. Signed-off-by: Magnus Enger <magnus(a)libriotech.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68407|0 |1 is obsolete| | --- Comment #134 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 68518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68518&action=ed… Bug 7317: DO NOT PUSH: Updated Schema Files. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68406|0 |1 is obsolete| | --- Comment #133 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 68517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68517&action=ed… Bug 7317: Add SQL templates & sysprefs. * installer/data/mysql/atomicupdate/ill_tables.sql: New file. * installer/data/mysql/kohastructure.sql: Add tables. * installer/data/mysql/sysprefs.sql: Add sysprefs. * installer/data/mysql/userflags.sql: Add userflags. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add sysprefs to UI. Signed-off-by: Magnus Enger <magnus(a)libriotech.no> -- You are receiving this mail because: You are watching all bug changes.

1 0