October 2017 - Koha-bugs - lists.koha-community.org

[Bug 9031] Overdue items crossing DST boundary throw invalid local time exception
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 --- Comment #16 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Spending some time here.. Coming back tomorrow -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form.
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Fiona Borthwick <fiona.borthwick(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #50 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- (In reply to Marcel de Rooy from comment #48) > Please squash the patches. > I am not sure why you change IsAvailableForItemLevelRequest in the third > patch. Please explain. Where is it called in the process? It's called in opac/opac-reserve.pl. If you remove this changes, for an item on hold in transit, you have the link "hold" in detail page but you get the message: Sorry, none of these items can be placed on hold. > > You add: > + my $flag = shift; > This is not really a clear name ;) > Where do you use this parameter ? No, it's an ugly remaining debug thing :) > > + if (Koha::Holds->search({itemnumber => $item->{itemnumber}, > + found => ['W', 'T']}, > + {order_by => {-asc => 'priority'}})) { > Why do you order_by if you are interested only in the number ? No reason. And i need a ->count at the end because a resultset is always true. I added a test to cover that. > > + return 0; > + return GetReserveStatus($item->{itemnumber}) eq "Waiting"; > When will you reach this second return ? Oops! A mistake. The last is no more needed. > > +my $itemsWaitingOrInTransit = Koha::Holds->search( > + { > + biblionumber => $biblionumber, > + found => ['W', 'T'] > + })->count(); > + > +foreach my $item ( Koha::Items->search(biblionumber => $biblionumber) ) { > + $itemsWaitingOrInTransit = 1 if $item->get_transfer; > +} > If the flag is set, there is no need to start traversing all items or keep > doing so. I change the code to avoid this I've also squashed patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68197|0 |1 is obsolete| | Attachment #68198|0 |1 is obsolete| | Attachment #68199|0 |1 is obsolete| | --- Comment #49 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Created attachment 68531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68531&action=ed… Bug 4319 - [OPAC] allow to holds waiting items Test plan: - Checkout an item - Place hold on this item, - Return the item - Make sure the hold is waiting (found W) and AllowOnShelfHolds is not to 'Allow' - Check that the button "Place hold" appears in opac detail page of the biblio - do the samewith items/reserves in transit Changes on C4::Reserves::IsAvailableForItemLevelRequest Make sure this tests pass: - t/db_dependent/Reserves.t - t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Sally Healey <sally.healey(a)cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8437] Large database backups and large exports from export.pl fail under plack
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13847] Cannot download large reports as Open Office Spreadsheet ODS
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13847 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #141 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 68525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68525&action=ed… Bug 7317: (followup) Fix id and class on body tag The HTML body tag looked like this: <body id="acq_suggestion" class="acq"> Probably an overlooked copypasta. This patch changes it to: <body id="illrequests" class="ill"> This should not have any visual side effects. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68516|0 |1 is obsolete| | --- Comment #140 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 68524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68524&action=ed… Bug 7317: Adjust packages koha-conf.xml Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Magnus Enger <magnus(a)libriotech.no> Original sign off message: It's impossible to give a test plan for this... I have implemented a "plugin" for Norwegian ILL (based on NCIP): https://github.com/Libriotech/koha-illbackend-nncipp Several issues have been discovered while writing the plugin, and Alex has fixed them along the way. Currently I do not know about any funcional issues, and I am happy to sign off. Update: I have applied the new patchset and done some exploratory testing, using the Dummy backend. Everything seems to be fine after the patches were re-arranged and with the followups from Tomas. All tests pass. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68485|0 |1 is obsolete| | --- Comment #139 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 68523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68523&action=ed… Bug 7317: (followup) Migrate endpoint to OpenAPI This patch moves the current endpoint implementation from Swagger2 to the OpenAPI plugin. It also takes advantage of the overloaded Koha::Illrequest::TO_JSON method which has now the option to embed what's needed for the REST api. The path spec is adjusted to fit OpenAPI, and some minor fixes are applied: - Missing 'metadata' query param - 'ill' permissions should be required instead of 'borrowers' - Full test coverage To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/api/v1/illrequests.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Magnus Enger <magnus(a)libriotech.no> -- You are receiving this mail because: You are watching all bug changes.

1 0