October 2017 - Koha-bugs - lists.koha-community.org

[Bug 13560] need an add option in marc modification templates
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64808|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 68540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68540&action=ed… Bug 13560 - need an add option in marc modification templates Add/Update would update a field or create new if it existed, but didn't allow for creating new if the field existed. This patchset splits the options to Add & Update so that add will always add a field and Update will operate as it always has To test: 1 - Have a record with a known existing field (make a copy) 2 - Define a marc modification template that 'Add/update' on that field 3 - Define an 'Add/Update' on a field that doesn't exist 4 - Batch modify the copy of record using the above template 5 - Verify the existing field was updated 6 - Verify the non-existing field was updated 7 - Apply patch 8 - Make another copy 9 - Modify the copy with the same template as above 10 - Should match initial modification 11 - Add a new rule to add a new field 12 - Modify using the updated template 13 - Ensure your new field is created 14 - Test various options in the modification tool 15 - prove t/db_dependent/MarcModificationTemplates.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13560] need an add option in marc modification templates
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19298] New: allow_onshelf_holds is not calculated correctly in opac-shelves
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19298 Bug ID: 19298 Summary: allow_onshelf_holds is not calculated correctly in opac-shelves Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org The call is: $this_item->{allow_onshelf_holds} = C4::Reserves::OnShelfHoldsAllowed($this_item, $patron); But $this_item is not an item, but bibliographic record information. C4::Reserves::_get_itype is used to know the correct "itemtype", but biblioitems.itemtype will always be picked as we do not have items information. -- You are receiving this mail because: You are watching all bug changes.

1 23

[Bug 19028] New: Add 'shelving location' to holdings table in detail page
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19028 Bug ID: 19028 Summary: Add 'shelving location' to holdings table in detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Bug 16759 adds a simpler way to customize what columns are displayed on the holdings table in the OPAC detail view. It would be desired to allow moving the shelving location from below the library name, into its own column. This should be done in a way that preserves current behaviour. This can easily achieved by introducing a new syspref. -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 18184] New: Subscriptions summaries don' t show if seeing all subs attached to a biblio
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18184 Bug ID: 18184 Summary: Subscriptions summaries don't show if seeing all subs attached to a biblio Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleishaamohia(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 12

[Bug 17277] New: Current Location column in Holdings table showing empty under OPAC
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17277 Bug ID: 17277 Summary: Current Location column in Holdings table showing empty under OPAC Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: erjon.sulaj(a)uart.edu.al QA Contact: testopia(a)bugs.koha-community.org Created attachment 55333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55333&action=ed… item details opac Hi, for a couple of days I tried to resolve the problem by double checking the cataloging process, or item details, but at no avail. The problem is that the holdings detail table does not show anything under the "current location" field when accessing item details under OPAC, while it shows all the details if accessed from staff interface. I am attaching the pictures for what I stated above. Best regards, -- You are receiving this mail because: You are watching all bug changes.

1 37

[Bug 18735] New: Print Barcode as soon as adding an item
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18735 Bug ID: 18735 Summary: Print Barcode as soon as adding an item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: kohadevinim(a)devinim.com.tr QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl When the librarians add an item they want print directly its barcode. -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 9031] Overdue items crossing DST boundary throw invalid local time exception
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 --- Comment #16 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Spending some time here.. Coming back tomorrow -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form.
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Fiona Borthwick <fiona.borthwick(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 25 Oct '17

25 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #50 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- (In reply to Marcel de Rooy from comment #48) > Please squash the patches. > I am not sure why you change IsAvailableForItemLevelRequest in the third > patch. Please explain. Where is it called in the process? It's called in opac/opac-reserve.pl. If you remove this changes, for an item on hold in transit, you have the link "hold" in detail page but you get the message: Sorry, none of these items can be placed on hold. > > You add: > + my $flag = shift; > This is not really a clear name ;) > Where do you use this parameter ? No, it's an ugly remaining debug thing :) > > + if (Koha::Holds->search({itemnumber => $item->{itemnumber}, > + found => ['W', 'T']}, > + {order_by => {-asc => 'priority'}})) { > Why do you order_by if you are interested only in the number ? No reason. And i need a ->count at the end because a resultset is always true. I added a test to cover that. > > + return 0; > + return GetReserveStatus($item->{itemnumber}) eq "Waiting"; > When will you reach this second return ? Oops! A mistake. The last is no more needed. > > +my $itemsWaitingOrInTransit = Koha::Holds->search( > + { > + biblionumber => $biblionumber, > + found => ['W', 'T'] > + })->count(); > + > +foreach my $item ( Koha::Items->search(biblionumber => $biblionumber) ) { > + $itemsWaitingOrInTransit = 1 if $item->get_transfer; > +} > If the flag is set, there is no need to start traversing all items or keep > doing so. I change the code to avoid this I've also squashed patch -- You are receiving this mail because: You are watching all bug changes.

1 0