October 2017 - Koha-bugs - lists.koha-community.org

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '17

23 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68009|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '17

23 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68008|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '17

23 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes(a)biblibre.com --- Comment #92 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Patch tested with a sandbox, by Axelle Clarisse <axelle.clarisse(a)univ-amu.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '17

23 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #43 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: Why do you add in catalogue/search.pl: +use String::Random; +@results_per_page_options = do { my %seen; grep { !$seen{$_}++ } @results_per_page_options }; Could you 'do' this without a do statement? Do you need uniq from List::More ? Is it really needed btw? Do you expect duplicate numbers in this pref.. results.tt Why are you changing the lines with respect to list counts? What is the relation with this patch? opac-search.pl -$offset = ($page-1)*$results_per_page if $page>1; Why do you remove it ? - ($error, $results_hashref, $facets) = C4::Search::pazGetRecords($query,$simple_query,\@sort_by,\@servers,$results_per_page,$offset,$expanded_facet,undef,$query_type,$scan); + ($error, $results_hashref, $facets) = C4::Search::pazGetRecords($query,$simple_query,\@sort_by,\@servers,$results_per_page,$offset,$expanded_facet,$query_type,$scan); You remove a undef parameter. Why? Is this a bug on its own? What is the relation with this report? Please clarify or adjust. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '17

23 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 --- Comment #8 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Alex Buckley from comment #7) > Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> Thanks Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12768] Replacement cost and processing fee management
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '17

22 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual --- Comment #101 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi, could you please write up instructions for this for the manual? You can either do a merge request or send me text and screenshots: https://wiki.koha-community.org/wiki/Editing_the_Koha_Manual I am not sure yet how the note pref works, having an example there would be nice! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '17

22 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '17

22 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 --- Comment #35 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 68366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68366&action=ed… Bug 8630 - Regenerated CSS - Not minified, do NOT PUSH! Had trouble with rgenerating the minified CSS in kohadevbox, but uploading this as a help for others. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '17

22 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43260|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '17

22 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 --- Comment #34 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Instructions on recreating the less changes are here: https://wiki.koha-community.org/wiki/Working_with_Bootstrap_OPAC_LESS_files I am super impressed with how fast and well the cover service works! I am having trouble to generate the minified version in kohadevbox, I will upload my non-minified file for further testing, but we need to fix this correctly in the patches to be pushed. 1) Staff result list - OK 2) Staff detail page - Cover is in the wrong spot, please check! 3) OPAC result list - OK 4) OPAC detail page - OK 5) Recent reviews - OK 6) Recent reviews - RSS - OK 7) OPAC - patron account - reading history - OK 8) OPAC - patron account - checkouts - OK 9) OPAC - patron account - overdues - Not ok, I think some code here is missing, but if condition was changed in the template. Read the code for opac-results-grouped.tt, but couldn't test. I am not sure if the feature this template is used is still usable even. Should not be a blocker. Aleisha, could you try to generate the minified CSS and take a look at the two problem cases? -- You are receiving this mail because: You are watching all bug changes.

1 0